Kiu/Node_Exporter
Kiu/Node_Exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-11-23 20:36:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Escape all illegal chars in metric names.

Browse Source 
E.g. right now there are some metrics with dashes in their names, which cannot
be queried through the UI.
This commit is contained in:
Julius Volz 2013-08-15 13:20:06 +02:00
parent 9ea37d8b44
commit 4fcd1a9b38
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
exporter/gmond_collector.go
View File

@ -8,7 +8,7 @@ import (
"github.com/prometheus/node_exporter/exporter/ganglia" "github.com/prometheus/node_exporter/exporter/ganglia"
"io" "io"
"net" "net"
"strings" "regexp"
"time" "time"
) )
@ -25,6 +25,8 @@ type gmondCollector struct {
registry prometheus.Registry registry prometheus.Registry
} }
var illegalCharsRE = regexp.MustCompile(`[^a-zA-Z0-9_]`)
// Takes a config struct and prometheus registry and returns a new Collector scraping ganglia. // Takes a config struct and prometheus registry and returns a new Collector scraping ganglia.
func NewGmondCollector(config config, registry prometheus.Registry) (collector gmondCollector, err error) { func NewGmondCollector(config config, registry prometheus.Registry) (collector gmondCollector, err error) {
collector = gmondCollector{ collector = gmondCollector{
@ -84,7 +86,7 @@ func (c *gmondCollector) Update() (updates int, err error) {
for _, host := range cluster.Hosts { for _, host := range cluster.Hosts {
for _, metric := range host.Metrics { for _, metric := range host.Metrics {
name := strings.Replace(strings.ToLower(metric.Name), ".", "_", -1) name := illegalCharsRE.ReplaceAllString(metric.Name, "_")
var labels = map[string]string{ var labels = map[string]string{
"cluster": cluster.Name, "cluster": cluster.Name,