Kiu/Node_Exporter
Kiu/Node_Exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-11-23 20:36:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: data race of NetClassCollector metrics initialization when multiple requests happen (#2995)

Browse Source 
Signed-off-by: John Guo <john@johng.cn>
This commit is contained in:
John Guo 2024-04-19 23:15:54 +08:00 committed by GitHub
parent dc5d3ca0ae
commit e9e27138a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
collector/netclass_linux.go
View File

@ -22,6 +22,7 @@ import (
"net" "net"
"os" "os"
"regexp" "regexp"
"sync"
"github.com/alecthomas/kingpin/v2" "github.com/alecthomas/kingpin/v2"
"github.com/go-kit/log" "github.com/go-kit/log"
@ -41,6 +42,7 @@ type netClassCollector struct {
subsystem string subsystem string
ignoredDevicesPattern *regexp.Regexp ignoredDevicesPattern *regexp.Regexp
metricDescs map[string]*prometheus.Desc metricDescs map[string]*prometheus.Desc
metricDescsMu sync.Mutex
logger log.Logger logger log.Logger
} }
@ -136,6 +138,9 @@ func (c *netClassCollector) netClassSysfsUpdate(ch chan<- prometheus.Metric) err
} }
func (c *netClassCollector) getFieldDesc(name string) *prometheus.Desc { func (c *netClassCollector) getFieldDesc(name string) *prometheus.Desc {
c.metricDescsMu.Lock()
defer c.metricDescsMu.Unlock()
fieldDesc, exists := c.metricDescs[name] fieldDesc, exists := c.metricDescs[name]
if !exists { if !exists {