Commit Graph

1441 Commits

Author SHA1 Message Date
beorn7
024d5ed55e Fix title of CPU panel to usage
We use the `mode="idle"` metric, but we are inverting it, so this is
usage, and that's intended.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-08-15 16:36:10 +02:00
beorn7
a016d9cd6f node-mixin: Improve disk usage panel
- Use a stacked graph instead of a gauge as development over time is
  especially useful for disk space usage.

- By only taking one metric per device into account, we avoid
  double-counting for devices that are mounted multiple times.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-08-15 16:32:54 +02:00
Björn Rabenstein
7ef6f2576d
node-mxin: Improve nodes dashboard (#1448)
* node-mixin: Improve nodes dashboard

- Use stacking where it makes sense.
- Normalize idle CPU so that stacking is more meaningful.
- Consistently fill where stacking is used but don't fill where not.
- Fix y axis max value for Idle CPU panel.
- Fix y axis min value for memory usage panel.
- Use `$__interval` for range where applicable (and set min step
  to 1m).
- Make the right Y axis for disk I/O actually work.

This is just an incremental improvements. It doesn't touch the more
involved TODOs.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-08-15 00:40:51 +02:00
Björn Rabenstein
0d3a2d3209
Merge pull request #1447 from prometheus/beorn7/mixin
node-mixin: Fix various straight-forward issues in the USE dashboards
2019-08-15 00:37:43 +02:00
beorn7
97ef113762 Make the severity of "critical" alerts configurable
This addresses the blissful scenario where single-node failures are
unproblematic. No reason to wake somebody up if a node is about to
screw itself up by filling the disk.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-08-14 22:24:24 +02:00
beorn7
f350aaf87e node-mixin: Fix various straight-forward issues in the USE dashboards
- Normalize cluster memory utilisation.

- Fix missing `1m` in memory saturation.

- Have both disk-related row next to each other instead with the
  network row in between.

- Correctly render transmit network traffic as negative, using
  `seriesOverrides` and `min: null` for the y-axis.

- Make panel and row naming consistent.

- Remove legend where it would just display a single entry with
  exactly the title of the panel.

- Fix metric name in individual node CPU Saturation panel.

- Break up disk space utilisation by device in the panel for an
  individual node.

NB: All of that doesn't touch any more subtle issues captured in the
various TODOs.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-08-13 21:54:28 +02:00
Sandro Jäckel
697c2deed5 Update rootfs syntax in Docker example (#1443)
Signed-off-by: Sandro Jäckel <sandro.jaeckel@gmail.com>
2019-08-07 09:19:20 +02:00
Phil Frost
26d4fbdf07 Fix seconds reported by schedstat (#1426)
Upstream bugfix: https://github.com/prometheus/procfs/pull/191

Signed-off-by: Phil Frost <phil@postmates.com>
2019-08-06 19:08:06 +02:00
Richard Kojedzinszky
75462bf4fe Scrape thermal_zone temperatures (#1425)
* Scrape thermal_zone temperatures

Signed-off-by: Richard Kojedzinszky <richard@kojedz.in>
2019-08-04 12:56:36 +02:00
Ben Kochie
10146109ec
Update CHANGELOG for #1433
Signed-off-by: Ben Kochie <superq@gmail.com>
2019-08-03 12:33:25 +02:00
Philip Gough
2d95ecaa96 Extends uname collector to export on Darwin OS (#1433)
Adds uname collector support for Darwin and OpenBSD

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
2019-08-03 12:32:43 +02:00
PrometheusBot
2f2392af3f makefile: update Makefile.common with newer version (#1434)
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2019-08-03 12:15:24 +02:00
Johannes 'fish' Ziemke
fc73586c97 Remove text_collector_examples/ (#1441)
* Remove text_collector_examples/

These have been moved to https://github.com/prometheus-community/node-exporter-textfile-collector-scripts

This closes #1077

Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
2019-08-03 12:14:51 +02:00
Solvik
0b710bb0c9 Handle JBOD setup for storcli exporter (#1419)
* handle jbod setup

Signed-off-by: Solvik Blum <solvik.blum@dailymotion.com>
2019-08-02 12:38:46 +02:00
Dipack P Panjabi
a7452023db Added mountinfo changes to node_exporter (#1417)
Use the extra information gleaned from the mountinfo file to add
a 'mountaddr' field for NFS metrics. This helps prevent prometheus from
ignoring mounts that come from the same URL, but are actually from
different IP addresses.

This commit also rebases to current master

Signed-off-by: Dipack P Panjabi <dpanjabi@hudson-trading.com>
2019-07-28 11:32:40 +02:00
Ben Kochie
852b340a46
Add changelog entry for #1439
Signed-off-by: Ben Kochie <superq@gmail.com>
2019-07-28 10:38:41 +02:00
Matthias Rampke
b133213c7a Report non-fatal collection errors in the exporter metric. (#1439)
As per prometheus/client_golang#543, pass the Registry for exporter
metrics when setting up the /metrics HTTP handler.

With this, the `promhttp_metric_handler_errors_total` metric will
increment on (possibly non-fatal) collection-time errors, such as
duplicate metrics from text files.

Signed-off-by: Matthias Rampke <mr@soundcloud.com>
2019-07-28 10:37:10 +02:00
Bernd Müller
d2be72be4a changed fields for disk write and read data of S.M.A.R.T, Signed-off-by: Bernd Mueller <mueller@b1-systems.de> (#1235)
Signed-off-by: Bernd Müller <mueller@b1-systems.de>
2019-07-24 17:46:50 +02:00
Björn Rabenstein
443072dfc3
Merge pull request #1438 from paulfantom/fix_selectors
docs/node-mixin: fix incorrect queries
2019-07-24 15:24:42 +02:00
paulfantom
c41826274d
docs/node-mixin: move fsSelector and diskDeviceSelector to the end of query
This will cause a query to be valid even if values of selector are
empty.

Additionally fixing query responsible for disk space usage.

Signed-off-by: paulfantom <pawel@krupa.net.pl>
2019-07-24 13:05:02 +02:00
Björn Rabenstein
106b09b4ed
Merge pull request #1429 from prometheus/beorn7/mixin
First iteration for the node mixin, 2nd attempt.
2019-07-23 23:14:15 +02:00
beorn7
79f0357e38 Added _excluding_lo to name of network rules that exclude lo
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-22 20:21:52 +02:00
beorn7
36dc7451c9 Improvement of comments and panel titles
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-22 14:06:27 +02:00
dt-rush
5d3e2ce2ef properly strip path.rootfs from mountpoint labels (#1421)
Change-type: patch
Connects-to: #1418
Signed-off-by: dt-rush <nickp@balena.io>
2019-07-19 16:51:17 +02:00
beorn7
e01d9f9e78 Break out device in disk IO rules/dashboard
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-18 15:59:35 +02:00
beorn7
b8c4b0cb29 Removed unneeded sum_ and avg_ from rule names
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-18 14:14:02 +02:00
beorn7
706511a495 Responses to review comments, round 3
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-17 23:54:31 +02:00
beorn7
3a770a0b1d Convert annotations from message to summary/description
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-16 21:40:57 +02:00
beorn7
a92d1d7889 Address review comments, batch 2
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-16 21:18:17 +02:00
beorn7
3ab1f41d12 Make more use of config.libsonnet
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-16 19:34:27 +02:00
beorn7
2180c2f3bf Address first batch of old review comments
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-16 19:14:17 +02:00
Steven Kreuzer
d8e47a9f9f Expose additional XFS runtime statistics (#1423)
Include directory operation, read/write system call, and vnode runtime
statistics for XFS filesystems.

Signed-off-by: Steven Kreuzer <skreuzer@FreeBSD.org>
2019-07-15 16:28:09 +02:00
Ben Kochie
0de95ef8f3
Add changelog entry for #1414
Signed-off-by: Ben Kochie <superq@gmail.com>
2019-07-12 14:25:17 +02:00
detailyang
7fe9713edf bugfix: avoid nil reference when ignore is nil (#1414)
Signed-off-by: detailyang <detailyang@gmail.com>
2019-07-12 14:23:54 +02:00
beorn7
b3b47f2d07 Make selector naming consistent
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-10 20:09:01 +02:00
beorn7
dec5b5b053 Fix indentation
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-10 20:07:20 +02:00
beorn7
9d7045e483 (Re-)adjust to Grafana gauge expecting percentage 0-100 (rather than 1-0)
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-10 19:40:04 +02:00
Phil Frost
f693a71c06 Scrape CPU latency stats from /proc/schedstat (#1389)
These are useful as a direct indication of CPU contention and task
scheduler latency.

Handy references:
 - https://github.com/torvalds/linux/blob/master/Documentation/scheduler/sched-stats.txt
 - https://doc.opensuse.org/documentation/leap/tuning/html/book.sle.tuning/cha.tuning.taskscheduler.html

procfs is updated to pull in the enabling change:
https://github.com/prometheus/procfs/pull/186

Signed-off-by: Phil Frost <phil@postmates.com>
2019-07-10 09:16:24 +02:00
秋葉
777b751f90 read /proc/net files with a single read syscall (#1380)
Signed-off-by: Hanaasagi <ambiguous404@gmail.com>
2019-07-08 15:53:14 +02:00
beorn7
f331b308f3 Use promgrafonnet as a vendored library from its source
The only deviation that happened so far is to use format="percentunit"
in a Grafana gauge. This change wasn't even properly used in this repo
so far, so I opted to stick with "upstream" for now. If changes are
really needed, we can try to change upstream first.

Another change was done in parallal here and upstream, but it was
"more correct" in upstream. (Change datasource to $datasource
variable, only partially applied here.) Which is another point for
using the upstream and not copy it here.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-06 21:11:23 +02:00
beorn7
e5266c242e Add README.md
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-06 20:30:40 +02:00
beorn7
f2891703a5 Add Makefile to easily make output files and lint sources
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-06 20:21:56 +02:00
beorn7
f17829c48b Create jsonnet files to create output files
This allows to create YAML files with rules and JSON files with
dashboard descriptions.

Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-06 20:11:27 +02:00
beorn7
cd2981f1b8 Update vendoring to current location of jsonnet-libs
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-06 20:10:47 +02:00
beorn7
2df034c055 Move node-mixin into docs directory
Signed-off-by: beorn7 <beorn@grafana.com>
2019-07-05 19:38:03 +02:00
beorn7
61bcc5b468 Merge branch 'mixin' of git://github.com/tomwilkie/node_exporter into beorn7/mixin 2019-07-05 19:28:54 +02:00
Derek Marcotte
3d504bc5cb Added FreeBSD zfs support per #1063. (#1394)
Based on the solaris implementation.  There's a lot of other sysctls
available on FreeBSD that aren't reported here.  It'll be easy to add,
if they're useful.  All of the sysctls are uint64.

Signed-off-by: Derek Marcotte <554b8425@razorfever.net>
2019-07-03 15:47:39 +02:00
Simon Pasquier
0841244283 Use Prometheus Circle CI's orb (#1412)
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-07-02 18:40:25 +02:00
Benjamin Drung
cdd9a5fdef Update procfs to v0.0.4-0.20190627154503-39e1aff1547e (#1409)
procfs v0.0.4-0.20190627154503-39e1aff1547e is a requirement for
https://github.com/prometheus/node_exporter/pull/1357 (because procfs
v0.0.3 contained bug https://github.com/prometheus/procfs/pull/187)

Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
2019-07-01 12:23:50 +02:00
Advait Bhatwadekar
3f49b31101 Closes issue #261 on node_exporter. (#1403)
* Closes issue #261 on node_exporter.

Delegated mdstat parsing to procfs project. mdadm_linux.go now only exports the metrics.
-> Added disk labels: "fail", "spare", "active" to indicate disk status
-> hanged metric node_md_disks_total ==> node_md_disks_required
-> Removed test cases for mdadm_linux.go, as the functionality they tested for has been moved to procfs project.

Signed-off-by: Advait Bhatwadekar <advait123@ymail.com>
2019-07-01 11:56:06 +02:00