Kiu/Semaphore
Kiu/Semaphore
1
0
Fork 0
mirror of https://github.com/semaphoreui/semaphore.git synced 2025-01-20 15:29:28 +01:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(runner): error code validation

Browse Source
This commit is contained in:
Denis Gukov 2024-10-14 21:07:24 +00:00
parent 54296bd4bf
commit fd782bc1cb
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
services/runners/job_pool.go
View File

@ -277,11 +277,14 @@ func (p *JobPool) sendProgress() {
resp, err := client.Do(req) resp, err := client.Do(req)
if err != nil { if err != nil {
logger.ActionError(err, "send request", "the server returned error")
logger.ActionError(err, "send request", "the server returned error "+strconv.Itoa(resp.StatusCode))
return return
} }
if resp.StatusCode >= 400 {
logger.ActionError(fmt.Errorf("invalid status code"), "send request", "the server returned error "+strconv.Itoa(resp.StatusCode))
}
defer resp.Body.Close() defer resp.Body.Close()
} }
@ -318,8 +321,14 @@ func (p *JobPool) tryRegisterRunner() bool {
} }
resp, err := client.Do(req) resp, err := client.Do(req)
if err != nil || resp.StatusCode != 200 {
logger.ActionError(err, "send request", "the server returned error "+strconv.Itoa(resp.StatusCode)) if err != nil {
logger.ActionError(err, "send request", "unexpected error")
return false
}
if resp.StatusCode != 200 {
logger.ActionError(fmt.Errorf("invalid status code"), "send request", "the server returned error "+strconv.Itoa(resp.StatusCode))
return false return false
} }
@ -378,7 +387,7 @@ func (p *JobPool) checkNewJobs() {
resp, err := client.Do(req) resp, err := client.Do(req)
if err != nil { if err != nil {
logger.ActionError(err, "send request", "the server returned an error"+strconv.Itoa(resp.StatusCode)) logger.ActionError(err, "send request", "upexpected error")
return return
} }