Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-18 14:40:26 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/logstorage: quote logfmt strings only if they contain special chars, which could break logfmt parsing and/or reading
Some checks are pending
build / Build (push) Waiting to run
Details
CodeQL Go / Analyze (push) Waiting to run
Details
main / lint (push) Waiting to run
Details
main / test (test-full) (push) Blocked by required conditions
Details
main / test (test-full-386) (push) Blocked by required conditions
Details
main / test (test-pure) (push) Blocked by required conditions
Details

Browse Source 
(cherry picked from commit 462b7cd597)
This commit is contained in:
Aliaksandr Valialkin 2024-10-07 14:31:16 +02:00 committed by hagen1778
parent f825a9de80
commit 0a61222627
No known key found for this signature in database
GPG Key ID: 3BF75F3741CA9640
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/logstorage/pipe_pack_logfmt_test.go
View File

@ -45,7 +45,7 @@ func TestPipePackLogfmt(t *testing.T) {
},
}, [][]Field{
{
{"_msg", `_msg=x foo=abc bar="cde=ab"`},
{"_msg", `_msg=x foo=abc bar=cde=ab`},
{"foo", `abc`},
{"bar", `cde=ab`},
},

14
lib/logstorage/rows.go
View File

@ -91,13 +91,25 @@ func getFieldValue(fields []Field, name string) string {
func needLogfmtQuoting(s string) bool {
for _, c := range s {
if !isTokenRune(c) {
if isLogfmtSpecialChar(c) {
return true
}
}
return false
}
func isLogfmtSpecialChar(c rune) bool {
if c <= 0x20 {
return true
}
switch c {
case '"', '\\':
return true
default:
return false
}
}
// RenameField renames field with the oldName to newName in Fields
func RenameField(fields []Field, oldName, newName string) {
if oldName == "" {