From 0dca224ec3a41737172b5b0c13e87f7ca3130692 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Fri, 23 Dec 2022 22:22:10 -0800 Subject: [PATCH] app/vmui: small improvements for header panel - Rename `Custom panel` tab to more clear `Query` tab - Rename `Cardinality` tab to `Explore cardinality`, so it becomes consistent with `Explore metrics` tab - Move `Dashboards` tab to the end, since it isn't used too much --- README.md | 2 +- app/vmui/packages/vmui/src/App.tsx | 8 ++++---- .../vmui/src/components/Layout/Header/Header.tsx | 10 +++++----- app/vmui/packages/vmui/src/router/index.ts | 12 ++++++------ docs/README.md | 2 +- docs/Single-server-VictoriaMetrics.md | 2 +- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/README.md b/README.md index 22f7f0e02..15ac04d73 100644 --- a/README.md +++ b/README.md @@ -322,7 +322,7 @@ It is possible to change the selected time range for the graphs in the top right ## Cardinality explorer -VictoriaMetrics provides an ability to explore time series cardinality at `cardinality` tab in [vmui](#vmui) in the following ways: +VictoriaMetrics provides an ability to explore time series cardinality at `Explore cardinality` tab in [vmui](#vmui) in the following ways: - To identify metric names with the highest number of series. - To identify labels with the highest number of series. diff --git a/app/vmui/packages/vmui/src/App.tsx b/app/vmui/packages/vmui/src/App.tsx index 77af7c002..e93e58b40 100644 --- a/app/vmui/packages/vmui/src/App.tsx +++ b/app/vmui/packages/vmui/src/App.tsx @@ -40,10 +40,6 @@ const App: FC = () => { path={router.metrics} element={} /> - } - /> } @@ -56,6 +52,10 @@ const App: FC = () => { path={router.trace} element={} /> + } + /> } diff --git a/app/vmui/packages/vmui/src/components/Layout/Header/Header.tsx b/app/vmui/packages/vmui/src/components/Layout/Header/Header.tsx index a384bcf21..b15f7e35f 100644 --- a/app/vmui/packages/vmui/src/components/Layout/Header/Header.tsx +++ b/app/vmui/packages/vmui/src/components/Layout/Header/Header.tsx @@ -35,11 +35,6 @@ const Header: FC = () => { label: routerOptions[router.metrics].title, value: router.metrics, }, - { - label: routerOptions[router.dashboards].title, - value: router.dashboards, - hide: appModeEnable - }, { label: routerOptions[router.cardinality].title, value: router.cardinality, @@ -51,6 +46,11 @@ const Header: FC = () => { { label: routerOptions[router.trace].title, value: router.trace, + }, + { + label: routerOptions[router.dashboards].title, + value: router.dashboards, + hide: appModeEnable } ]), [appModeEnable]); diff --git a/app/vmui/packages/vmui/src/router/index.ts b/app/vmui/packages/vmui/src/router/index.ts index 52aff8135..b11738474 100644 --- a/app/vmui/packages/vmui/src/router/index.ts +++ b/app/vmui/packages/vmui/src/router/index.ts @@ -27,7 +27,7 @@ const routerOptionsDefault = { export const routerOptions: {[key: string]: RouterOptions} = { [router.home]: { - title: "Custom panel", + title: "Query", ...routerOptionsDefault }, [router.metrics]: { @@ -36,12 +36,8 @@ export const routerOptions: {[key: string]: RouterOptions} = { timeSelector: true, } }, - [router.dashboards]: { - title: "Dashboards", - ...routerOptionsDefault, - }, [router.cardinality]: { - title: "Cardinality", + title: "Explore cardinality", header: { cardinalityDatePicker: true, } @@ -54,6 +50,10 @@ export const routerOptions: {[key: string]: RouterOptions} = { title: "Trace analyzer", header: {} }, + [router.dashboards]: { + title: "Dashboards", + ...routerOptionsDefault, + }, [router.icons]: { title: "Icons", header: {} diff --git a/docs/README.md b/docs/README.md index bb26fc1f0..7e9192613 100644 --- a/docs/README.md +++ b/docs/README.md @@ -323,7 +323,7 @@ It is possible to change the selected time range for the graphs in the top right ## Cardinality explorer -VictoriaMetrics provides an ability to explore time series cardinality at `cardinality` tab in [vmui](#vmui) in the following ways: +VictoriaMetrics provides an ability to explore time series cardinality at `Explore cardinality` tab in [vmui](#vmui) in the following ways: - To identify metric names with the highest number of series. - To identify labels with the highest number of series. diff --git a/docs/Single-server-VictoriaMetrics.md b/docs/Single-server-VictoriaMetrics.md index e43b87946..bd678e390 100644 --- a/docs/Single-server-VictoriaMetrics.md +++ b/docs/Single-server-VictoriaMetrics.md @@ -326,7 +326,7 @@ It is possible to change the selected time range for the graphs in the top right ## Cardinality explorer -VictoriaMetrics provides an ability to explore time series cardinality at `cardinality` tab in [vmui](#vmui) in the following ways: +VictoriaMetrics provides an ability to explore time series cardinality at `Explore cardinality` tab in [vmui](#vmui) in the following ways: - To identify metric names with the highest number of series. - To identify labels with the highest number of series.