Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-23 20:37:12 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

app/vmselect/promql: return NaN values if invalid bucket counts are passed to histogram_quantile

Browse Source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/136
This commit is contained in:
Aliaksandr Valialkin 2019-07-30 22:04:16 +03:00
parent c14fd6c43f
commit 10f5a26bec
2 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/vmselect/promql/exec_test.go
View File

@ -2158,6 +2158,26 @@ func TestExecSuccess(t *testing.T) {
resultExpected := []netstorage.Result{r1, r2}
f(q, resultExpected)
})
t.Run(`histogram_quantile(negative-bucket-count)`, func(t *testing.T) {
t.Parallel()
q := `sort(histogram_quantile(0.6,
label_set(90, "foo", "bar", "le", "10")
or label_set(-100, "foo", "bar", "le", "30")
or label_set(300, "foo", "bar", "le", "+Inf")
))`
resultExpected := []netstorage.Result{}
f(q, resultExpected)
})
t.Run(`histogram_quantile(nan-bucket-count)`, func(t *testing.T) {
t.Parallel()
q := `sort(histogram_quantile(0.6,
label_set(90, "foo", "bar", "le", "10")
or label_set(NaN, "foo", "bar", "le", "30")
or label_set(300, "foo", "bar", "le", "+Inf")
))`
resultExpected := []netstorage.Result{}
f(q, resultExpected)
})
t.Run(`median_over_time()`, func(t *testing.T) {
t.Parallel()
q := `median_over_time({})`

12
app/vmselect/promql/transform.go
View File

@ -331,13 +331,17 @@ func transformHistogramQuantile(tfa *transformFuncArg) ([]*timeseries, error) {
return inf
}
vReq := xss[len(xss)-1].ts.Values[i] * phi
if math.IsNaN(vReq) || vReq < 0 {
// Broken bucket.
return nan
}
for _, xs := range xss {
v := xs.ts.Values[i]
le := xs.le
if v <= vPrev {
v = vPrev
le = lePrev
if math.IsNaN(v) || v < 0 {
// Broken bucket.
return nan
}
le := xs.le
if v < vReq {
vPrev = v
lePrev = le