Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-15 08:23:34 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/storage: fix broken BenchmarkHeadPostingForMatchers for {i=~".*"} after f4dead529f

Browse Source 
The commit f4dead529f makes such query to return nothing instead of all the time series.
This aligns more with Prometheus behaviour.
This commit is contained in:
Aliaksandr Valialkin 2022-02-12 00:27:08 +02:00
parent 791cad8c2e
commit 21a42e990f
No known key found for this signature in database
GPG Key ID: A72BEC6CD3D0DED1
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/storage/index_db_timing_test.go
View File

@ -206,7 +206,7 @@ func BenchmarkHeadPostingForMatchers(b *testing.B) {
b.Run(`i=~".*"`, func(b *testing.B) { b.Run(`i=~".*"`, func(b *testing.B) {
tfs := NewTagFilters(accountID, projectID) tfs := NewTagFilters(accountID, projectID)
addTagFilter(tfs, "i", ".*", false, true) addTagFilter(tfs, "i", ".*", false, true)
benchSearch(b, tfs, 5e6) benchSearch(b, tfs, 0)
}) })
b.Run(`i=~".+"`, func(b *testing.B) { b.Run(`i=~".+"`, func(b *testing.B) {
tfs := NewTagFilters(accountID, projectID) tfs := NewTagFilters(accountID, projectID)

2
lib/storage/tag_filters.go
View File

@ -168,7 +168,7 @@ func (tfs *TagFilters) Add(key, value []byte, isNegative, isRegexp bool) error {
} }
if isRegexp && string(value) == ".*" { if isRegexp && string(value) == ".*" {
if !isNegative { if !isNegative {
// Skip tag filter matching anything, since it equal to no filter. // Skip tag filter matching anything, since it equals to no filter.
return nil return nil
} }