Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-15 08:23:34 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/storage: document that getnerateUniqueMetricID should return dense ids

Browse Source
This commit is contained in:
Aliaksandr Valialkin 2020-05-14 14:08:39 +03:00
parent f442d81648
commit 2f42b85e0e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/storage/index_db.go
View File

@ -648,7 +648,7 @@ func (db *indexDB) generateTSID(dst *TSID, metricName []byte, mn *MetricName) er
if len(mn.Tags) > 1 { if len(mn.Tags) > 1 {
dst.InstanceID = uint32(xxhash.Sum64(mn.Tags[1].Value)) dst.InstanceID = uint32(xxhash.Sum64(mn.Tags[1].Value))
} }
dst.MetricID = getUniqueUint64() dst.MetricID = generateUniqueMetricID()
return nil return nil
} }
@ -2823,14 +2823,17 @@ func (is *indexSearch) intersectMetricIDsWithTagFilterNocache(tf *tagFilter, fil
var kbPool bytesutil.ByteBufferPool var kbPool bytesutil.ByteBufferPool
// Returns local unique MetricID. // Returns local unique MetricID.
func getUniqueUint64() uint64 { func generateUniqueMetricID() uint64 {
return atomic.AddUint64(&uniqueUint64, 1) // It is expected that metricIDs returned from this function must be dense.
// If they will be sparse, then this may hurt metric_ids intersection
// performance with uint64set.Set.
return atomic.AddUint64(&nextUniqueMetricID, 1)
} }
// This number mustn't go backwards on restarts, otherwise metricID // This number mustn't go backwards on restarts, otherwise metricID
// collisions are possible. So don't change time on the server // collisions are possible. So don't change time on the server
// between VictoriaMetrics restarts. // between VictoriaMetrics restarts.
var uniqueUint64 = uint64(time.Now().UnixNano()) var nextUniqueMetricID = uint64(time.Now().UnixNano())
func marshalCommonPrefix(dst []byte, nsPrefix byte, accountID, projectID uint32) []byte { func marshalCommonPrefix(dst []byte, nsPrefix byte, accountID, projectID uint32) []byte {
dst = append(dst, nsPrefix) dst = append(dst, nsPrefix)