Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-15 16:30:55 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/storage: inline marshalTags function and remove the code for handling duplicate tags from here

Browse Source 
This is a follow-up commit after c8ea697db8
This commit is contained in:
Aliaksandr Valialkin 2021-01-12 15:13:16 +02:00
parent 719ad49adf
commit 3d79471fb3
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
lib/storage/metric_name.go
View File

@ -381,7 +381,13 @@ func (mn *MetricName) Marshal(dst []byte) []byte {
dst = encoding.MarshalUint32(dst, mn.AccountID)
dst = encoding.MarshalUint32(dst, mn.ProjectID)
dst = marshalTagValue(dst, mn.MetricGroup)
dst = marshalTags(dst, mn.Tags)
// Marshal tags.
tags := mn.Tags
for i := range tags {
t := &tags[i]
dst = t.Marshal(dst)
}
return dst
}
@ -420,7 +426,9 @@ func (mn *MetricName) Unmarshal(src []byte) error {
// MarshalNoAccountIDProjectID appends marshaled mn without AccountID and ProjectID
// to dst and returns the result.
//
// The result must be unmarshaled with UnmarshalNoAccountIDProjectID
// The result must be unmarshaled with UnmarshalNoAccountIDProjectID.
//
// It is expected that mn.Tags are already sorted and de-duplicated with mn.sortTags.
func (mn *MetricName) MarshalNoAccountIDProjectID(dst []byte) []byte {
// Calculate the required size and pre-allocate space in dst
dstLen := len(dst)
@ -433,7 +441,11 @@ func (mn *MetricName) MarshalNoAccountIDProjectID(dst []byte) []byte {
dst = dst[:dstLen]
dst = marshalTagValue(dst, mn.MetricGroup)
dst = marshalTags(dst, mn.Tags)
tags := mn.Tags
for i := range tags {
t := &tags[i]
dst = t.Marshal(dst)
}
return dst
}
@ -716,20 +728,6 @@ func (ts *canonicalTagsSort) Swap(i, j int) {
x[i], x[j] = x[j], x[i]
}
func marshalTags(dst []byte, tags []Tag) []byte {
var prevKey []byte
for i := range tags {
t := &tags[i]
if string(prevKey) == string(t.Key) {
// Skip duplicate keys, since they aren't allowed in Prometheus data model.
continue
}
prevKey = t.Key
dst = t.Marshal(dst)
}
return dst
}
func copyTags(dst, src []Tag) []Tag {
dstLen := len(dst)
if n := dstLen + len(src) - cap(dst); n > 0 {