Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-23 12:31:07 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Revert "improve .gitignore"

Browse Source 
This reverts commit a8345bb1b9

Reason for revert: VictoriaMetrics binaries are consistently created inside `bin` directory at the root of the repository
when running `make <vm-app>` according to https://docs.victoriametrics.com/#how-to-build-from-sources

If some dev environments create binaries inside random directories, then it is better to provide docs
at https://docs.victoriametrics.com/#how-to-build-from-sources on how to setup these IDEs, so they
consistently create binaries at bin/* directory at the root of the repository instead of trying to add
random ignore rules inside .gitignore.

As for the data directories created by VictoriaMetrics components, they may be created at random places too,
so there is little sense in trying to add ignore rules for all these directories inside .gitignore.
It is better to document that the built binaries must be consistently started from the repository root,
so data directories are created at the repository root. The .gitignore already contains rule
for blocking common data directories, which can be created by VictoriaMetrics components at the repository root.
This commit is contained in:
Aliaksandr Valialkin 2023-10-12 20:04:32 +02:00
parent 964e6ccc17
commit 4f4bc515e0
No known key found for this signature in database
GPG Key ID: A72BEC6CD3D0DED1
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.gitignore vendored
View File

@ -22,13 +22,3 @@ Gemfile.lock
/_site
_site
*.tmp
# vm binaries
app/victoria-metrics/victoria-metrics
app/vmagent/vmagent
app/vmctl/vmctl
app/vmalert/vmalert
# vm default data folder
app/victoria-metrics/victoria-metrics-data/
app/vmagent/vmagent-remotewrite-data/