Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-05 22:32:20 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/mergeset: clarify comments in the code a bit

Browse Source
This commit is contained in:
Aliaksandr Valialkin 2021-02-16 18:02:57 +02:00
parent 7dee57da03
commit 500acb958c
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/mergeset/part.go
View File

@ -195,7 +195,7 @@ func (idxbc *indexBlockCache) MustClose() {
close(idxbc.cleanerStopCh) close(idxbc.cleanerStopCh)
idxbc.cleanerWG.Wait() idxbc.cleanerWG.Wait()
// It is safe returning idxbc.m to pool, since the Reset must be called // It is safe returning idxbc.m to pool, since the MustClose can be called
// when the idxbc entries are no longer accessed by concurrent goroutines. // when the idxbc entries are no longer accessed by concurrent goroutines.
for _, idxbe := range idxbc.m { for _, idxbe := range idxbc.m {
putIndexBlock(idxbe.idxb) putIndexBlock(idxbe.idxb)
@ -223,6 +223,8 @@ func (idxbc *indexBlockCache) cleanByTimeout() {
for k, idxbe := range idxbc.m { for k, idxbe := range idxbc.m {
// Delete items accessed more than two minutes ago. // Delete items accessed more than two minutes ago.
if currentTime-atomic.LoadUint64(&idxbe.lastAccessTime) > 2*60 { if currentTime-atomic.LoadUint64(&idxbe.lastAccessTime) > 2*60 {
// do not call putIndexBlock(ibxbc.m[k]), since it
// may be used by concurrent goroutines.
delete(idxbc.m, k) delete(idxbc.m, k)
} }
} }
@ -255,8 +257,8 @@ func (idxbc *indexBlockCache) Put(k uint64, idxb *indexBlock) {
// Remove 10% of items from the cache. // Remove 10% of items from the cache.
overflow = int(float64(len(idxbc.m)) * 0.1) overflow = int(float64(len(idxbc.m)) * 0.1)
for k := range idxbc.m { for k := range idxbc.m {
// Do not return idxb to pool, since these entries may be used // do not call putIndexBlock(ibxbc.m[k]), since it
// by concurrent goroutines. // may be used by concurrent goroutines.
delete(idxbc.m, k) delete(idxbc.m, k)
overflow-- overflow--
if overflow == 0 { if overflow == 0 {
@ -347,7 +349,7 @@ func (ibc *inmemoryBlockCache) MustClose() {
close(ibc.cleanerStopCh) close(ibc.cleanerStopCh)
ibc.cleanerWG.Wait() ibc.cleanerWG.Wait()
// It is safe returning ibc.m entries to pool, since the Reset function may be called // It is safe returning ibc.m entries to pool, since the MustClose can be called
// only if no other goroutines access ibc entries. // only if no other goroutines access ibc entries.
for _, ibe := range ibc.m { for _, ibe := range ibc.m {
putInmemoryBlock(ibe.ib) putInmemoryBlock(ibe.ib)