Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-14 16:12:15 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

app/vmselect: unconditionally deny partial responses from /api/v1/export*

Browse Source 
It is expected that `/api/v1/export*` returns full data, so there is no sense in partial responses there.
This commit is contained in:
Aliaksandr Valialkin 2021-01-27 14:38:26 +02:00
parent ff526492eb
commit 5328a102e0
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/vmselect/prometheus/prometheus.go
View File

@ -387,14 +387,11 @@ func exportHandler(at *auth.Token, w http.ResponseWriter, r *http.Request, match
resultsCh := make(chan *quicktemplate.ByteBuffer, cgroup.AvailableCPUs()) resultsCh := make(chan *quicktemplate.ByteBuffer, cgroup.AvailableCPUs())
doneCh := make(chan error) doneCh := make(chan error)
if !reduceMemUsage { if !reduceMemUsage {
denyPartialResponse := searchutils.GetDenyPartialResponse(r) denyPartialResponse := true
rss, isPartial, err := netstorage.ProcessSearchQuery(at, denyPartialResponse, sq, true, deadline) rss, _, err := netstorage.ProcessSearchQuery(at, denyPartialResponse, sq, true, deadline)
if err != nil { if err != nil {
return fmt.Errorf("cannot fetch data for %q: %w", sq, err) return fmt.Errorf("cannot fetch data for %q: %w", sq, err)
} }
if isPartial {
return fmt.Errorf("cannot export data, because some of vmstorage nodes are unhealthy")
}
go func() { go func() {
err := rss.RunParallel(func(rs *netstorage.Result, workerID uint) error { err := rss.RunParallel(func(rs *netstorage.Result, workerID uint) error {
if err := bw.Error(); err != nil { if err := bw.Error(); err != nil {