Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-05 22:32:20 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

app/vmselect/netstorage: improve error message when reading data blocks from storage

Browse Source 
Mention the block number in the error. This should simplify troubleshooting in this code.
This commit is contained in:
Aliaksandr Valialkin 2019-07-28 12:12:30 +03:00
parent b7089705b7
commit 5b8526e925
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/vmselect/netstorage/netstorage.go
View File

@ -724,6 +724,7 @@ func ProcessSearchQuery(at *auth.Token, sq *storage.SearchQuery, deadline Deadli
var errors []error var errors []error
tbf := getTmpBlocksFile() tbf := getTmpBlocksFile()
m := make(map[string][]tmpBlockAddr) m := make(map[string][]tmpBlockAddr)
blocksRead := 0
for i := 0; i < len(storageNodes); i++ { for i := 0; i < len(storageNodes); i++ {
// There is no need in timer here, since all the goroutines executing // There is no need in timer here, since all the goroutines executing
// sn.processSearchQuery must be finished until the deadline. // sn.processSearchQuery must be finished until the deadline.
@ -733,9 +734,10 @@ func ProcessSearchQuery(at *auth.Token, sq *storage.SearchQuery, deadline Deadli
continue continue
} }
for _, mb := range nr.results { for _, mb := range nr.results {
blocksRead++
addr, err := tbf.WriteBlock(mb.Block) addr, err := tbf.WriteBlock(mb.Block)
if err != nil { if err != nil {
errors = append(errors, fmt.Errorf("cannot write data to temporary blocks file: %s", err)) errors = append(errors, fmt.Errorf("cannot write data block #%d to temporary blocks file: %s", blocksRead, err))
break break
} }
metricName := mb.MetricName metricName := mb.MetricName
@ -760,7 +762,7 @@ func ProcessSearchQuery(at *auth.Token, sq *storage.SearchQuery, deadline Deadli
} }
if err := tbf.Finalize(); err != nil { if err := tbf.Finalize(); err != nil {
putTmpBlocksFile(tbf) putTmpBlocksFile(tbf)
return nil, false, fmt.Errorf("cannot finalize temporary blocks file: %s", err) return nil, false, fmt.Errorf("cannot finalize temporary blocks file with %d blocks: %s", blocksRead, err)
} }
var rss Results var rss Results