Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-11-23 20:37:12 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/storage: update nextRotationTimestamp relative to the timestamp of the indexdb rotation

Browse Source 
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1401
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4563
This commit is contained in:
Aliaksandr Valialkin 2023-07-28 19:47:02 -07:00
parent c25f053945
commit 9082a84566
No known key found for this signature in database
GPG Key ID: A72BEC6CD3D0DED1
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/storage/index_db_test.go
View File

@ -1479,7 +1479,7 @@ func TestIndexDBRepopulateAfterRotation(t *testing.T) {
prevGeneration := db.generation
// force index rotation
s.mustRotateIndexDB()
s.mustRotateIndexDB(time.Now())
// check tsidCache wasn't reset after the rotation
var cs2 fastcache.Stats

9
lib/storage/storage.go
View File

@ -692,8 +692,8 @@ func (s *Storage) retentionWatcher() {
select {
case <-s.stop:
return
case <-time.After(time.Second * time.Duration(d)):
s.mustRotateIndexDB()
case currentTime := <-time.After(time.Second * time.Duration(d)):
s.mustRotateIndexDB(currentTime)
}
}
}
@ -750,14 +750,15 @@ func (s *Storage) nextDayMetricIDsUpdater() {
}
}
func (s *Storage) mustRotateIndexDB() {
func (s *Storage) mustRotateIndexDB(currentTime time.Time) {
// Create new indexdb table, which will be used as idbNext
newTableName := nextIndexDBTableName()
idbNewPath := filepath.Join(s.path, indexdbDirname, newTableName)
idbNew := mustOpenIndexDB(idbNewPath, s, &s.isReadOnly)
// Update nextRotationTimestamp
atomic.AddInt64(&s.nextRotationTimestamp, s.retentionMsecs/1000)
nextRotationTimestamp := currentTime.UnixMilli() + s.retentionMsecs/1000
atomic.StoreInt64(&s.nextRotationTimestamp, nextRotationTimestamp)
// Set idbNext to idbNew
idbNext := s.idbNext.Load()

2
lib/storage/storage_test.go
View File

@ -1094,7 +1094,7 @@ func TestStorageRotateIndexDB(t *testing.T) {
return
default:
time.Sleep(time.Millisecond)
s.mustRotateIndexDB()
s.mustRotateIndexDB(time.Now())
}
}
}()