Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-15 16:30:55 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/encoding/zstd: disable CRC checks in pure Go build

Browse Source 
This should give slightly better compression and decompressions performance.
Additionally this shaves off 4 bytes per each compressed block.
This commit is contained in:
Aliaksandr Valialkin 2019-07-24 19:15:33 +03:00
parent 54f035d4ce
commit 97b5dc7122
2 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/encoding/zstd/zstd_pure.go
View File

@ -45,17 +45,15 @@ func CompressLevel(dst, src []byte, compressionLevel int) []byte {
func getEncoder(compressionLevel int) *zstd.Encoder { func getEncoder(compressionLevel int) *zstd.Encoder {
r := av.Load().(registry) r := av.Load().(registry)
if e, ok := r[compressionLevel]; ok { e := r[compressionLevel]
if e != nil {
return e return e
} }
level := zstd.EncoderLevelFromZstd(compressionLevel)
e, err := zstd.NewWriter(nil, zstd.WithEncoderLevel(level))
if err != nil {
logger.Panicf("BUG: failed to create ZSTD writer: %s", err)
}
mu.Lock() mu.Lock()
// Create the encoder under lock in order to prevent from wasted work
// when concurrent goroutines create encoder for the same compressionLevel.
e = newEncoder(compressionLevel)
r1 := av.Load().(registry) r1 := av.Load().(registry)
r2 := make(registry) r2 := make(registry)
for k, v := range r1 { for k, v := range r1 {
@ -67,3 +65,14 @@ func getEncoder(compressionLevel int) *zstd.Encoder {
return e return e
} }
func newEncoder(compressionLevel int) *zstd.Encoder {
level := zstd.EncoderLevelFromZstd(compressionLevel)
e, err := zstd.NewWriter(nil,
zstd.WithEncoderCRC(false), // Disable CRC for performance reasons.
zstd.WithEncoderLevel(level))
if err != nil {
logger.Panicf("BUG: failed to create ZSTD writer: %s", err)
}
return e
}

4
lib/encoding/zstd/zstd_test.go
View File

@ -68,7 +68,9 @@ func testCompressDecompress(t *testing.T, compress compressFn, decompress decomp
type compressFn func(dst, src []byte, compressionLevel int) ([]byte, error) type compressFn func(dst, src []byte, compressionLevel int) ([]byte, error)
func pureCompress(dst, src []byte, _ int) ([]byte, error) { func pureCompress(dst, src []byte, _ int) ([]byte, error) {
w, err := pure.NewWriter(nil, pure.WithEncoderLevel(pure.SpeedBestCompression)) w, err := pure.NewWriter(nil,
pure.WithEncoderCRC(false), // Disable CRC for performance reasons.
pure.WithEncoderLevel(pure.SpeedBestCompression))
if err != nil { if err != nil {
return nil, err return nil, err
} }