Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-20 23:39:48 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

app/vmselect/promql: pre-allocate memory for map for checking for duplicate timeseries

Browse Source 
This should reduce memory allocations for big number of timeseries
This commit is contained in:
Aliaksandr Valialkin 2019-08-20 22:51:45 +03:00
parent 1101765adb
commit 99331606e1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/vmselect/promql/exec.go
View File

@ -105,14 +105,14 @@ func maySortResults(e expr, tss []*timeseries) bool {
func timeseriesToResult(tss []*timeseries, maySort bool) ([]netstorage.Result, error) { func timeseriesToResult(tss []*timeseries, maySort bool) ([]netstorage.Result, error) {
tss = removeNaNs(tss) tss = removeNaNs(tss)
result := make([]netstorage.Result, len(tss)) result := make([]netstorage.Result, len(tss))
m := make(map[string]bool) m := make(map[string]struct{}, len(tss))
bb := bbPool.Get() bb := bbPool.Get()
for i, ts := range tss { for i, ts := range tss {
bb.B = marshalMetricNameSorted(bb.B[:0], &ts.MetricName) bb.B = marshalMetricNameSorted(bb.B[:0], &ts.MetricName)
if m[string(bb.B)] { if _, ok := m[string(bb.B)]; ok {
return nil, fmt.Errorf(`duplicate output timeseries: %s%s`, ts.MetricName.MetricGroup, stringMetricName(&ts.MetricName)) return nil, fmt.Errorf(`duplicate output timeseries: %s%s`, ts.MetricName.MetricGroup, stringMetricName(&ts.MetricName))
} }
m[string(bb.B)] = true m[string(bb.B)] = struct{}{}
rs := &result[i] rs := &result[i]
rs.MetricNameMarshaled = append(rs.MetricNameMarshaled[:0], bb.B...) rs.MetricNameMarshaled = append(rs.MetricNameMarshaled[:0], bb.B...)