From a06b7f7f84bdd3140e28d45443a5388c03c683a8 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 3 Jun 2019 17:09:43 +0300 Subject: [PATCH] app/vmselect/netstorage: remove spammy error message when certain vmstorage nodes are unavailable during query execution The amount of partial responses may be tracked by `vm_partial_search_results_total` metric. --- app/vmselect/netstorage/netstorage.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/vmselect/netstorage/netstorage.go b/app/vmselect/netstorage/netstorage.go index 0224212510..5d92e493b1 100644 --- a/app/vmselect/netstorage/netstorage.go +++ b/app/vmselect/netstorage/netstorage.go @@ -653,12 +653,12 @@ func ProcessSearchQuery(at *auth.Token, sq *storage.SearchQuery, deadline Deadli return nil, true, fmt.Errorf("error occured during search: %s", errors[0]) } - // Just log errors and return partial results. + // Just return partial results. // This allows gracefully degrade vmselect in the case // if certain storageNodes are temporarily unavailable. + // Do not log the error, since it may spam logs on busy vmselect + // serving high amount of requests. partialSearchResults.Inc() - // Log only the first error, since it has no sense in returning all errors. - logger.Errorf("certain storageNodes are unhealthy during search: %s", errors[0]) isPartialResult = true } if err := tbf.Finalize(); err != nil {