Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-15 08:23:34 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix rollupOpen(), rollupHigh(), rollupLow() functions (#328)

Browse Source
This commit is contained in:
Yaroslav 2020-02-23 18:01:53 +02:00 committed by Aliaksandr Valialkin
parent 7ee7614e90
commit c69d4b01f0
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
app/vmselect/promql/rollup.go
View File

@ -1435,12 +1435,9 @@ func getCandlestickValues(rfa *rollupFuncArg) []float64 {
} }
func rollupOpen(rfa *rollupFuncArg) float64 { func rollupOpen(rfa *rollupFuncArg) float64 {
if !math.IsNaN(rfa.prevValue) {
return rfa.prevValue
}
values := getCandlestickValues(rfa) values := getCandlestickValues(rfa)
if len(values) == 0 { if len(values) == 0 {
return nan return rfa.prevValue
} }
return values[0] return values[0]
} }
@ -1455,14 +1452,11 @@ func rollupClose(rfa *rollupFuncArg) float64 {
func rollupHigh(rfa *rollupFuncArg) float64 { func rollupHigh(rfa *rollupFuncArg) float64 {
values := getCandlestickValues(rfa) values := getCandlestickValues(rfa)
max := rfa.prevValue
if math.IsNaN(max) {
if len(values) == 0 { if len(values) == 0 {
return nan return rfa.prevValue
} }
max = values[0] max := values[0]
} for _, v := range values[1:] {
for _, v := range values {
if v > max { if v > max {
max = v max = v
} }
@ -1472,14 +1466,11 @@ func rollupHigh(rfa *rollupFuncArg) float64 {
func rollupLow(rfa *rollupFuncArg) float64 { func rollupLow(rfa *rollupFuncArg) float64 {
values := getCandlestickValues(rfa) values := getCandlestickValues(rfa)
min := rfa.prevValue
if math.IsNaN(min) {
if len(values) == 0 { if len(values) == 0 {
return nan return rfa.prevValue
} }
min = values[0] min := values[0]
} for _, v := range values[1:] {
for _, v := range values {
if v < min { if v < min {
min = v min = v
} }