From cb85e6aef34922823dac760716617c93bedb4c17 Mon Sep 17 00:00:00 2001 From: Viet Hung Nguyen Date: Thu, 31 Oct 2024 14:04:50 +0100 Subject: [PATCH] vmalert-tool: set default interval for unittest input_series (#7392) ### Describe Your Changes Currently it is not optional option, but if user forgot to set, it defaults to 0, which cause unexpected behavior. This change sets default = evaluation_interval similar to promtool behavior. https://prometheus.io/docs/prometheus/2.55/configuration/unit_testing_rules/#test_group ### Checklist The following checks are **mandatory**: - [x] My change adheres [VictoriaMetrics contributing guidelines](https://docs.victoriametrics.com/contributing/). Signed-off-by: Viet Hung Nguyen (cherry picked from commit 21d1385ae1be7a0f4707840b23619654e210141e) Signed-off-by: hagen1778 --- docs/vmalert-tool.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/vmalert-tool.md b/docs/vmalert-tool.md index 7f41ea931..24dc55827 100644 --- a/docs/vmalert-tool.md +++ b/docs/vmalert-tool.md @@ -40,7 +40,7 @@ which aren't always backward compatible with [PromQL](https://prometheus.io/docs >by default, rules execution is sequential within one group, but persistence of execution results to remote storage is asynchronous. Hence, user shouldn’t rely on chaining of recording rules when result of previous recording rule is reused in the next one; For example, you have recording rule A and alerting rule B in the same group, and rule B's expression is based on A's results. -Rule B won't get the latest data of A, since data didn't persist to remote storage yet. +Rule B won't get the latest data of A, since data didn't persist to remote storage yet. The workaround is to divide them in two groups and put groupA in front of groupB (or use `group_eval_order` to define the evaluation order). In this way, vmalert-tool makes sure that the results of groupA must be written to storage before evaluating groupB: @@ -54,7 +54,7 @@ groups: rules: - alert: B expr: A >= 0.75 - for: 1m + for: 1m ``` ### Test file format @@ -84,7 +84,7 @@ tests: ```yaml # Interval between samples for input series -interval: +[ interval: | default = evaluation_interval ] # Time series to persist into the database according to configured before running tests. input_series: [ - ]