From d3ae2b2f62ddb631bb7d9afc5ad380785bada187 Mon Sep 17 00:00:00 2001 From: hagen1778 Date: Tue, 14 Nov 2023 09:50:06 +0100 Subject: [PATCH] dashboards: update description for RSS and anonymous memory panels to be consistent for single-node, cluster and vmagent dashboards. Signed-off-by: hagen1778 --- dashboards/victoriametrics-cluster.json | 4 ++-- dashboards/victoriametrics.json | 4 ++-- dashboards/vm/victoriametrics-cluster.json | 6 +++--- dashboards/vm/victoriametrics.json | 6 +++--- dashboards/vm/vmagent.json | 2 +- dashboards/vmagent.json | 2 +- docs/CHANGELOG.md | 1 + 7 files changed, 13 insertions(+), 12 deletions(-) diff --git a/dashboards/victoriametrics-cluster.json b/dashboards/victoriametrics-cluster.json index a880afe51..be8bc93fc 100644 --- a/dashboards/victoriametrics-cluster.json +++ b/dashboards/victoriametrics-cluster.json @@ -1594,7 +1594,7 @@ "type": "prometheus", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { @@ -1706,7 +1706,7 @@ "type": "prometheus", "uid": "$ds" }, - "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.", + "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/dashboards/victoriametrics.json b/dashboards/victoriametrics.json index bfaa2b307..5e75a74a0 100644 --- a/dashboards/victoriametrics.json +++ b/dashboards/victoriametrics.json @@ -1485,7 +1485,7 @@ "type": "prometheus", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { @@ -1747,7 +1747,7 @@ "type": "prometheus", "uid": "$ds" }, - "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%", + "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/dashboards/vm/victoriametrics-cluster.json b/dashboards/vm/victoriametrics-cluster.json index 744a5ba4f..c6395c378 100644 --- a/dashboards/vm/victoriametrics-cluster.json +++ b/dashboards/vm/victoriametrics-cluster.json @@ -66,7 +66,7 @@ "uid": "$ds" }, "enable": true, - "expr": "sum(ALERTS{alertgroup=\"vmcluster\",alertstate=\"firing\",show_at=\"dashboard\"}) by(alertname)", + "expr": "sum(ALERTS{job=~\"$job\", instance=~\"$instance\", alertgroup=\"vmcluster\",alertstate=\"firing\",show_at=\"dashboard\"}) by(alertname)", "iconColor": "red", "name": "alerts", "titleFormat": "{{alertname}}" @@ -1595,7 +1595,7 @@ "type": "victoriametrics-datasource", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { @@ -1707,7 +1707,7 @@ "type": "victoriametrics-datasource", "uid": "$ds" }, - "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.", + "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/dashboards/vm/victoriametrics.json b/dashboards/vm/victoriametrics.json index 161308ade..991f6f77c 100644 --- a/dashboards/vm/victoriametrics.json +++ b/dashboards/vm/victoriametrics.json @@ -66,7 +66,7 @@ "uid": "$ds" }, "enable": true, - "expr": "sum(ALERTS{alertgroup=\"vmsingle\",alertstate=\"firing\",show_at=\"dashboard\"}) by(alertname)", + "expr": "sum(ALERTS{job=~\"$job\", instance=~\"$instance\", alertgroup=\"vmsingle\",alertstate=\"firing\",show_at=\"dashboard\"}) by(alertname)", "iconColor": "red", "name": "alerts", "titleFormat": "{{alertname}}" @@ -1486,7 +1486,7 @@ "type": "victoriametrics-datasource", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { @@ -1748,7 +1748,7 @@ "type": "victoriametrics-datasource", "uid": "$ds" }, - "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%", + "description": "Share for memory allocated by the process itself. When memory usage reaches 100% it will be likely OOM-killed.\nSafe memory usage % considered to be below 80%\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/dashboards/vm/vmagent.json b/dashboards/vm/vmagent.json index adfb37735..5fbabac4e 100644 --- a/dashboards/vm/vmagent.json +++ b/dashboards/vm/vmagent.json @@ -1615,7 +1615,7 @@ "type": "victoriametrics-datasource", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show Mem usage per instance", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/dashboards/vmagent.json b/dashboards/vmagent.json index 4c66b13b9..692bdfbd6 100644 --- a/dashboards/vmagent.json +++ b/dashboards/vmagent.json @@ -1614,7 +1614,7 @@ "type": "prometheus", "uid": "$ds" }, - "description": "Percentage of used memory (resident).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show Mem usage per instance", + "description": "Percentage of used RSS memory (resident).\nThe RSS memory shows the amount of memory recently accessed by the application. It includes anonymous memory and data from recently accessed files (aka page cache).\nThe application's performance will significantly degrade when memory usage is close to 100%.\n\nClick on the line and choose Drilldown to show memory usage per instance", "fieldConfig": { "defaults": { "color": { diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 1e9dc3907..a3f96236c 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -94,6 +94,7 @@ The sandbox cluster installation is running under the constant load generated by * BUGFIX: `vmselect`: improve performance and memory usage during query processing on machines with big number of CPU cores. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5087). * BUGFIX: dashboards: fix vminsert/vmstorage/vmselect metrics filtering when dashboard is used to display data from many sub-clusters with unique job names. Before, only one specific job could have been accounted for component-specific panels, instead of all available jobs for the component. * BUGFIX: dashboards: respect `job` and `instance` filters for `alerts` annotation in cluster and single-node dashboards. +* BUGFIX: dashboards: update description for RSS and anonymous memory panels to be consistent for single-node, cluster and vmagent dashboards. * BUGFIX: dashboards/vmalert: apply `desc` sorting in tooltips for vmalert dashboard in order to improve visibility of the outliers on graph. * BUGFIX: dashboards/vmalert: properly apply time series filter for panel `No data errors`. Before, the panel didn't respect `job` or `instance` filters. * BUGFIX: dashboards/vmalert: fix panel `Errors rate to Alertmanager` not showing any data due to wrong label filters.