app/vmselect/graphite: follow-up for 23ab865035

- Fix docs for new functions at app/vmselect/graphite/functions.json
- Properly drain series lists on errors in aggregateSeriesListsGeneric() and aggregateSeriesList()
- Add links to docs for the added functions at docs/CHANGELOG.md

Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5809

app/vmselect/graphite/functions.json

@@ -257,9 +257,9 @@
       }
     ]
   },
-  "DiffSeriesLists": {
-    "name": "DiffSeriesLists",
-    "function": "DiffSeriesLists(seriesListFirstPos, seriesListSecondPos)",
+  "diffSeriesLists": {
+    "name": "diffSeriesLists",
+    "function": "diffSeriesLists(seriesListFirstPos, seriesListSecondPos)",
     "description": "Iterates over a two lists and subtracts series lists 2 through n from series 1 list1[0] to list2[0], list1[1] to list2[1] and so on. The lists will need to be the same length",
     "module": "graphite.render.functions",
     "group": "Combine",
@@ -594,9 +594,9 @@
       }
     ]
   },
-  "MultiplySeriesLists": {
-    "name": "MultiplySeriesLists",
-    "function": "MultiplySeriesLists(seriesListFirstPos, seriesListSecondPos)",
+  "multiplySeriesLists": {
+    "name": "multiplySeriesLists",
+    "function": "multiplySeriesLists(seriesListFirstPos, seriesListSecondPos)",
     "description": "Iterates over a two lists and multiply series lists 2 through n from series 1 list1[0] to list2[0], list1[1] to list2[1] and so on. The lists will need to be the same length",
     "module": "graphite.render.functions",
     "group": "Combine",
@@ -799,8 +799,8 @@
       }
     ]
   },
-  "SumSeriesLists": {
-    "name": "SumSeriesLists",
+  "sumSeriesLists": {
+    "name": "sumSeriesLists",
     "function": "sumSeriesLists(seriesListFirstPos, seriesListSecondPos)",
     "description": "Iterates over a two lists and sums series lists 2 through n from series 1 list1[0] to list2[0], list1[1] to list2[1] and so on. The lists will need to be the same length",
     "module": "graphite.render.functions",
@@ -832,25 +832,7 @@
         "required": true
       },
       {
-        "name": "position",  "SumSeriesLists": {
-        "name": "SumSeriesLists",
-        "function": "sumSeriesLists(seriesListFirstPos, seriesListSecondPos)",
-        "description": "Iterates over a two lists and sums series lists 2 through n from series 1 list1[0] to list2[0], list1[1] to list2[1] and so on. The lists will need to be the same length",
-        "module": "graphite.render.functions",
-        "group": "Combine",
-        "params": [
-          {
-            "name": "seriesListFirstPos",
-            "type": "seriesList",
-            "required": true
-          },
-          {
-            "name": "seriesListSecondPos",
-            "type": "seriesList",
-            "required": true
-          }
-        ]
-      },
+        "name": "position",
         "type": "node",
         "multiple": true
       }

app/vmselect/graphite/transform.go

@@ -1332,6 +1332,7 @@ func aggregateSeriesListsGeneric(ec *evalConfig, fe *graphiteql.FuncExpr, funcNa
 	}
 	nextSeriesSecond, err := evalSeriesList(ec, args, "seriesListSecondPos", 1)
 	if err != nil {
+		_, _ = drainAllSeries(nextSeriesFirst)
 		return nil, err
 	}
 	return aggregateSeriesList(ec, fe, nextSeriesFirst, nextSeriesSecond, agg, funcName)
@@ -1370,6 +1371,7 @@ func transformDiffSeriesLists(ec *evalConfig, fe *graphiteql.FuncExpr) (nextSeri
 func aggregateSeriesList(ec *evalConfig, fe *graphiteql.FuncExpr, nextSeriesFirst, nextSeriesSecond nextSeriesFunc, agg aggrFunc, funcName string) (nextSeriesFunc, error) {
 	ssFirst, stepFirst, err := fetchNormalizedSeries(ec, nextSeriesFirst, false)
 	if err != nil {
+		_, _ = drainAllSeries(nextSeriesSecond)
 		return nil, err
 	}
 	ssSecond, stepSecond, err := fetchNormalizedSeries(ec, nextSeriesSecond, false)

docs/CHANGELOG.md

@@ -60,7 +60,7 @@ See also [LTS releases](https://docs.victoriametrics.com/lts-releases/).
 * FEATURE: [vmctl](https://docs.victoriametrics.com/vmctl.html): support client-side TLS configuration for [native protocol](https://docs.victoriametrics.com/vmctl/#migrating-data-from-victoriametrics). See [this feature request](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5748). Thanks to @khushijain21 for the [pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5824).
 * FEATURE: [vmctl](https://docs.victoriametrics.com/vmctl.html): support client-side TLS configuration for VictoriaMetrics destination specified via `--vm-*` cmd-line flags used in [InfluxDB](https://docs.victoriametrics.com/vmctl/#migrating-data-from-influxdb-1x), [Remote Read protocol](https://docs.victoriametrics.com/vmctl/#migrating-data-by-remote-read-protocol), [OpenTSDB](https://docs.victoriametrics.com/vmctl/#migrating-data-from-opentsdb), [Prometheus](https://docs.victoriametrics.com/vmctl/#migrating-data-from-prometheus) and [Promscale](https://docs.victoriametrics.com/vmctl/#migrating-data-from-promscale) migration modes.
 * FEATURE: [vmctl](https://docs.victoriametrics.com/vmctl.html): split [explore phase](https://docs.victoriametrics.com/vmctl/#migrating-data-from-victoriametrics) in `vm-native` mode by time intervals when [--vm-native-step-interval](https://docs.victoriametrics.com/vmctl/#using-time-based-chunking-of-migration) is specified. This should reduce probability of exceeding complexity limits for number of selected series during explore phase. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5369).
-* FEATURE: [graphite](https://docs.victoriametrics.com/#graphite-render-api-usage): add support for `aggregateSeriesLists`, `diffSeriesLists`, `multiplySeriesLists` and `sumSeriesLists` functions. Thanks to @rbizos for [the pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5809).
+* FEATURE: [graphite](https://docs.victoriametrics.com/#graphite-render-api-usage): add support for [aggregateSeriesLists](https://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.aggregateSeriesLists), [diffSeriesLists](https://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.diffSeriesLists), [multiplySeriesLists](https://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.multiplySeriesLists) and [sumSeriesLists](https://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.sumSeriesLists) functions. Thanks to @rbizos for [the pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5809).
 * FEATURE: [vmagent](https://docs.victoriametrics.com/vmagent.html): added command line argument that enables OpenTelementry metric names and labels sanitization.
 
 * BUGFIX: prevent from automatic deletion of newly registered time series when it is queried immediately after the addition. The probability of this bug has been increased significantly after [v1.99.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.99.0) because of optimizations related to registering new time series. See [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5948) and [this](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5959) issue.