Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-03 16:21:14 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

app/vmauth: verify the correctness of X-Forwarded-For header processing at TestRequestHandler()

Browse Source
This commit is contained in:
Aliaksandr Valialkin 2024-07-20 11:28:14 +02:00
parent cb76ff5c56
commit e87b4d3768
No known key found for this signature in database
GPG Key ID: 52C003EE2BCDB9EB
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/vmauth/main_test.go
View File

@ -42,6 +42,7 @@ func TestRequestHandler(t *testing.T) {
r, err := http.NewRequest(http.MethodGet, requestURL, nil) r, err := http.NewRequest(http.MethodGet, requestURL, nil)
r.RequestURI = r.URL.RequestURI() r.RequestURI = r.URL.RequestURI()
r.RemoteAddr = "42.2.3.84:6789" r.RemoteAddr = "42.2.3.84:6789"
r.Header.Set("X-Forwarded-For", "12.34.56.78")
if err != nil { if err != nil {
t.Fatalf("cannot initialize http request: %s", err) t.Fatalf("cannot initialize http request: %s", err)
} }
@ -66,11 +67,12 @@ unauthorized_user:
url_prefix: {BACKEND}/foo?bar=baz` url_prefix: {BACKEND}/foo?bar=baz`
requestURL := "http://some-host.com/abc/def?some_arg=some_value" requestURL := "http://some-host.com/abc/def?some_arg=some_value"
backendHandler := func(w http.ResponseWriter, r *http.Request) { backendHandler := func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "requested_url=http://%s%s", r.Host, r.URL) fmt.Fprintf(w, "requested_url=http://%s%s\nX-Forwarded-For=%s", r.Host, r.URL, r.Header.Get("X-Forwarded-For"))
} }
responseExpected := ` responseExpected := `
statusCode=200 statusCode=200
requested_url={BACKEND}/foo/abc/def?bar=baz&some_arg=some_value` requested_url={BACKEND}/foo/abc/def?bar=baz&some_arg=some_value
X-Forwarded-For=12.34.56.78, 42.2.3.84`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
// keep_original_host // keep_original_host
@ -182,7 +184,7 @@ users:
} }
responseExpected = ` responseExpected = `
statusCode=401 statusCode=401
remoteAddr: "42.2.3.84:6789"; requestURI: /a/b?c=d; cannot authorize request with auth tokens ["http_auth:Basic Zm9vOmludmFsaWQtc2VjcmV0"]` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /a/b?c=d; cannot authorize request with auth tokens ["http_auth:Basic Zm9vOmludmFsaWQtc2VjcmV0"]`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
*logInvalidAuthTokens = origLogInvalidAuthTokens *logInvalidAuthTokens = origLogInvalidAuthTokens
@ -297,7 +299,7 @@ unauthorized_user:
} }
responseExpected = ` responseExpected = `
statusCode=400 statusCode=400
remoteAddr: "42.2.3.84:6789"; requestURI: /abc?de=fg; missing route for http://some-host.com/abc?de=fg` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /abc?de=fg; missing route for http://some-host.com/abc?de=fg`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
// missing default_url and default url_prefix for unauthorized user when there are configs for authorized users // missing default_url and default url_prefix for unauthorized user when there are configs for authorized users
@ -335,7 +337,7 @@ unauthorized_user:
} }
responseExpected = ` responseExpected = `
statusCode=503 statusCode=503
remoteAddr: "42.2.3.84:6789"; requestURI: /foo/?de=fg; all the 2 backends for the user "" are unavailable` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /foo/?de=fg; all the 2 backends for the user "" are unavailable`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
// all the backend_urls are unavailable for authorized user // all the backend_urls are unavailable for authorized user
@ -353,7 +355,7 @@ users:
} }
responseExpected = ` responseExpected = `
statusCode=503 statusCode=503
remoteAddr: "42.2.3.84:6789"; requestURI: /foo/?de=fg; all the 2 backends for the user "some-user" are unavailable` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /foo/?de=fg; all the 2 backends for the user "some-user" are unavailable`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
// zero discovered backend IPs // zero discovered backend IPs
@ -375,7 +377,7 @@ unauthorized_user:
} }
responseExpected = ` responseExpected = `
statusCode=503 statusCode=503
remoteAddr: "42.2.3.84:6789"; requestURI: /def/?de=fg; all the 0 backends for the user "" are unavailable` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /def/?de=fg; all the 0 backends for the user "" are unavailable`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
netutil.Resolver = origResolver netutil.Resolver = origResolver
@ -392,7 +394,7 @@ unauthorized_user:
} }
responseExpected = ` responseExpected = `
statusCode=503 statusCode=503
remoteAddr: "42.2.3.84:6789"; requestURI: /foo/?de=fg; all the 2 backends for the user "" are unavailable` remoteAddr: "42.2.3.84:6789, X-Forwarded-For: 12.34.56.78"; requestURI: /foo/?de=fg; all the 2 backends for the user "" are unavailable`
f(cfgStr, requestURL, backendHandler, responseExpected) f(cfgStr, requestURL, backendHandler, responseExpected)
if n := retries.Load(); n != 2 { if n := retries.Load(); n != 2 {
t.Fatalf("unexpected number of retries; got %d; want 2", n) t.Fatalf("unexpected number of retries; got %d; want 2", n)