From e8fe00d39ed783d400f1d1517416d11695bdca33 Mon Sep 17 00:00:00 2001 From: Aliaksandr Valialkin Date: Mon, 14 Aug 2023 15:10:00 +0200 Subject: [PATCH] lib/promrelabel: stop emitting DEBUG log lines when parsing `if` expressions These lines were accidentally left in the commit 62651570bb6142f94025266e9e65353f3d6c37e2 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4635 --- docs/CHANGELOG.md | 2 ++ lib/promrelabel/if_expression.go | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 77cea2fd5e..0b213cc7bc 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -26,6 +26,8 @@ The following `tip` changes can be tested by building VictoriaMetrics components * FEATURE: [vmbackup](https://docs.victoriametrics.com/vmbackup.html): add support for server-side copy of existing backups. See [these docs](https://docs.victoriametrics.com/vmbackup.html#server-side-copy-of-the-existing-backup) for details. +* BUGFIX: remove `DEBUG` logging when parsing `if` filters inside [relabeling rules](https://docs.victoriametrics.com/vmagent.html#relabeling-enhancements) and when parsing `match` filters inside [stream aggregation rules](https://docs.victoriametrics.com/stream-aggregation.html). + ## [v1.93.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.93.0) Released at 2023-08-12 diff --git a/lib/promrelabel/if_expression.go b/lib/promrelabel/if_expression.go index 78519d3e8a..1f3506dfbb 100644 --- a/lib/promrelabel/if_expression.go +++ b/lib/promrelabel/if_expression.go @@ -80,7 +80,6 @@ func (ie *IfExpression) UnmarshalYAML(f func(interface{}) error) error { } func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { - logger.Infof("DEBUG: unmarshaling ifExpr from %#v", v) ies := ie.ies[:0] switch t := v.(type) { case string: @@ -89,7 +88,6 @@ func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { return fmt.Errorf("unexpected `match` option: %w", err) } ies = append(ies, ieLocal) - logger.Infof("DEBUG: unmarshaled ifExpr from %#v to %s", t, ieLocal) case []interface{}: for _, x := range t { s, ok := x.(string) @@ -102,7 +100,6 @@ func (ie *IfExpression) unmarshalFromInterface(v interface{}) error { } ies = append(ies, ieLocal) } - logger.Infof("DEBUG: unmarshaled ifExpr from %#v to %s", t, ies) default: return fmt.Errorf("unexpected `match` type; got %#v; want string or an array of strings", t) }