Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2025-01-20 15:29:24 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

lib/storage: remove outdated misleading comments

Browse Source
This commit is contained in:
Aliaksandr Valialkin 2024-05-12 10:23:53 +02:00
parent 92de6ea340
commit f20d452196
No known key found for this signature in database
GPG Key ID: 52C003EE2BCDB9EB
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/storage/partition.go
View File

@ -28,14 +28,10 @@ import (
// This time shouldn't exceed a few days. // This time shouldn't exceed a few days.
const maxBigPartSize = 1e12 const maxBigPartSize = 1e12
// The maximum number of inmemory parts per partition. // The maximum expected number of inmemory parts per partition.
// //
// This limit allows reducing querying CPU usage under high ingestion rate. // The actual number of inmemory parts may exceed this value if in-memory mergers
// See https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5212 // cannot keep up with the rate of creating new in-memory parts.
//
// This number may be reached when the insertion pace outreaches merger pace.
// If this number is reached, then the data ingestion is paused until background
// mergers reduce the number of parts below this number.
const maxInmemoryParts = 60 const maxInmemoryParts = 60
// Default number of parts to merge at once. // Default number of parts to merge at once.
@ -1275,10 +1271,6 @@ func (pt *partition) getMaxSmallPartSize() uint64 {
// Small parts are cached in the OS page cache, // Small parts are cached in the OS page cache,
// so limit their size by the remaining free RAM. // so limit their size by the remaining free RAM.
mem := memory.Remaining() mem := memory.Remaining()
// It is expected no more than defaultPartsToMerge/2 parts exist
// in the OS page cache before they are merged into bigger part.
// Half of the remaining RAM must be left for lib/mergeset parts,
// so the maxItems is calculated using the below code:
n := uint64(mem) / defaultPartsToMerge n := uint64(mem) / defaultPartsToMerge
if n < 10e6 { if n < 10e6 {
n = 10e6 n = 10e6