3 Commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	62dabd67a2	app: consistently use t.Fatal* instead of t.Error* (except of app/vmalert and app/vmctl - these packages will be processed in a separate commit) ... Consistently using t.Fatal* simplifies the test code and makes it less fragile, since it is common error to forget to make proper cleanup after t.Error* call. Also t.Error* calls do not provide any practical benefits when some tests fail. They just clutter test output with additional noise information, which do not help in fixing failing tests most of the time. While at it, improve errors generated at app/victoria-metrics tests, so they contain more useful information when debugging failed tests. This is a follow-up for a9525da8a4	2024-07-11 15:59:08 +02:00
Roman Khavronenko	6da32a27ac	vmbackup: correctly check if specified -dst belongs to specified -storageDataPath (#4841) ... See this issue https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4837 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2023-08-16 14:45:35 +02:00
Dmytro Kozlov	9a63f6c1b8	vmbackup: Prevent save backups to the same folder where TSDB data is (#2547) ... * {vmbackup, vmbackup/snapshot}: validate snapshot name * vmbackup/snapshot: added another checks * backup/actions: added check that we ignore backup_complete.ignore file * vmbackup: moved snapshot to lib directory * lib/snapshot: added functions description * lib/snapshot: fixed typo * vmbackup: code cleanup * wip * vmbackup: Prevent save backups to the same folder where TSDB data is * Apply suggestions from code review * wip * wip * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-05-06 18:04:09 +03:00