9 Commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	4df7573858	lib/protoparser/csvimport: properly parse the last empty column in CSV line ... Do not ignore the last empty column in CSV line. While at it, properly parse CSV columns in single quotes, e.g. `'foo,bar',baz` is parsed as two columns - `foo,bar` and `baz` Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4048 See also https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4298	2023-05-12 16:59:50 -07:00
Aliaksandr Valialkin	6fd39e2000	Revert "lib/protoparser: fix skip csv line when metric can be collect from the line (#4298)" ... This reverts commit 410ae99c2e. Reason for revert: the commit masks the real issue instead of fixing it. The real issue is that the scanner.NextColumn() skips the last column if it is empty. The commit also introduces two bugs: - a panic if all the metric values in CSV line are empty - silent import of CSV lines with too small number of columns Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4048 See https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4298	2023-05-12 16:59:11 -07:00
Dmytro Kozlov	714236c2d8	lib/protoparser: fix skip csv line when metric can be collect from the line (#4298) ... * lib/protoparser: fix skip csv line when metric can be collect from the line * lib/protoparser: fix comment	2023-05-12 15:53:52 -07:00
Roman Khavronenko	c22122212d	csvimport: support empty values (#3565) ... Before, if the imported line contained multiple metrics and one or more of them had an empty values - the whole line was ignored. Now, only metrics with empty values are ignored, and the rest of the metrics are accepted successfully. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3540 Signed-off-by: hagen1778 <roman@victoriametrics.com> Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-12-29 11:56:02 -08:00
Aliaksandr Valialkin	7f3e884a31	all: spelling fix: superflouos->superfluous. This is a follow-up for 0acdab3ab9	2020-11-24 12:42:04 +02:00
Aliaksandr Valialkin	cd87ca303f	lib/protoparser: report more errors for incorrect timestamps and/or values ... Previously certain errors in timestamps and/or values could be silently skipped, which could lead to samples with zero values stored in the database. Updates https://github.com/VictoriaMetrics/vmctl/issues/25	2020-09-16 02:16:15 +03:00
Aliaksandr Valialkin	d962568e93	all: use %w instead of %s for wrapping errors in fmt.Errorf ... This will simplify examining the returned errors such as httpserver.ErrorWithStatusCode . See https://blog.golang.org/go1.13-errors for details.	2020-06-30 23:33:46 +03:00
Aliaksandr Valialkin	fa7910fba1	lib/protoparser/csvimport: add missing metric vm_rows_invalid_total{type="csvimport"}	2020-03-12 15:28:10 +02:00
Aliaksandr Valialkin	2f0a36044c	app/{vmagent,vminsert}: add support for importing csv data via /api/v1/import/csv	2020-03-10 21:17:40 +02:00