Aliaksandr Valialkin
|
42dd71bb63
|
all: consistently use %w instead of %s in when error is passed to fmt.Errorf()
This allows consistently using errors.Is() for verifying whether the given error wraps some other known error.
|
2023-10-25 21:24:03 +02:00 |
|
Aliaksandr Valialkin
|
318a87c36f
|
Revert "lib/promrelabel: show error message if labels not in prometheus exposition format (#4304)"
This reverts commit 193a9c3328.
Reason for revert: the commit doesn't fix the real issue with promutils.NewLabelsFromString()
function, which must return error when improperly formatted Prometheus metric with labels is passed to it.
See https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#text-format-example
E.g. the promutils.NewLabelsFromString() must return error when the following strings are passed to it:
- `{foo:"bar"}`, since `:` is disallowed in Prometheus text exposition format. The corect value is `{foo="bar"}`
- `{"foo":"bar"}`, since label name shouldn't be quoted. The correct value is `{foo="bar"}`.
The reverted commit introduces another set of bugs, which happily accept the following invalid input:
- `{foo=~"bar"}`
- `{foo!="bar"}`
- `{foo!~"bar"}`
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4284
See also https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4304
|
2023-05-12 16:07:37 -07:00 |
|
Dmytro Kozlov
|
193a9c3328
|
lib/promrelabel: show error message if labels not in prometheus exposition format (#4304)
lib/promrelabel: show error message if labels not in prometheus exposition format
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4284
|
2023-05-12 10:42:56 +02:00 |
|
Yury Molodov
|
4f3f9950d0
|
vmui: add metric relabel debug (#3889)
* feat: add metric relabel debug (#3807)
* fix: add link to relabeling cookbook
* lib/promrelabel: merge, fix conflicts
* lib/promrelabel: fix diff
* docs/vmui: add metric relabel playground
---------
Co-authored-by: dmitryk-dk <kozlovdmitriyy@gmail.com>
|
2023-04-26 11:53:29 +03:00 |
|
Dmytro Kozlov
|
e79cd24807
|
lib/promrelabel: make target url from labels on target relabel page (#3882)
* lib/promrelabel: make target url from labels on target relabel page
* wip
---------
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
|
2023-03-20 22:07:52 -07:00 |
|
Aliaksandr Valialkin
|
1a28f0e5b3
|
lib/promrelabel: pass query args via query string at /metric-relabel-debug and /target-relabel-debug pages if their length doesnt exceed 1000
This allows copy-n-pasting the url to another browser window and seeing the same result.
The limit in 1000 chars is selected in order to prevent from potential issues with systems
which limit the url length such as Internet Explorer - see https://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string
If the limit is exceeded, then query args are sent via POST method and aren't visible in the url.
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3580
|
2023-01-05 16:48:04 -08:00 |
|
Aliaksandr Valialkin
|
0dea3b71da
|
lib/promscrape: pre-fetch metric_relabel_configs rules when debugging metric relabeling for a particular target
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3407
|
2023-01-05 03:26:49 -08:00 |
|
Aliaksandr Valialkin
|
5bca3a5be2
|
app/vmselect: remove dependency on lib/promscrape from app/vmselect
|
2023-01-03 23:28:27 -08:00 |
|