6 Commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	a50a29500f	app/vmauth: properly proxy requests to backend paths ending with / ... Previously the traling / was incorrectly removed when proxying requests from http://vmauth/ While at it, add more tests for requestHandler()	2024-07-19 17:29:17 +02:00
Aliaksandr Valialkin	4e3acfbe9a	app/vmauth: properly proxy HTTP requests without body ... The Request.Body for requests without body can be nil. This could break readTrackingBody.Read() logic, which could incorrectly return "cannot read data after closing the reader" error in this case. Fix this by initializing the readTrackingBody.r with zeroReader. While at it, properly set Host header if it is specified in 'headers' section. It must be set net/http.Request.Host instead of net/http.Request.Header.Set(), since the net/http.Client overwrites the Host header with the value from req.Host before sending the request. While at it, add tests for requestHandler(). Additional tests for various requestHandler() cases will be added in future commits. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6445 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5707 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5240 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6525	2024-07-19 16:26:07 +02:00
Aliaksandr Valialkin	31b8e9054d	app/vmauth: pool readTrackingBody structs in order to reduce pressure on Go GC ... - use pool for readTrackingBody structs in order to reduce pressure on Go GC - allow re-reading partially read request body - add missing tests for various cases of readTrackingBody usage This is a follow-up for ad6af95183 and 4d66e042e3. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6445 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6446 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6533	2024-07-17 11:34:32 +02:00
Aliaksandr Valialkin	111f7da946	Revert "app/vmauth: reader pool to reduce gc & mem alloc (#6533)" ... This reverts commit 4d66e042e3. Reasons for revert: - The commit makes unrelated invalid changes to docs/CHANGELOG.md - The changes at app/vmauth/main.go are too complex. It is better splitting them into two parts: - pooling readTrackingBody struct for reducing pressure on GC - avoiding to use readTrackingBody when -maxRequestBodySizeToRetry command-line flag is set to 0 Let's make this in the follow-up commits! Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6445 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6533	2024-07-17 11:34:31 +02:00
LHHDZ	c8431c8e4d	app/vmauth: reader pool to reduce gc & mem alloc (#6533) ... follow up https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6446 issue: https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6445 --------- Signed-off-by: f41gh7 <nik@victoriametrics.com> Co-authored-by: f41gh7 <nik@victoriametrics.com> (cherry picked from commit 4d66e042e3)	2024-07-02 14:37:15 +02:00
Aliaksandr Valialkin	3257fcfd8d	app/vmauth: retry requests at other backends on 5xx response status codes ... This should allow implementing high availability scheme described at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4792#issuecomment-1674338561 See also https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4893	2023-09-08 00:47:57 +02:00