716 Commits

Author	SHA1	Message	Date
Aliaksandr Valialkin	77cbbacfdb	lib/vmselectapi: pass storage.SearchQuery to API calls instead of []*storage.TagFilters + storage.TimeRange + maxMetrics ... This reduces the number of args to vmselectapi calls	2022-07-06 12:37:54 +03:00
Aliaksandr Valialkin	e1b8059086	lib/vmselectapi: rename deleteMetrics to more correct deleteSeries	2022-07-06 12:37:54 +03:00
Aliaksandr Valialkin	a60e03b3a7	lib/vmselectapi: use string type for tagKey and tagValuePrefix args at TagValueSuffixes() ... This improves the API consistency	2022-07-06 12:37:53 +03:00
Aliaksandr Valialkin	edc76286ac	lib/storage: put the (date, metricID) entry in dateMetricIDCache just after the corresponding series is registered in the per-day inverted index ... Previously the time series could be put into dateMetricIDCache without registering in the per-day inverted index if GetOrCreateTSIDByName finds TSID entry in the global index. This could lead to missing series in query results. The issue has been introduced in the commit 55e7afae3a, which has been included in VictoriaMetrics v1.78.0	2022-07-05 14:54:03 +03:00
Aliaksandr Valialkin	3e2dd85f7d	all: readability improvements for query traces ... - show dates in human-readable format, e.g. 2022-05-07, instead of a numeric value - limit the maximum length of queries and filters shown in trace messages	2022-06-30 18:20:33 +03:00
Aliaksandr Valialkin	a350d1e81c	lib/storage: return marshaled metric names from SearchMetricNames ... Previously SearchMetricNames was returning unmarshaled metric names. This wasn't great for vmstorage, which should spend additional CPU time for marshaling the metric names before sending them to vmselect. While at it, remove possible duplicate metric names, which could occur when multiple samples for new time series are ingested via concurrent requests. Also sort the metric names before returning them to the client. This simplifies debugging of the returned metric names across repeated requests to /api/v1/series	2022-06-28 18:17:15 +03:00
Aliaksandr Valialkin	2c836bd398	lib/storage: put into query trace the number of found entries in SearchMetricNames	2022-06-28 14:50:53 +03:00
Aliaksandr Valialkin	e578549b8a	app/vmselect: optimize /api/v1/series a bit for time ranges smaller than one day	2022-06-28 13:02:47 +03:00
Aliaksandr Valialkin	a963b2a0aa	all: show timeRange in traces in human-readable format instead of timestamps in milliseconds	2022-06-27 13:45:51 +03:00
Aliaksandr Valialkin	ba514284f1	lib/storage: add querytracer to more contexts ... querytracer has been added to the following storage.Storage methods: - RegisterMetricNames - DeleteMetrics - SearchTagValueSuffixes - SearchGraphitePaths	2022-06-27 13:45:51 +03:00
Aliaksandr Valialkin	134751e43e	all: locate throttled loggers via logger.WithThrottler() only once and then use them ... This reduces the contention on logThrottlerRegistryMu mutex when logger.WithThrottler() is called frequently from concurrent goroutines.	2022-06-27 13:45:50 +03:00
Aliaksandr Valialkin	b958fc7846	lib/storage: properly take into account already registered series when -storage.maxHourlySeries or -storage.maxDailySeries limits are enabled ... The commit 5fb45173ae takes into account only newly registered series when applying cardinality limits. This means that the cardinality limit could be exceeded with already registered series. This commit returns back accounting for already registered series when applying cardinality limits.	2022-06-20 13:47:47 +03:00
Aliaksandr Valialkin	55e7afae3a	lib/storage: create per-day indexes together with global indexes when registering new time series ... Previously the creation of per-day indexes and global indexes for the newly registered time series was decoupled. Now global indexes and per-day indexes for the current day are created toghether for new time series. This should speed up registering new time series a bit.	2022-06-19 22:42:10 +03:00
Aliaksandr Valialkin	5fb45173ae	lib/storage: do not register new series if -storage.maxHourlySeries or -storage.maxDailySeries limits are exceeded ... Previously samples for new series weren't added as expected when series limits were reached, but new series were still registered in indexdb.	2022-06-19 22:42:09 +03:00
Aliaksandr Valialkin	62e2371a67	lib/storage: reset metric id caches for the previous and the current hour ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2698	2022-06-19 22:42:09 +03:00
Aliaksandr Valialkin	ec7963208d	app/vmselect: accept focusLabel query arg at /api/v1/status/tsdb ... This allows filling the seriesCountByFocusLabelValue list in the /api/v1/status/tsdb response with label values for the specified focusLabel, which contain the highest number of time series. TODO: add this to Cardinality explorer at VMUI - https://docs.victoriametrics.com/#cardinality-explorer	2022-06-14 18:36:54 +03:00
Aliaksandr Valialkin	b6c1ca12b7	lib/storage: show top labels with the highest number of series in cardinality explorer	2022-06-14 16:32:38 +03:00
Aliaksandr Valialkin	a75e59700f	lib/storage: improve error message when -search.max* command-line flag values are exceeded	2022-06-14 13:27:59 +03:00
Aliaksandr Valialkin	52cf05c6d2	lib/storage: test GetTSDBStatusWithFiltersForDate on a global time range	2022-06-12 14:27:40 +03:00
Aliaksandr Valialkin	374beb350e	app/vmselect: optimize /api/v1/labels and /api/v1/label/.../values handlers when match[] query arg is passed to them	2022-06-12 04:32:13 +03:00
Aliaksandr Valialkin	2bcb960f17	all: improve query tracing coverage for indexdb search ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-09 20:07:07 +03:00
Aliaksandr Valialkin	12ac255dae	lib/querytracer: make it easier to use by passing trace context message to New and NewChild ... The context message can be extended by calling Donef. If there is no need to extend the message, then just call Done.	2022-06-08 21:06:52 +03:00
Dmytro Kozlov	018d2303c4	Cardinality explorer (#2625) ... * Cardinality explorer * vmui, vmselect: updated field name, added description to spinner * make vmui-update * updated const name, make vmui-update * lib/storage: changes calculation for totalSeries values * added static files * wip * wip * wip * wip * docs/CHANGELOG.md: document cardinality explorer feature See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2233 Co-authored-by: f41gh7 <nik@victoriametrics.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-06-08 18:43:05 +03:00
Roman Khavronenko	1ee1e986da	lib/storage: limit max mergeConcurrency value for systems with high number of CPUs (#2673) ... Workers count for merges affects the max part size during merges. Such behaviour protects storage from running out of disk space for scenario when all workers are merging parts with the max size. This works very well for most cases. But for systems where high number of CPUs is allocated for vmstorage components this could significantly impact the max part size and result in more unmerged parts than expected. While checking multiple production highly loaded setups it was discovered that `max_over_time(vm_active_merges{type="storage/big}[1h]}"` rarely exceeds 2, and `max_over_time(vm_active_merges{type="storage/small}[1h]}"` rarely exceeds 4. The change in this commit limits the max value for concurrency accordingly. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2022-06-07 14:55:09 +03:00
Aliaksandr Valialkin	ea06d2fd3c	lib/storage: stop background merge when storage enters read-only mode ... This should prevent from `no space left on device` errors when VictoriaMetrics under-estimates the additional disk space needed for background merge. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2603	2022-06-01 14:36:45 +03:00
Roman Khavronenko	642eb1c534	lib/storage: make indexdb/tagFilters cache size configurable (#2667) ... The default size of `indexdb/tagFilters` now can be overridden via `storage.cacheSizeIndexDBTagFilters` flag. Please, be careful with changing default size since it may lead to inefficient work of the vmstorage or OOM exceptions. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2663 Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: Nikolay <nik@victoriametrics.com>	2022-06-01 10:07:53 +02:00
Aliaksandr Valialkin	41958ed5dd	all: add initial support for query tracing ... See https://docs.victoriametrics.com/Single-server-VictoriaMetrics.html#query-tracing Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1403	2022-06-01 02:29:23 +03:00
Aliaksandr Valialkin	a1add5c2c7	lib/storage: make fmt	2022-05-31 12:54:37 +03:00
Aliaksandr Valialkin	bac75ea8a2	lib/storage: do not take into account series from the next day when match[] filter is passed to /api/v1/status/tsdb	2022-05-31 12:15:26 +03:00
Aliaksandr Valialkin	f6d11a49aa	lib/storage: add ability to change the indexdb rotation time offset with -retentionTimezoneOffset command-line flag ... This is a follow-up for 0fbf59199a See https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2574	2022-05-25 16:05:29 +03:00
阳明	0fbf59199a	lib/storage: Remove the effect of time zone on next retention period (#2568) (#2574)	2022-05-25 15:08:24 +03:00
Dmytro Kozlov	7dd9f3b98e	{vmbackup, vmbackup/snapshot}: fixed problem with snapshot backup in another snapshot folder (#2535) ... * {vmbackup, vmbackup/snapshot}: validate snapshot name * vmbackup/snapshot: added another checks * backup/actions: added check that we ignore backup_complete.ignore file * vmbackup: moved snapshot to lib directory * lib/snapshot: added functions description * lib/snapshot: fixed typo * vmbackup: code cleanup * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-05-04 22:12:03 +03:00
Aliaksandr Valialkin	0d86644d65	lib/storage: leave the last sample per each discrete interval during the deduplicaton ... This aligns better with staleness logic in Prometheus - https://prometheus.io/docs/prometheus/latest/querying/basics/#staleness	2022-05-02 21:50:45 +03:00
Artem Navoiev	37cf509c3a	lib/{storage,flagutil} - Add option for snapshot autoremoval (#2487) ... * lib/{storage,flagutil} - Add option for snapshot autoremoval - add prometheus-like duration as command flag - add option to delete stale snapshots - update duration.go flag to re-use own code * wip * lib/flagutil: re-use Duration.Set() call in NewDuration * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-05-02 11:00:15 +03:00
Aliaksandr Valialkin	54de0531a4	app/vmstorage: properly handle maxSeries limit passed from vmselect to vmstorage	2022-04-12 11:23:04 +03:00
Aliaksandr Valialkin	57143e9435	lib/storage: increase the number of rawRowsShard shards on systems with more than 4 CPU cores ... This should improve data ingestion scalability on systems with many CPU cores	2022-04-06 19:49:20 +03:00
Aliaksandr Valialkin	50cf74ce4b	lib/storage: reuse sync.WaitGroup objects ... This reduces GC load by up to 10% according to memory profiling	2022-04-06 13:34:04 +03:00
Nikolay	9a88c1a91e	lib/{storage,regexpcache}: replaces regexpCacheMap with LRU cache (#2293) ... * lib/{storage,regexpcache}: replaces regexpCacheMap with LRU cache It should decrease memory usage for regexp caching with storing cacheEntry by pointer - golang map should be able to effectivly shrink it's size original issue with this case - unexpected map grows and storage OOM Apply suggestions from code review Co-authored-by: Roman Khavronenko <roman@victoriametrics.com> Adds missing metrics for regexp cache and regexpPrefixes cache * wip * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-03-26 12:54:50 +02:00
Aliaksandr Valialkin	6e364e19ef	app/vmselect: add fine-grained limits for the number of returned/scanned time series for various APIs	2022-03-26 11:29:49 +02:00
Aliaksandr Valialkin	2ae3a9a8a3	lib/storage: reduce the interval for checking for free disk space from 30 seconds to 1 second ... This should reduce the probability of out of disk space panics when -storage.minFreeDiskSpaceBytes is set to low values. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2305	2022-03-18 16:52:27 +02:00
jduncan0000	e5868b9c29	Fix for issue #2255 - matchTagFilters for positive empty-match filters (#2304) ... * fix for issue 2255 - matchTagFilters for positive empty-match filters * add example to comments * formatting * add test for positive empty match * formatting	2022-03-18 12:58:22 +02:00
Aliaksandr Valialkin	3eef1ddc7d	lib/storage: trashing -> thrashing typo in docs ... This is a follow-up for 918ed5cb32	2022-03-16 13:05:26 +02:00
Aliaksandr Valialkin	59877d9f32	lib/{mergeset,storage}: tune compression levels for small blocks ... This should reduce CPU usage spent on compression	2022-02-25 15:33:40 +02:00
Aliaksandr Valialkin	7e99bbb967	lib/storage: document why job-like and instance-like labels must be stored at mn.Tags[0] and mn.Tags[1] ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2244	2022-02-25 13:21:07 +02:00
Aliaksandr Valialkin	8bf3fb917a	lib/storage: add a comment to indexSearch.containsTimeRange() on why it allows false positives ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2239	2022-02-24 12:47:27 +02:00
Aliaksandr Valialkin	a16f1ae565	lib/storage: properly handle series selector matching multiple metric names plus a negative filter ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2238 This is a follow-up for 00cbb099b6	2022-02-24 12:15:54 +02:00
Aliaksandr Valialkin	62b46007c5	lib/workingsetcache: reduce the default cache rotation period from hour to 20 minutes ... This should reduce memory usage under high time series churn rate	2022-02-23 13:41:45 +02:00
Aliaksandr Valialkin	f72b35665f	lib/storage: optimize /api/v1/status/tsdb call by skipping all the artificially created tag entries at once ... This is a follow-up for b71be42d90	2022-02-21 18:23:35 +02:00
Roman Khavronenko	b6ed9afd6d	lib: allow to configure cache size by type (#2206) ... * lib: allow to configure cache size by type https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1940 Signed-off-by: hagen1778 <roman@victoriametrics.com> * Apply suggestions from code review * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-02-21 13:50:34 +02:00
Aliaksandr Valialkin	2b87b4d183	lib/storage: typo fix after c3affb0c4f	2022-02-17 12:55:54 +02:00
Aliaksandr Valialkin	c3affb0c4f	lib/storage: simplify code for searching for label values ... This is a follow-up after 9dd191b27c	2022-02-17 12:29:38 +02:00
Aliaksandr Valialkin	9dd191b27c	lib/storage: properly skip composite tag entries when searching for tag names or tag values ... This is a follow-up for b71be42d90 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2200	2022-02-16 23:01:19 +02:00
Aliaksandr Valialkin	6ff71474a6	lib/storage: document why tsid cache is reset before saving it to disk ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2205	2022-02-16 18:37:56 +02:00
Aliaksandr Valialkin	b71be42d90	lib/storage: use binary search instead of full scan for skipping artificial tags when searching for tag names or tag values ... This should improve performance for /api/v1/labels and /api/v1/label/<label_name>/values See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2200	2022-02-16 18:15:41 +02:00
Aliaksandr Valialkin	96dce63dbd	lib/storage: tune the logic for pre-populating of the per-day inverted index for the next day ... - Postpone the pre-poulation to the last hour of the current day. This should reduce the number of useless entries in the next per-day index, which shouldn't be created there, when the corresponding time series are stopped to be pushed during the current day. - Make the pre-population more smooth in time by using the hash of MetricID instead of MetricID itself when calculating the need for for the given MetricID pre-population. - Sync the logic for pre-population of the next day inverted index with the logic of pre-populating tsid cache after indexdb rotation. This should improve code maintainability. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/430 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1401	2022-02-12 16:33:16 +02:00
Roman Khavronenko	cf1a8bce6b	lib/index: reduce read/write load after indexDB rotation (#2177) ... * lib/index: reduce read/write load after indexDB rotation IndexDB in VM is responsible for storing TSID - ID's used for identifying time series. The index is stored on disk and used by both ingestion and read path. IndexDB is stored separately to data parts and is global for all stored data. It can't be deleted partially as VM deletes data parts. Instead, indexDB is rotated once in `retention` interval. The rotation procedure means that `current` indexDB becomes `previous`, and new freshly created indexDB struct becomes `current`. So in any time, VM holds indexDB for current and previous retention periods. When time series is ingested or queried, VM checks if its TSID is present in `current` indexDB. If it is missing, it checks the `previous` indexDB. If TSID was found, it gets copied to the `current` indexDB. In this way `current` indexDB stores only series which were active during the retention period. To improve indexDB lookups, VM uses a cache layer called `tsidCache`. Both write and read path consult `tsidCache` and on miss the relad lookup happens. When rotation happens, VM resets the `tsidCache`. This is needed for ingestion path to trigger `current` indexDB re-population. Since index re-population requires additional resources, every index rotation event may cause some extra load on CPU and disk. While it may be unnoticeable for most of the cases, for systems with very high number of unique series each rotation may lead to performance degradation for some period of time. This PR makes an attempt to smooth out resource usage after the rotation. The changes are following: 1. `tsidCache` is no longer reset after the rotation; 2. Instead, each entry in `tsidCache` gains a notion of indexDB to which they belong; 3. On ingestion path after the rotation we check if requested TSID was found in `tsidCache`. Then we have 3 branches: 3.1 Fast path. It was found, and belongs to the `current` indexDB. Return TSID. 3.2 Slow path. It wasn't found, so we generate it from scratch, add to `current` indexDB, add it to `tsidCache`. 3.3 Smooth path. It was found but does not belong to the `current` indexDB. In this case, we add it to the `current` indexDB with some probability. The probability is based on time passed since the last rotation with some threshold. The more time has passed since rotation the higher is chance to re-populate `current` indexDB. The default re-population interval in this PR is set to `1h`, during which entries from `previous` index supposed to slowly re-populate `current` index. The new metric `vm_timeseries_repopulated_total` was added to identify how many TSIDs were moved from `previous` indexDB to the `current` indexDB. This metric supposed to grow only during the first `1h` after the last rotation. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1401 Signed-off-by: hagen1778 <roman@victoriametrics.com> * wip * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-02-12 00:30:08 +02:00
Aliaksandr Valialkin	08428464e9	lib/storage: fix broken BenchmarkHeadPostingForMatchers for {i=~".*"} after f4dead529f ... The commit f4dead529f makes such query to return nothing instead of all the time series. This aligns more with Prometheus behaviour.	2022-02-12 00:27:10 +02:00
Roman Khavronenko	e3adcbec6e	lib/promscrape: support prometheus-like duration in scrape configs (#2169) ... * lib/promscrape: support prometheus-like duration in scrape configs The change allows to specify duration values like `1d`, `1w` for fields `scrape_interval`, `scrape_timeout`, etc. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/817#issuecomment-1033384766 Signed-off-by: hagen1778 <roman@victoriametrics.com> * lib/blockcache: make linter happy Signed-off-by: hagen1778 <roman@victoriametrics.com> * lib/promscrape: support prometheus-like duration in scrape configs * add support for extra fields `scrape_align_interval` and `scrape_offset`; * support Prometheus duration parsing for `__scrape_interval__` and `__scrape_duration__` labels; Signed-off-by: hagen1778 <roman@victoriametrics.com> * wip * wip * docs/CHANGELOG.md: document the feature Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2022-02-11 16:17:00 +02:00
Aliaksandr Valialkin	4bdd10ab90	lib/bytesutil: split Resize* funcs to MayOverallocate and NoOverallocate for more fine-grained control over memory allocations ... Follow-up for f4989edd96 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2007	2022-02-01 00:18:42 +02:00
Aliaksandr Valialkin	a8509c112a	lib/storage: avoid allocations of tsidPrev on every blockStreamReader.NextBlock() call ... This is a follow-up for 00b7c97d2a Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2082	2022-01-31 22:46:53 +02:00
Aliaksandr Valialkin	96aa3761fc	lib/storage/table.go: add missing tb.ptwsLock.Unlock() before the return ... This is a follow-up for a1083d0531 See https://github.com/VictoriaMetrics/VictoriaMetrics/pull/2103	2022-01-28 14:15:42 +02:00
匠心零度	1999bbfe82	optimized code (#2103) ... * optimized code ,because only the first error,so no need var errors []error * optimized code ,because only the first error,so no need var errors []error Co-authored-by: lirenzuo <lirenzuo@shein.com>	2022-01-28 14:15:41 +02:00
Aliaksandr Valialkin	f4989edd96	lib/bytesutil: split Resize() into ResizeNoCopy() and ResizeWithCopy() functions ... Previously bytesutil.Resize() was copying the original byte slice contents to a newly allocated slice. This wasted CPU cycles and memory bandwidth in some places, where the original slice contents wasn't needed after slize resizing. Switch such places to bytesutil.ResizeNoCopy(). Rename the original bytesutil.Resize() function to bytesutil.ResizeWithCopy() for the sake of improved readability. Additionally, allocate new slice with `make()` instead of `append()`. This guarantees that the capacity of the allocated slice exactly matches the requested size. The `append()` could return a slice with bigger capacity as an optimization for further `append()` calls. This could result in excess memory usage when the returned byte slice was cached (for instance, in lib/blockcache). Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2007	2022-01-25 15:24:44 +02:00
Aliaksandr Valialkin	ede93469ea	lib/mergeset: tune caches size limits for indexdb/dataBlocks and indexdb/indexBlocks ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2007	2022-01-21 12:45:43 +02:00
Aliaksandr Valialkin	5f84b17ed6	lib/storage: properly limit cardinality when ingesting multiple samples for the same time series in a single request	2022-01-21 12:38:09 +02:00
Aliaksandr Valialkin	00b7c97d2a	lib/storage: verify that blocks in a single part are sorted by TSID when reading sequential blocks from the part ... This may help narrowing down the issue https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2082	2022-01-20 20:36:37 +02:00
Aliaksandr Valialkin	ea87f21e23	lib/storage: set bsm.Block to nil on error, so the previous block couldn't be used. ... This may help nailing down the issue https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2082	2022-01-20 20:13:14 +02:00
Aliaksandr Valialkin	145337792d	lib/{mergeset,storage}: properly limit cache sizes for indexdb ... Previously these caches could exceed limits set via `-memory.allowedPercent` and/or `-memory.allowedBytes`, since limits were set independently per each data part. If the number of data parts was big, then limits could be exceeded, which could result to out of memory errors. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/2007	2022-01-20 18:37:17 +02:00
Aliaksandr Valialkin	178dd87e26	lib/storage: follow-up for 38bf5fc136	2022-01-05 16:00:11 +02:00
weng zhao	38bf5fc136	vmstorage: fix query like {foo=~"bar|"} return extra timeseries cause by negative filter transformation malfunction (#2032) ... 1. L2749 make kb.B remain the value of comonPrefix instead of tf.prefix 2. L2762 avoid change tf.value from "bar|" to ".+r|"	2022-01-05 15:59:15 +02:00
Nikolay	8ff7da7202	adds restore.lock (#1988) ... * adds restore.lock it must prevent from running storage after incomplete restore process https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1958 * return back flock file deletion * Apply suggestions from code review * wip * docs/CHANGELOG.md: document https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1958 Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2021-12-22 13:10:15 +02:00
Aliaksandr Valialkin	ce333f28d8	all: use logger.WithThrottler() where appropriate	2021-12-21 17:03:25 +02:00
Aliaksandr Valialkin	afafeb379a	all: typo fix: unexected -> unexpected	2021-12-20 17:39:52 +02:00
Aliaksandr Valialkin	8a7f08ded3	lib/storage: properly update per-part min_dedup_interval file contents after merge ... Previously 0s was always written even if -dedup.minScrapeInterval was set to non-zero value This is a follow-up for 4ff647137a	2021-12-17 20:13:24 +02:00
Aliaksandr Valialkin	4ff647137a	lib/storage: deduplicate samples more thoroughly ... Previously some duplicate samples may be left on disk for time series with high churn rate. This may result in higher disk space usage.	2021-12-15 15:59:58 +02:00
Aliaksandr Valialkin	92070cbb67	lib/storage: return dedup interval in milliseconds from GetDedupInterval() ... This removes duplicate .Milliseconds() calls after GetDedupInterval() calls.	2021-12-15 13:26:38 +02:00
Aliaksandr Valialkin	1d20a19c7d	lib/storage: explicitly pass dedupInterval to DeduplicateSamples() and deduplicateSamplesDuringMerge() ... This improves the code readability and debuggability, since the output of these functions stops depending on global state.	2021-12-14 20:49:12 +02:00
Aliaksandr Valialkin	e1a715b0f5	lib/storage: convert alternate regexps into Graphite wildcards inside __graphite__ pseudo-label ... For example, `{__graphite__=~"foo.(bar|baz)"}` is automatically converted to `{__graphite__=~"foo.{bar,baz}"}` before execution. This allows using multi-value Grafana template variables such as `{__graphite__=~"foo.($app)"}`.	2021-12-14 19:51:49 +02:00
Aliaksandr Valialkin	45d082bbe2	app/vminsert: add -maxLabelValueLen command-line flag ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1908	2021-12-06 11:40:34 +02:00
Aliaksandr Valialkin	7275ebf91a	app/vmstorage: export vm_cache_size_max_bytes metrics for determining capacity of various caches ... The vm_cache_size_max_bytes metric can be used for determining caches which reach their capacity via the following query: vm_cache_size_bytes / vm_cache_size_max_bytes > 0.9	2021-12-02 10:30:43 +02:00
Aliaksandr Valialkin	2fb5a6ca78	lib/storage: do not take into account -storage.minFreeDiskSpaceBytes during background merges	2021-12-01 11:02:36 +02:00
Aliaksandr Valialkin	d666755159	lib/storage: take into account -storage.minFreeDiskSpaceBytes when performing big merges ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/269	2021-11-30 12:56:35 +02:00
Aliaksandr Valialkin	53bb58ed2a	lib/storage: log a warning when the -storageDataPath has less than -storage.minFreeDiskSpaceBytes ... This should improve the debuggability of the readonly feature. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1727	2021-10-19 23:59:13 +03:00
Aliaksandr Valialkin	001750c239	lib/storage: fix unaligned access on 32-bit architectures. ... The bug has been introduced at a171916ef5	2021-10-08 19:43:03 +03:00
Aliaksandr Valialkin	cf5cbd1c70	app/{vminsert,vmstorage}: follow-up after a171916ef5 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/269	2021-10-08 14:35:49 +03:00
Nikolay	4290b46e8c	Adds read-only mode for vmstorage node (#1680) ... * adds read-only mode for vmstorage https://github.com/VictoriaMetrics/VictoriaMetrics/issues/269 * changes order a bit * moves isFreeDiskLimitReached var to storage struct renames functions to be consistent change protoparser api - with optional storage limit check for given openned storage * renames freeSpaceLimit to ReadOnly	2021-10-08 14:35:48 +03:00
Aliaksandr Valialkin	718eca33ab	lib/storage: properly handle {__name__=~"prefix(suffix1|suffix2)",other_label="..."} queries ... They were broken in the commit 00cbb099b6 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1644	2021-09-23 21:48:51 +03:00
Aliaksandr Valialkin	8f685d81c6	lib/storage: follow up after 00cbb099b6	2021-09-14 14:16:25 +03:00
faceair	00cbb099b6	lib/storage: optimize convert multiple values regexp filter to composite tag filter (#1610) ... * lib/storage: optimize convert multiple values regexp filter to composite tag filter * Apply suggestions from code review Co-authored-by: Aliaksandr Valialkin <valyala@gmail.com>	2021-09-14 12:47:07 +03:00
Aliaksandr Valialkin	cebcb15ba4	lib/storage: verify that the tsidsFound contain the needed tsids in tests added at f4dead529f	2021-09-11 10:57:13 +03:00
Aliaksandr Valialkin	f4dead529f	lib/storage: properly search series by multiple tag filters matching empty labels such as foo{bar=~"baz|",x=~"y|"} ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1601 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/395	2021-09-09 21:09:21 +03:00
Aliaksandr Valialkin	f77dde837a	lib/promscrape: add the ability to limit the number of unique series per each scrape target ... The number of series per target can be limited with the following options: * Global limit with `-promscrape.maxSeriesPerTarget` command-line option. * Per-target limit with `max_series: N` option in `scrape_config` section. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1561	2021-09-01 16:03:59 +03:00
Aliaksandr Valialkin	ffc0ab1774	lib/{mergeset,storage}: improve the detection of the needed free space for background merge ... This should prevent from possible out of disk space crashes during big merges. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1560	2021-08-25 09:35:44 +03:00
Aliaksandr Valialkin	4401464c22	all: add support for Prometheus staleness markers ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1526 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/748 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1509 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1530 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/845	2021-08-13 12:10:17 +03:00
Aliaksandr Valialkin	d05cac6c98	li/storage: re-use the per-day inverted index search code for searching in global index ... This allows removing a big pile of outdated code for global index search. This may help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1486	2021-07-30 10:31:37 +03:00
Aliaksandr Valialkin	8ee8660ac4	app/vmselect: follow-up for 626073bca8 ... * Rename -search.maxMetricsPointSearch to -search.maxSamplesPerQuery, so it is more consistent with the existing -search.maxSamplesPerSeries * Move the -search.maxSamplesPerQuery from vmstorage to vmselect, so it could effectively limit the number of raw samples obtained from all the vmstorage nodes * Document the -search.maxSamplesPerQuery in docs/CHANGELOG.md	2021-07-28 18:00:23 +03:00
Aliaksandr Valialkin	c2deee9911	lib/storage: yet another attempt to properly determine disk space shortage, which prevents from optimal merges ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1373	2021-07-27 12:04:50 +03:00
Aliaksandr Valialkin	d472b03e34	lib/storage: make sure the second call to DeduplicateSamples and deduplicateSamplesDuringMerge doesnt change samples	2021-07-15 12:17:45 +03:00
Aliaksandr Valialkin	682662b2ae	lib/storage: remove cache directory if it contains reset_cache_on_startup file ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1447	2021-07-13 17:58:51 +03:00
Aliaksandr Valialkin	4f80b2f230	lib/storage: properly limit the size of storage/date_metricID cache	2021-07-12 14:25:44 +03:00
Aliaksandr Valialkin	8ca2799478	lib/storage: properly determine when the deduplication is needed in needsDedup ... Previously needsDedup() could return true if the de-duplication wasn't needed for the following case: d < interval / \ | v | v | interval interval Now it properly returns false for this case	2021-07-12 10:53:30 +03:00
Aliaksandr Valialkin	8b262d4ba7	lib/storage: periodically reset prefetchedMetricIDs cache in order to limit its size under high churn rate	2021-07-07 10:58:51 +03:00
Aliaksandr Valialkin	a7694092b8	Revert "lib/uint64set: allow reusing bucket16 structs inside uint64set.Set via uint64set.Release method" ... This reverts commit 7c6d3981bf. Reason for revert: high contention at bucket16Pool on systems with big number of CPU cores. This slows down query processing significantly.	2021-07-06 18:21:35 +03:00
Aliaksandr Valialkin	8aa9bba9bd	lib/{mergeset,storage}: switch from sync.Pool to chan-based pool for inmemoryPart objects ... This should reduce memory usage on systems with big number of CPU cores, since every inmemoryPart object occupies at least 64KB of memory and sync.Pool maintains a separate pool inmemoryPart objects per each CPU core. Though the new scheme for the pool worsens per-cpu cache locality, this should be amortized by big sizes of inmemoryPart objects.	2021-07-06 16:28:41 +03:00
Aliaksandr Valialkin	7c6d3981bf	lib/uint64set: allow reusing bucket16 structs inside uint64set.Set via uint64set.Release method ... This reduces the load on memory allocator in Go runtime in production workload.	2021-07-06 15:35:03 +03:00
Aliaksandr Valialkin	f3acf065c9	lib/storage: consistency renaming: tagCache -> tagFiltersCache ... This improves code readability	2021-07-06 11:03:51 +03:00
Aliaksandr Valialkin	0020b9f904	lib/workingsetcache: properly update stats for requests and cache misses ... Previously the stats for cache misses could be improperly counted, because it had inflated cache misses if the entry was missing in the curr cache, but was existing in the prev cache. The same applies to cache requests - they were inflated if the entry was missing in the curr cache.	2021-07-06 10:53:32 +03:00
Aliaksandr Valialkin	d0c830039d	lib/storage: tune cache sizes according to production workload	2021-07-05 15:16:11 +03:00
Aliaksandr Valialkin	43103be011	lib/{storage,mergeset}: increase cache timeout for data and index blocks from a minute to two minutes ... One minute cache timeout result in slower queries in some production workloads where the interval between query execution is in the range 1 minute - 2 minutes.	2021-07-05 15:16:11 +03:00
Aliaksandr Valialkin	9a83e9018d	lib/storage: properly detect free disk space shortage during data merge ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1373	2021-07-02 17:40:54 +03:00
Aliaksandr Valialkin	c93cee8de8	lib/{mergeset,storage}: reduce the maximum lifetime for cached indexdb and data blocks from 2 minutes to a minute ... This should reduce memory usage on a system with high number of active time series and a high churn rate. One minute is enough for caching the blocks needed for repeated queries (e.g. alerting rules, recording rules and dashboard refreshes).	2021-06-29 19:57:07 +03:00
Aliaksandr Valialkin	5506cff76e	lib/storage: put indexDBName into the key for dateTagFilter cache and for uselessTagFilters cache ... This should prevent from stats overwriting when the previous indexdb is queried.	2021-06-29 12:40:05 +03:00
Aliaksandr Valialkin	c22114c6f0	lib/storage: tune tag filters search logic ... Tune the logic according to the logs provided at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1338#issuecomment-864293624 The previous logic had a race when multiple concurrent queries execute the same tag filter without prior stats. This could result in incorrectly stored stats for such tag filter, which then could result in non-optimal sorting of tag filters for further queries. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1338	2021-06-23 13:29:39 +03:00
Aliaksandr Valialkin	dcbc22552f	lib/storage: fix infinite loop introduced in aa9b56a046	2021-06-17 14:28:10 +03:00
Aliaksandr Valialkin	aa9b56a046	lib/{mergeset,storage}: reduce the number of fsync calls on data ingestion path on systems with many cpu cores ... VictoriaMetrics maintains a buffer per CPU core for the ingested data. These buffers are flushed to disk every second. These buffers are flushed to disk in parallel starting from the commit 56b6b893ce . This resulted in increased write disk IO usage on systems with many cpu cores as described at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1338#issuecomment-863046999 . This commit merges the per-CPU buffers into bigger in-memory buffers before flushing them to disk. This should reduce the rate of fsync syscalls and, consequently, the write disk IO on systems with many CPU cores. This should help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1338 See also https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1244	2021-06-17 13:52:08 +03:00
Aliaksandr Valialkin	84fb59b0ba	lib/storage: move deletedMetricIDs set from indexDB to Storage ... This makes consitent the list of deleted metricIDs when it is used from both the current indexDB and the previous indexDB (aka extDB). This should fix the issue, which could lead to storing new samples under deleted metricIDs after indexDB rotation. See more details at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1347#issuecomment-861232136 . Thanks to @tangqipengleoo for the initial analysis and the pull request - https://github.com/VictoriaMetrics/VictoriaMetrics/pull/1383 . This commit resolves the issue in more generic way compared to https://github.com/VictoriaMetrics/VictoriaMetrics/pull/1383 . The downside of the commit is the deletedMetricIDs set isn't cleaned from the metricIDs outside the retention. It needs app restart. This should be OK in most cases.	2021-06-15 15:04:30 +03:00
Aliaksandr Valialkin	c4f3fbfa5d	lib/storage: reset cache on disk during series deletion and during indexdb rotation ... This should prevent from inconsistent behavior (aka partially missing data for some time series) after unclean shutdown. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1347	2021-06-11 12:42:28 +03:00
Aliaksandr Valialkin	69b1482bdb	lib/storage: consistency renaming: getMaxRawRowsPerPartition -> getMaxRawRowsPerShard	2021-06-11 10:57:23 +03:00
Aliaksandr Valialkin	044ab46824	lib/storage: reduce the amounts of memory which can be occupied by rawRow items during data ingestion on a system with many CPU cores	2021-06-11 10:57:23 +03:00
Aliaksandr Valialkin	96b691a0ab	lib/storage: properly account the number of loops spent when matching for or suffixes ... This may help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1338	2021-06-08 13:06:12 +03:00
Aliaksandr Valialkin	2d8bd41f8a	lib/storage: reduce memory allocations when syncing dateMetricIDCache	2021-06-03 16:20:42 +03:00
Aliaksandr Valialkin	39ef1e7a51	lib/storage: do not stop data ingestion on the first error in Storage.AddRows ... Continue data ingestion for the rest of blocks.	2021-05-24 15:32:47 +03:00
Aliaksandr Valialkin	4b01c9fb2e	lib/storage: limit the number of rows per each block in Storage.AddRows() ... This should reduce memory usage when ingesting big blocks or rows.	2021-05-24 15:24:07 +03:00
Aliaksandr Valialkin	a4ff4b8e65	lib/storage: allow filling all the rows up to their capacity in rawRowsShard.addRows ... This should reduce memory usage a bit on data ingestion path	2021-05-24 15:22:59 +03:00
Aliaksandr Valialkin	f54133b200	lib/storage: do not populate MetricID->MetricName cache during data ingestion ... This cache isn't needed during data ingestion, so there is no need in spending RAM on it. This reduces RAM usage on data ingestion path by 30%	2021-05-24 03:02:46 +03:00
Aliaksandr Valialkin	ec79abc382	lib/{mergeset,storage}: reduce the number of IFNO log messages like merged ... items across ... blocks in ... seconds ... Log these messages if the merge takes more than 30 seconds instead of 10 seconds.	2021-05-23 14:03:21 +03:00
Aliaksandr Valialkin	ad73f226ff	app/vmstorage: add ability to limit series cardinality via -storage.maxHourlySeries and -storage.maxDailySeries command-line flags	2021-05-20 14:15:19 +03:00
Aliaksandr Valialkin	009e136d88	lib/storage: remove possible data race when logging dropped labels	2021-05-20 02:47:22 +03:00
Aliaksandr Valialkin	d7be2753c0	lib/storage: substitute GetTSDBStatusForDate with GetTSDBStatusWithFiltersForDate with nil tfss	2021-05-13 09:02:33 +03:00
Aliaksandr Valialkin	a22a17dc66	lib/storage: merge getTSDBStatusForDate with getTSDBStatusWithFiltersForDate ... These functions are non-trivial, while their code has minimal differences. It is better from maintainability PoV to merge these functions into a single function.	2021-05-12 17:56:53 +03:00
Aliaksandr Valialkin	832651c6c2	app/vmselect: follow up after 8a0678678b ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1168	2021-05-12 17:18:30 +03:00
Nikolay	8a0678678b	Adds tsdb match filters (#1282) ... * init work on filters * init propose for status filters * fixes tsdb status adds test * fix bug * removes checks from test	2021-05-12 15:18:45 +03:00
Aliaksandr Valialkin	33f7bacb01	lib/storage: properly apply time range when matching an empty filter ... It must match all the time series on the given time range. Previously it was matched to all the time series without the restriction on the given time range.	2021-05-11 01:12:05 +03:00
Aliaksandr Valialkin	75c2c813fc	lib/storage: remove dead code after the commit 3ccf7ea20c	2021-05-08 20:14:11 +03:00
Aliaksandr Valialkin	12d733dd5d	app/vminsert: add support for data ingestion via other vminsert nodes	2021-05-08 19:52:57 +03:00
Aliaksandr Valialkin	76027093ca	lib/storage: use WARNING instead of INFO level for logging dropped labels	2021-05-03 13:56:43 +03:00
Nikolay	477369b62f	adds stalePartsRemover (#1261) ... for new created partitions	2021-05-03 11:34:00 +03:00
Aliaksandr Valialkin	58d1e6eeea	lib/storage: log dropped labels if the number of labels in a metric exceeds -maxLabelsPerTimeseries command-line flag value ... This should improve debuggability for this case.	2021-05-01 09:27:55 +03:00
Aliaksandr Valialkin	87179c6839	lib/{storage,mergeset}: fix unaligned 64-bit atomic operation panic for 32-bit architectures ... The panic has been introduced in 56b6b893ce	2021-04-27 16:41:32 +03:00
Aliaksandr Valialkin	56b6b893ce	lib/mergeset: split rows ingestion among multiple shards ... This improves rows ingestion on systems with many CPU cores by reducing lock contention. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1244 Thanks to @waldoweng for the original idea and draft implementation at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/1243	2021-04-27 15:36:34 +03:00
Aliaksandr Valialkin	f89c1f7f49	lib/storage: typo fix in info message when deleting the part outside the configured retention ... Previously the message was displaying incorrect retention time	2021-04-27 13:32:46 +03:00
Aliaksandr Valialkin	bbebdf9ba1	lib/{storage,mergeset}: remove empty directories on startup. Such directories can be left after unclean shutdown on NFS storage ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1142	2021-04-22 13:02:44 +03:00
Aliaksandr Valialkin	251747e253	lib/storage: code clarification: remove caching the found metricName in searchMetricName	2021-04-13 10:22:21 +03:00
Aliaksandr Valialkin	df32d2836c	lib/storage: properly handle big time ranges passed to /api/v1/labels and /api/v1/label/<labelName>/values ... It should be faster querying all the labels and/or all the values instead of querying per-day labels/values on time ranges exceeding maxDaysForPerDaySearch	2021-04-07 13:33:46 +03:00
Aliaksandr Valialkin	dc9eafcd02	app/{vminsert,vmagent}: add -sortLabels command-line option for sorting time series labels before ingesting them in the storage ... This option can be useful when samples for the same time series are ingested with distinct order of labels. For example, metric{k1="v1",k2="v2"} and metric{k2="v2",k1="v1"}.	2021-03-31 23:27:58 +03:00
Aliaksandr Valialkin	e1f699bb6c	lib/storage: reduce memory usage when ingesting samples for the same time series with distinct order of labels	2021-03-31 21:24:46 +03:00
Aliaksandr Valialkin	2601cc0fb0	lib/storage: do not update b.nextIdx if no samples are removed because of retention	2021-03-29 12:00:21 +03:00
Aliaksandr Valialkin	aa81039b42	app/vmselect: log the metric which trigger rollup result cache reset ... This should help finding the source of stale metrics	2021-03-25 21:31:39 +02:00
Aliaksandr Valialkin	6e855d4b82	lib/storage: tune loopsCountPerMetricNameMatch according to production workload	2021-03-25 13:27:47 +02:00
Aliaksandr Valialkin	3a3d2165f9	lib/storage: do not reload metricName for the same metricID in Search.NextMetricBlock ... This should speed up Search.NextMetricBlock a bit	2021-03-23 17:56:49 +02:00
Aliaksandr Valialkin	3cfb3a3683	lib/storage: respect the deadline passed to Storage.SearchMetricNames	2021-03-22 23:03:17 +02:00
Aliaksandr Valialkin	8e2afdf568	lib/storage: improve Search.NextMetricBlock performance by using MetricID->MetricName cache	2021-03-22 22:49:18 +02:00
Aliaksandr Valialkin	910092ca4d	lib/storage: tune loopsCountPerMetricNameMatch	2021-03-22 12:53:17 +02:00
Aliaksandr Valialkin	726f6ad804	lib/storage: small code simplification after 6cee5338b2	2021-03-18 15:21:13 +02:00
Aliaksandr Valialkin	6cee5338b2	lib/storage: prevent from infinite loop if {__graphite__="..."} filter matches a metric name with *, [ or { chars ... The idea has been borrowed from https://github.com/VictoriaMetrics/VictoriaMetrics/pull/1137	2021-03-18 14:53:47 +02:00
Aliaksandr Valialkin	45dabfac1b	lib/storage: faster move heavy filters to the end of list	2021-03-17 15:12:13 +02:00
Aliaksandr Valialkin	ccfb0ae2d3	lib/storage: limit loops count in order to reduce max CPU usage during filter search	2021-03-17 00:49:26 +02:00
Aliaksandr Valialkin	576a80b3d9	lib/storage: do not modify filterLoopsCount stats with loopsCount stats ... Such a modification can result in incorrect filter sorting later	2021-03-17 00:49:26 +02:00
Aliaksandr Valialkin	fd86a7dc1d	lib/storage: time series search optimization according to production workload profiling ... Do not pass filter metric ids to getMetricIDsForTagFilter, since it has been appeared that this slows down the function by multiple times when it finds big number of metricIDs (tens of millions).	2021-03-16 20:01:43 +02:00
Aliaksandr Valialkin	e36fbfae5b	lib/storage: further tuning for time series search	2021-03-16 18:46:22 +02:00
Aliaksandr Valialkin	dd7e82c34f	app/vmstorage: add -logNewSeries command-line flag for determining the source of series churn rate	2021-03-15 22:38:50 +02:00
Aliaksandr Valialkin	9c77e34ef9	lib/storage: further tuning for time series selector code	2021-03-15 20:31:34 +02:00
Aliaksandr Valialkin	3ccf7ea20c	lib/storage: tune per-day index search	2021-03-15 13:31:55 +02:00
Aliaksandr Valialkin	f669531506	lib/storage: further tune filters sorting logic	2021-03-12 00:53:04 +02:00
John Belmonte	364fdf4a56	spelling fix: adjacent (#1115)	2021-03-09 09:18:19 +02:00
Aliaksandr Valialkin	345980f78f	lib/storage: go fmt	2021-03-08 12:03:31 +02:00
Aliaksandr Valialkin	18fe0ff14b	lib/storage: tune loopsCount estimations in getMetricIDsForTagFilterSlow ... The adjusted estmations give up to 2x lower median response times on 200qps /api/v1/query_range workload	2021-03-07 21:12:35 +02:00
Aliaksandr Valialkin	4de4da1e2a	lib/storage: typo fix: umarshal -> unmarshal	2021-03-02 20:47:59 +02:00
Aliaksandr Valialkin	2c44178645	lib/storage: consistency renaming: durationsPerDateTagFilterCache -> loopsPerDateTagFilterCache	2021-02-23 15:47:19 +02:00
faceair	15d61c4879	lib/storage: correct tagfilter match cost (#1079)	2021-02-22 21:46:56 +02:00
Aliaksandr Valialkin	636c55b526	lib/mergeset: reduce memory usage for inmemoryBlock by using more compact items representation ... This also should reduce CPU time spent by GC, since inmemoryBlock.items don't have pointers now, so GC doesn't need visiting them.	2021-02-21 22:06:47 +02:00
Aliaksandr Valialkin	388cdb1980	lib/storage: do not re-calculate stats for heavy tag filters ... This should reduce the number of slow queries when stats for heavy tag filters was recalculated.	2021-02-21 21:39:01 +02:00
Aliaksandr Valialkin	48656dcc38	lib/{mergeset,storage}: allow merging smaller number of small parts ... While this may increase CPU and disk IO usage needed for background merge, this also recudes CPU usage during queries in production. This is because such queries tend to read recently added data and it is better to have lower number of parts for such data in order to reduce CPU usage. This partially reverts ebf8da3730	2021-02-21 21:28:36 +02:00
Aliaksandr Valialkin	cb311bb156	lib/{mergeset,storage}: do not use pools for indexBlock and inmemoryBlock during their caching, since this results in higher memory usage in production without any performance gains	2021-02-21 21:18:59 +02:00
Aliaksandr Valialkin	f9084611bd	lib/storage: use composite index for a query with a name filter and negative filters	2021-02-18 18:57:23 +02:00
Aliaksandr Valialkin	a537c4f602	lib/storage: properly handle queries containing a filter on metric name plus any number of negative filters and zero non-negative filters ... Example: `node_cpu_seconds_total{mode!="idle"}`	2021-02-18 18:46:36 +02:00
Aliaksandr Valialkin	e540c02014	lib/storage: prevent from running identical heavy tag filters in concurrent queries when measuring the number of loops for such tag filter. ... This should reduce CPU usage spikes when measuring the number of loops needed for heavy tag filters	2021-02-18 13:58:18 +02:00
Aliaksandr Valialkin	711f8a5b8d	lib/storage: sort tag filters by the number of loops they need for the execution ... This metric should work better than the filter execution duration, since it cannot be distorted by concurrently running queries.	2021-02-18 12:47:38 +02:00
Aliaksandr Valialkin	ce99b48a9a	Revert "lib/mergeset: tune lifetime for entries inside block caches" ... This reverts commit 458c89324d. Production testing revealed zero improvements for memory usage with reduced lifetime for entries in block caches.	2021-02-17 20:42:21 +02:00
Aliaksandr Valialkin	939d5ffc2b	lib/storage: move composite filters to the top during sorting	2021-02-17 20:26:51 +02:00
Aliaksandr Valialkin	faad6f84a4	lib/storage: return back filter arg to getMetricIDsForTagFilter function ... The filter arg has been removed in the commit c7ee2fabb8 because it was preventing from caching the number of matching time series per each tf. Now the cache contains duration for tf execution, so the filter shouldn't break such caching.	2021-02-17 19:33:22 +02:00
Aliaksandr Valialkin	d4849561ef	app/vmstorage: export vm_composite_filter_success_conversions_total and vm_composite_filter_missing_conversions_total metrics	2021-02-17 19:13:38 +02:00
Aliaksandr Valialkin	33806264ec	lib/storage: revert ecf132933e, since negative filters require the same amount of work as non-negative filters	2021-02-17 18:55:04 +02:00
Aliaksandr Valialkin	63fc140624	lib/storage: tag filters sorting...	2021-02-17 17:55:29 +02:00
Aliaksandr Valialkin	74424b55ee	lib/storage: further tune tag filters sorting	2021-02-17 17:28:15 +02:00
Aliaksandr Valialkin	442fcfec5a	lib/storage: tune the logic for sorting tag filters according the their exeuction times	2021-02-17 15:00:08 +02:00
Aliaksandr Valialkin	4a07820048	lib/storage: make sure that nobody uses partitions when closing the table	2021-02-17 14:59:04 +02:00
Aliaksandr Valialkin	d61f7b7279	lib/storage: more tuning for tag filters sorting according the time they take	2021-02-16 21:22:23 +02:00
Aliaksandr Valialkin	458c89324d	lib/mergeset: tune lifetime for entries inside block caches ... This should reduce memory usage in general case without significant CPU usage increase	2021-02-16 18:11:51 +02:00
Aliaksandr Valialkin	ca191696fe	lib/storage: tune sorting for tag filters	2021-02-16 13:04:49 +02:00
Aliaksandr Valialkin	ecf132933e	lib/storage: increase match cost for negative tag filters, since they need to scan all the label pairs	2021-02-15 16:34:23 +02:00
Aliaksandr Valialkin	4e39bf148c	vendor: update github.com/VictoriaMetrics/metrics from v1.13.1 to v1.14.0 ... The new version switches from log-linear histograms to log-based histograms, which provide up to 3.6 times better accuracy.	2021-02-15 15:12:29 +02:00
Aliaksandr Valialkin	9f5ac603a7	lib/storage: reduce the minimum supported retention for inverted index from one month to one day	2021-02-15 15:12:29 +02:00
Aliaksandr Valialkin	71c417427c	lib/storage: sort tag filters by actual execution time instead of by the number of matching time series ... This should improve query speed for queries with regexp filters matching small number of time series on a label with big number of unique values.	2021-02-15 00:18:13 +02:00
Aliaksandr Valialkin	c727d2219b	lib/storage: properly hanle regexp tag filters with dots, which can be converted to full string match filters. ... For example `{label=~"foo\.bar"}` should be converted to `{label="foo.bar"}`. Previously it has was mistakenly conveted to `{label="foo\.bar"}` . This could result in missing time series for such tag filters.	2021-02-14 23:38:14 +02:00
Aliaksandr Valialkin	0e26b7168a	lib/storage: return back in-order applying of tag filters, since concurrently executing tag filters can result in CPU and RAM waste in common case	2021-02-10 22:41:04 +02:00
Aliaksandr Valialkin	b51c23dc5b	lib/storage: parallelize tag filters execution a bit ... This should reduce execution time when a query contains multiple tag filters and each such filter matches big number of time series.	2021-02-10 18:12:25 +02:00
Aliaksandr Valialkin	c7ee2fabb8	lib/storage: remove filter arg from getMetricIDsForDateTagFilter function ... The `filter` arg breaks the logic for sorting tag filters by the matching metrics, which may result in non-optimal performance during time series search.	2021-02-10 18:12:20 +02:00
Aliaksandr Valialkin	57cac289e0	lib/storage: fix inconsistencies in error logs	2021-02-10 18:12:16 +02:00
Aliaksandr Valialkin	5d5f0b0627	lib/storage: load metadata before loading indexdb, since indexdb depends on the metadata	2021-02-10 17:55:40 +02:00
Aliaksandr Valialkin	cdecf83ce5	app/vmstorage: export vm_composite_index_min_timestamp metric	2021-02-10 17:14:08 +02:00
Aliaksandr Valialkin	553016ea99	lib/storage: disable composite index usage when querying old data	2021-02-10 14:57:50 +02:00
Aliaksandr Valialkin	fcb7655d1e	lib/storage: fix metric name match for composite filter	2021-02-10 01:27:45 +02:00
Aliaksandr Valialkin	c7dccebaef	lib/storage: optimize search by label filters matching big number of time series	2021-02-10 00:44:54 +02:00
Aliaksandr Valialkin	6b4e6c229c	lib/storage: reduce lock contention in dateMetricIDCache when registering new time series for the current day ... This should help systems with multiple CPU cores	2021-02-10 00:01:13 +02:00
Aliaksandr Valialkin	d56390b925	optimize Storage.updatePerDateData()	2021-02-09 02:55:36 +02:00
Aliaksandr Valialkin	fda61e8e96	lib/storage: skip deduplication when creating inmemory data blocks ... The deduplication will be performed later during merging such blocks.	2021-02-09 02:25:32 +02:00
Aliaksandr Valialkin	a4140de9e6	lib/mergeset: unconditionally cache indexdb blocks ... Production workloads show that indexdb blocks must be cached unconditionally for reducing CPU usage. This shouldn't increase memory usage too much, since unused blocks are removed from the cache every two minutes.	2021-02-09 00:47:50 +02:00
Aliaksandr Valialkin	cb96a1865b	app/vmstorage: export missing vm_cache_size_bytes metrics for indexdb and data caches	2021-02-09 00:47:00 +02:00
Aliaksandr Valialkin	2242647a04	lib/storage: optimize data ingestion in the beginning of every hour ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1046	2021-02-08 12:01:12 +02:00
Aliaksandr Valialkin	83d3e582ab	lib/storage: check for prevHourMetricIDs cache before falling back to checking for (date, metricID) entries during data ingestion ... This should reduce possible CPU usage spikes at the beginning of every hour. See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1046	2021-02-04 18:48:13 +02:00
Aliaksandr Valialkin	d16f22f3a1	app/vmselect,lib/storage: properly parse Graphite selectors with inner wildcards ... Example: foo{bar{x,yz},a[b-c],*de}	2021-02-03 20:14:22 +02:00
Aliaksandr Valialkin	a5a1b9bd66	lib/storage: fix a bug, which breaks searching by Graphite wildcard filters	2021-02-03 20:14:22 +02:00
Aliaksandr Valialkin	6123aa3e75	sort orSuffixes in tagFilter.InitFromGraphiteQuery for faster seeks	2021-02-03 20:14:22 +02:00
Aliaksandr Valialkin	157c02622b	app/vmselect: add ability to set Graphite-compatible filter via {__graphite__="foo.*.bar"} syntax	2021-02-03 01:21:54 +02:00
Aliaksandr Valialkin	31ec79eaf6	lib/storage: inline marshalTags function and remove the code for handling duplicate tags from here ... This is a follow-up commit after c8ea697db8	2021-01-12 15:13:30 +02:00
Aliaksandr Valialkin	c8ea697db8	lib/storage: de-duplicate tags in MetricName.sortTags ... Leave only the last tag among tags with duplicate keys. This is needed for reliable addition of extra_labels during data ingestion. See https://github.com/VictoriaMetrics/VictoriaMetrics/pull/1007 for details.	2021-01-12 15:03:42 +02:00
Aliaksandr Valialkin	9dcb18e03d	app/vmstorage: disable final merge by default, since it may result in high disk IO and CPU usage without measurable benefits such as increased query performance and reduced disk space usage	2021-01-08 00:16:05 +02:00
Aliaksandr Valialkin	490c69c64e	lib/storage: wait for pending transactions before closing and dropping the partition ... This deflakes `make test-full-386` test	2020-12-25 11:45:53 +02:00
Aliaksandr Valialkin	cab7e936a3	lib/storage: physically remove stale parts ... Previously they were removed from partition struct, but the corresponding directories weren't removed. This is a follow-up for 46dba00756	2020-12-24 16:51:36 +02:00
Aliaksandr Valialkin	9e4ed5e591	lib/storage: do not remove parts outside the configured retention if they are currently merged ... These parts are automatically removed after the merge is complete.	2020-12-24 08:51:28 +02:00
Aliaksandr Valialkin	46dba00756	lib/storage: remove stale parts as soon as they go outside the configured retention ... Previously such parts could remain undeleted for long durations until they are merged with other parts. This should help for `-retentionPeriod` values smaller than one month.	2020-12-22 19:54:31 +02:00
Aliaksandr Valialkin	d65c03c004	lib/storage: properly determine max rows for output part when merging small parts	2020-12-18 23:14:38 +02:00
Aliaksandr Valialkin	ebf8da3730	lib/{storage,mergeset}: tune background merge process in order to reduce CPU usage and disk IO usage	2020-12-18 20:01:08 +02:00
Aliaksandr Valialkin	4146fc4668	all: properly handle CPU limits set on the host system/container ... This can reduce memory usage on systems with enabled CPU limits. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/946	2020-12-08 21:07:29 +02:00
Aliaksandr Valialkin	357f886f97	Revert "lib/storage: add missing (AccountID, ProjectID) in MetricName.String() test" ... This reverts commit f3e80eb70e493620e42a0cc22a62c9af75076c77, since it isn't needed for single-node version of VictoriaMetrics	2020-11-29 01:27:25 +02:00
Aliaksandr Valialkin	ace969d595	lib/storage: add missing (AccountID, ProjectID) in MetricName.String() test	2020-11-29 01:26:04 +02:00
Aliaksandr Valialkin	8a057e705a	lib/storage: log metric name plus all its labels when the metric timestamp is outside the configured retention ... This should simplify debugging when the source of the metric with unexpected timestamp must be found.	2020-11-25 14:41:37 +02:00
Aliaksandr Valialkin	b65236530c	lib/storage: typo fix in error message: allowd->allowed	2020-11-25 14:15:42 +02:00
Aliaksandr Valialkin	78d2715d04	all: spelling fix: superflouos->superfluous. This is a follow-up for 0acdab3ab9	2020-11-24 12:42:22 +02:00
Aliaksandr Valialkin	f765985947	lib/fs: replace fs.OpenReaderAt with fs.MustOpenReaderAt ... All the callers for fs.OpenReaderAt expect that the file will be opened. So it is better to log fatal error inside fs.MustOpenReaderAt instead of leaving this to the caller.	2020-11-23 09:57:21 +02:00
Aliaksandr Valialkin	266788be14	app/vmselect: use storage.NewSearchQuery() instead of constructing storage.SearchQuery in-place ... This should prevent from bugs when AccountID and ProjectID aren't set in storage.SearchQuery.	2020-11-16 18:24:00 +02:00
Aliaksandr Valialkin	0208d8c103	lib/storage: add a test for Storage.SearchMetricNames	2020-11-16 13:15:16 +02:00
Aliaksandr Valialkin	465923b181	app/vmselect/graphite: add /tags/findSeries handler from Graphite Tags API ... See https://graphite.readthedocs.io/en/stable/tags.html#exploring-tags	2020-11-16 12:53:13 +02:00
Aliaksandr Valialkin	48d033a198	app/vminsert: add /tags/tagSeries and /tags/tagMultiSeries handlers from Graphite Tags API ... See https://graphite.readthedocs.io/en/stable/tags.html#adding-series-to-the-tagdb	2020-11-16 02:39:58 +02:00
Aliaksandr Valialkin	4aaee33860	lib/storage: do not show artifically created label for reverse Graphite labels at /api/v1/labels page	2020-11-16 00:44:35 +02:00
immerrr again	51c529a2b6	app/vmstorage: add "/internal/force_flush" endpoint (#893)	2020-11-11 14:40:27 +02:00
Aliaksandr Valialkin	368b69b4c4	app/vmselect: properly handle errors in GetLabelsOnTimeRange and GetLabelValuesOnTimeRange	2020-11-05 01:38:38 +02:00
Aliaksandr Valialkin	1cb78ba1a0	lib/storage: remove data race when updating rowsDeleted	2020-11-05 01:12:21 +02:00
Aliaksandr Valialkin	b378cd6ed8	app/vmselect: optimize querying for /api/v1/labels and /api/v1/label/<name>/values when start and end args are set	2020-11-05 01:01:33 +02:00
Aliaksandr Valialkin	caeb74f068	app/vmselect: reduce memory usage when query touches big number of time series	2020-11-04 17:04:04 +02:00
Aliaksandr Valialkin	ae91a6883c	lib/{storage,mergeset}: clean cached index blocks and inmemory blocks more aggressively ... Previously such blocks were cleaned after they weren't accessed during 10 minutes. Now they are cleaned after one minute of missing access. This should reduce memory usage in general case.	2020-11-04 17:04:04 +02:00
Aliaksandr Valialkin	f3f62ab04e	lib/storage: do not report about the need of free disk space if parts cannot be merged due to too big write amplification	2020-11-03 15:32:02 +02:00
Aliaksandr Valialkin	c87fb9191e	lib/storage: remove unneeded fmt.Sprintf	2020-11-03 14:20:31 +02:00
Aliaksandr Valialkin	fe289331dd	lib/storage: remove obsolete code	2020-11-02 19:11:59 +02:00
Aliaksandr Valialkin	29e4e7f422	lib/storage: drop more samples outside the given retention during background merge ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/17	2020-11-01 23:35:06 +02:00
Aliaksandr Valialkin	d12c4914f0	lib/storage: properly handle the case when key="__name__" is passed to MetricName.AddTag*	2020-11-01 23:35:06 +02:00
Aliaksandr Valialkin	64e2d66014	lib/storage: code cleanup after 5bfd4e6218	2020-11-01 23:35:06 +02:00
Aliaksandr Valialkin	5bfd4e6218	app/vmstorage: support for -retentionPeriod smaller than one month ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/173 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/17	2020-10-20 14:31:44 +03:00
Aliaksandr Valialkin	01987f8c77	lib/storage: small code adjustements after d2960a20e0 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/781	2020-10-17 01:16:54 +03:00