Aliaksandr Valialkin
3d22f98344
vendor: update github.com/VictoriaMetrics/fastcache from v1.12.1 to v1.12.2
...
This should help reducing GC overhead growth at https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5379
2023-11-24 13:39:32 +02:00
Aliaksandr Valialkin
3674232128
docs: make more visible that the maximum JSON line length, which is accepted by /api/v1/import, is limited by -import.maxLineLen command-line flag value
...
This is a follow-up for 0cf55ded34https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5364
2023-11-24 13:14:40 +02:00
Roman Khavronenko
26242f526e
lib/protoparser: decrease import.maxLineLen from 100MB to 10MB ( #5364 )
...
Tests showed that importing a single line with 70MB size takes 5.3GiB
RSS memory for VictoriaMetrics single-node.
In the scenario when user exports and imports data from one VM to another,
it could possibly lead to OOM exception for destination VM.
Importing a single line with 16MB size taks 1.3GiB RSS memory.
Hence, the limit for `import.maxLineLen` was decreased from 100MB to 10MB
to improve reliability of VictoriaMetrics during imports.
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
2023-11-24 13:13:33 +02:00
Aliaksandr Valialkin
01bc62eff9
docs/CHANGELOG.md: document Google PubSub support at vmagent (see 752f89f13f )
2023-11-23 21:14:04 +02:00
Nikolay
892889823a
apply review comments ( #5358 )
2023-11-23 21:13:57 +02:00
Github Actions
3a96830ed6
Automatic update operator docs from VictoriaMetrics/operator@fec3f9d ( #5381 )
2023-11-23 21:06:27 +02:00
Aliaksandr Valialkin
a906a7d85c
app/vmagent/remotewrite: do not drop persistent queues when -remoteWrite.multitenantURL is set
...
It is unsafe to drop persistent queues when -remoteWrite.multitenantURL command-line flag is set,
since these queues are created on demand when a new sample for the given tenant is pushed
to the remote storage.
This addresses https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5357
The issue has been appeared in the commit f3a51e8b1dhttps://github.com/VictoriaMetrics/VictoriaMetrics/issues/4014
2023-11-23 20:43:21 +02:00
Github Actions
28df725a37
Automatic update operator docs from VictoriaMetrics/operator@45bfa36 ( #5373 )
2023-11-22 20:25:46 +02:00
Aliaksandr Valialkin
10b4dfbbf9
app/vmalert/notifier: remove backticks from the description for -notifier.blackhole command-line flag
...
Backticks in flag description are automatically converted to flag type. See https://pkg.go.dev/flag#PrintDefaults
This is a follow-up for 20025d4fd625317b4e70
2023-11-22 20:17:45 +02:00
Aliaksandr Valialkin
db6dadf1f7
docs: convert png images to webp in all the docs except of docs/operator/*
...
This reduces the size of docs/* folder from 33MB to 18MB
Images inside docs/operator/* must be converted at the https://github.com/VictoriaMetrics/operator/tree/master/docs
and then the updated images must be automatically propagated to the docs/operator/*
This is a follow-up for d3f919df3ehttps://github.com/VictoriaMetrics/VictoriaMetrics/pull/5206
2023-11-22 19:29:47 +02:00
Github Actions
bf934482c5
Automatic update operator docs from VictoriaMetrics/operator@b96131b ( #5371 )
2023-11-22 19:23:15 +02:00
Aliaksandr Valialkin
0ccc1aca0a
deployment/docker: remove built binaries at bin folder after creating docker image from them at make publish-via-docker
2023-11-21 14:33:50 +02:00
Aliaksandr Valialkin
fc40ebba7a
.github/workflows/codeql-analysis.yml: cache Go artifacts
2023-11-21 13:05:15 +02:00
Aliaksandr Valialkin
2ebd5cbb53
.github/workflows/main.yml: ignore changes inside dashboards and deployment/**.yml
...
The dashaboards/ and deployment/**.yml do not contain files, which may change main workflow results,
so it is better to ignore them.
2023-11-21 12:58:43 +02:00
hagen1778
ae6152be5f
lib/storage: fix typo
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2023-11-21 12:22:49 +02:00
Aliaksandr Valialkin
d8aceda5fd
.github/workflows: run build and test jobs in parallel in order to speed up the workflow run
2023-11-21 12:20:31 +02:00
hagen1778
91e365acb6
lib/storage: fix typo
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2023-11-21 12:10:34 +02:00
Aliaksandr Valialkin
4f876ada0e
.github/workflows: add Go version to Go artifacts cache key
...
When Go version changes, artifacts for the previous Go version may becomes useless,
so there is a little sense in re-using them.
2023-11-21 12:02:33 +02:00
Aliaksandr Valialkin
9acd591c8e
.github/workflows: take into account Makefile contents when generating cache key for Go build aftifacts
...
The cache key must change when the corresponding 'make ...' command changes inside Makefile.
2023-11-21 11:51:56 +02:00
Aliaksandr Valialkin
b71388c1a8
.github/workflows: use stable Go release - it should always point to the latest stable release
...
This eliminates the need to update .github/workflows/* files whenever new Go stable release is out,
like in the 2db1a664e1https://github.com/actions/setup-go#using-stableoldstable-aliases
2023-11-21 11:39:04 +02:00
Aliaksandr Valialkin
3cb33196e6
.github/workflows/main.yml: try improving caching for Go artifacts
...
The default caching for Go artifacts from actions/setup-go@v4 uses the hash of go.sum file
as a cache key - see https://github.com/actions/cache/blob/main/examples.md#go---modules .
This isn't enough for VictoriaMetrics case, since different makefile actions build different the Go artifacts,
which need to be cached. So embed the action name in the cache key.
2023-11-21 01:12:17 +02:00
Aliaksandr Valialkin
95b076ba99
.github/workflows/codeql-analysis.yml: remove check-latest and cache inputs for actions/setup-go
...
- The `cache: true` is no longer needed starting from actions/setup-go@v4 - see https://github.com/actions/setup-go#v4
- The `check-latest: true` may slow down the action, so it is better to disalbe it - see https://github.com/actions/setup-go#check-latest-version
2023-11-21 01:12:00 +02:00
Aliaksandr Valialkin
c285fca256
Makefile: allow specifying the needed concurrency for make via MAKE_CONCURRENCY env var
2023-11-21 01:11:36 +02:00
Aliaksandr Valialkin
6b75523468
Makefile: speedup release, publish and crossbuild rules by using parallel make
2023-11-20 23:07:11 +02:00
Aliaksandr Valialkin
46e58f3669
app/vmagent/README.md: sync with docs/vmagent.md after cbe4a5c251 , so make docs-sync properly works
2023-11-20 22:43:28 +02:00
Nikolay
c06044ef52
app/vmagent: adds google pubsub as remoteWrite dst and ingest consumer ( #713 )
...
it allows to push and receive metrics from google pubsub queue
Adds needed documentation and examples for it
2023-11-20 22:43:26 +02:00
hagen1778
34b7783461
docs: calrify version when vminsertConnsShutdownDuration was added
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2023-11-20 17:14:57 +01:00
hagen1778
0dbbffbdd5
docs: typo after 3f5a41e35e
...
Signed-off-by: hagen1778 <roman@victoriametrics.com>
(cherry picked from commit 20025d4fd6
2023-11-20 17:06:21 +01:00
hagen1778
6575d646c0
docs: follow-up after d3f919df3e
...
d3f919df3e3ffa8975d4
2023-11-20 11:54:28 +01:00
Dmytro Kozlov
2362af3b0c
docs/managed-victoriametrics: use webp format to reduce image size ( #5206 )
...
(cherry picked from commit d3f919df3e
2023-11-20 11:53:06 +01:00
Khanh Quoc Le
03e5ebaea9
Add _stream fields log ( #5068 )
2023-11-17 16:04:13 +01:00
Hui Wang
91379331eb
lib/protoparser/promremotewrite: fall back to zstd decoding if Snappy-decoding fails ( #5344 )
...
This case is possible after the following steps:
1. vmagent successfully performed handshake with the -remoteWrite.url and the remote storage supports zstd-compressed data.
2. remote storage became unavailable or slow to ingest data, vmagent compressed the collected data into blocks with zstd and puts these blocks to persistent queue on disk.
3. vmagent restarts and the remote storage is unavailable during the handshake, then vmagent falls back to Snappy compression.
4. vmagent starts sending zstd-compressed data from persistent queue to the remote storage, while falsely advertizing it sends Snappy-compressed data.
5. The remote storage receives zstd-compressed data and fails unpacking it with Snappy.
The solution is the same as 12cd32fd75
2023-11-17 15:53:18 +01:00
Aliaksandr Valialkin
39c56e8f65
docs/enterprise.md: update VictoriaMetrics version in examples from v1.95.0 to v1.95.1
...
See https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.95.1
2023-11-17 15:47:24 +01:00
Github Actions
2e6c404cdd
Automatic update operator docs from VictoriaMetrics/operator@388745c ( #5340 )
2023-11-17 15:47:22 +01:00
Aliaksandr Valialkin
1149a98873
deployment: update VictoriaMetrics docker image tag from v1.95.0 to v1.95.1
...
See https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.95.1
2023-11-17 15:43:43 +01:00
Aliaksandr Valialkin
5492ccf0d5
app/vmselect/promql: reduce the number of memory allocations inside copyTimeseriesShallow()
...
Previously the number of memory allocations inside copyTimeseriesShallow() was equal to 1+len(tss)
Reduce this number to 2 by pre-allocating a slice of timeseries structs with len(tss) length.
2023-11-17 15:41:38 +01:00
luckyxiaoqiang
3419c14b35
docs/metricsql: remove duplicate sentence ( #5349 )
2023-11-17 15:41:21 +01:00
Artem Navoiev
acfaf5c352
gh action bump pagefind version to 1.0.4
...
Signed-off-by: Artem Navoiev <tenmozes@gmail.com>
2023-11-17 15:40:54 +01:00
Aliaksandr Valialkin
1a15b0f57b
docs/CHANGELOG.md: cut v1.95.1
2023-11-16 20:32:27 +01:00
Aliaksandr Valialkin
8723c8546a
vendor: run make vendor-update
2023-11-16 20:21:16 +01:00
Aliaksandr Valialkin
5c43f2261e
dashboards: remove path!="/favicon.ico" filter from requests rate graphs
...
The `path!="/favicon.ico"` filter has little sense, since there are many other special paths,
which may be filtered out - /metrics, /flags, /health, /ping, /robots.txt, /-/healthy, /-/ready, /reload, etc.
See /lib/httpserver/httpserver.go for more details.
It will be hard or impossible to maintain filters for all these paths, so it is better to drop this filter
in order to simplify queries and improve the consistency of these queries.
2023-11-16 19:29:46 +01:00
Aliaksandr Valialkin
994b3da361
app/vmselect: simplify code a bit after 63e0f16062
...
Use only a single call to prometheus.WriteErrorResponse() inside sendPrometheusError
2023-11-16 18:15:08 +01:00
Aliaksandr Valialkin
5ad1c2b46a
docs/FAQ.md: add a link to https://docs.victoriametrics.com/#monitoring in questions where this is needed
2023-11-16 17:45:38 +01:00
Aliaksandr Valialkin
633ec37022
app/vmselect/promql: typo fix after 7ca8ebef20
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5332
2023-11-16 17:01:19 +01:00
Aliaksandr Valialkin
a0f02d06d7
lib/handshake: typo fix after ef80a89a24: SetReadDeadline -> SetWriteDeadline
...
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5327
2023-11-16 16:47:07 +01:00
Aliaksandr Valialkin
ef80a89a24
lib/handshake: add SetReadDeadline and SetWriteDeadline implementations additionally to SetDeadline
...
This is a follow-up for 27a5461785https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5327
2023-11-16 16:43:36 +01:00
Roman Khavronenko
27a5461785
lib/handshake: check for deadline in Read and Write methods ( #5327 )
...
The buffered connection could have exceeded the underlying connection
deadline during reading or writing to an internal buffer.
With this change, buffered connection struct additionally checks
for a deadline in Read/Write methods.
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2023-11-16 16:33:40 +01:00
Github Actions
f430d506f2
Automatic update operator docs from VictoriaMetrics/operator@bc8b02f ( #5331 )
2023-11-16 16:29:56 +01:00
Roman Khavronenko
c0039ce7a3
docs/vmalert: clarify deduplication recommendations for HA setup ( #5336 )
...
Please see discussion here https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5279
Signed-off-by: hagen1778 <roman@victoriametrics.com>
2023-11-16 16:27:47 +01:00
Aliaksandr Valialkin
147fe45828
docs/CHANGELOG.md: remove duplicate word query after 2cbdb1db22
2023-11-16 16:24:15 +01:00
