mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-23 12:31:07 +01:00
a468a6e985
- Rename GetStatDialFunc to NewStatDialFunc, since it returns new function with every call
- NewStatDialFunc isn't related to http in any way, so it must be moved from lib/httputils to lib/netutil
- Simplify the implementation of NewStatDialFunc by removing sync.Map from there.
- Use netutil.NewStatDialFunc at app/vmauth and lib/promscrape/discoveryutils
- Use gauge instead of counter type for *_conns metric
This is a follow-up for d7b5062917
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6299
53 lines
873 B
Go
53 lines
873 B
Go
package netutil
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestIsTCPv4Addr(t *testing.T) {
|
|
f := func(addr string, resultExpected bool) {
|
|
t.Helper()
|
|
|
|
result := isTCPv4Addr(addr)
|
|
if result != resultExpected {
|
|
t.Fatalf("unexpected result for isIPv4Addr(%q); got %v; want %v", addr, result, resultExpected)
|
|
}
|
|
}
|
|
|
|
// empty addr
|
|
f("", false)
|
|
|
|
// too small number of octets
|
|
f("foobar", false)
|
|
f("1", false)
|
|
f("1.2", false)
|
|
f("1.2.3", false)
|
|
f("1.2.3.", false)
|
|
|
|
// non-numeric octets
|
|
f("foo.bar.baz.aaa", false)
|
|
|
|
// non-numeric last value
|
|
f("1.2.3.foo", false)
|
|
|
|
// negative value
|
|
f("1.2.3.-4", false)
|
|
|
|
// missing port
|
|
f("1.2.3.4", false)
|
|
|
|
// invalid port
|
|
f("1.2.3.4:foo", false)
|
|
|
|
// too big octet
|
|
f("1.2.3.444:5", false)
|
|
|
|
// too big port
|
|
f("1.2.3.4:152344", false)
|
|
|
|
// normal TCPv4 addr
|
|
f("1.2.3.4:5", true)
|
|
f("0.0.0.0:80", true)
|
|
f("1.2.3.4:65535", true)
|
|
}
|