mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-05 01:01:09 +01:00
e97e966f82
In the previous commit 8958cecad6
the default ports (80/443) were removed for both the `scrapeURL` and
`instance` label values for those targets without a port in
`__address__`. Different values in the `instance` label generate new
time series.
This commit reverts the changes made to the `instance` label. Now,
for those targets:
- `scrapeURL` will remain unchanged.
- The `instance` label value will include the default port.
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6792
121 lines
3.5 KiB
Go
121 lines
3.5 KiB
Go
package promrelabel
|
|
|
|
import (
|
|
"net/url"
|
|
"strings"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/promutils"
|
|
)
|
|
|
|
// GetScrapeURL makes scrape url and __address_ labels for the given labels and extraParams.
|
|
func GetScrapeURL(labels *promutils.Labels, extraParams map[string][]string) (string, string) {
|
|
// See https://www.robustperception.io/life-of-a-label
|
|
scheme := labels.Get("__scheme__")
|
|
if len(scheme) == 0 {
|
|
scheme = "http"
|
|
}
|
|
metricsPath := labels.Get("__metrics_path__")
|
|
if len(metricsPath) == 0 {
|
|
metricsPath = "/metrics"
|
|
}
|
|
address := labels.Get("__address__")
|
|
if len(address) == 0 {
|
|
return "", ""
|
|
}
|
|
// Usability extension to Prometheus behavior: extract optional scheme and metricsPath from __address__.
|
|
// Prometheus silently drops targets with __address__ containing scheme or metricsPath
|
|
// according to https://www.robustperception.io/life-of-a-label/ .
|
|
if strings.HasPrefix(address, "http://") {
|
|
scheme = "http"
|
|
address = address[len("http://"):]
|
|
} else if strings.HasPrefix(address, "https://") {
|
|
scheme = "https"
|
|
address = address[len("https://"):]
|
|
}
|
|
if n := strings.IndexByte(address, '/'); n >= 0 {
|
|
metricsPath = address[n:]
|
|
address = address[:n]
|
|
}
|
|
|
|
// If port is missing, typically it should be 80/443. This WAS written in a label and used as scrapeURL.
|
|
// However, adding the port by default can cause some issues, see: https://github.com/prometheus/prometheus/pull/9523#issuecomment-2059314966
|
|
// After https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6792:
|
|
// - don't add the default port to scrapeURL.
|
|
// - continue adding the default port to the label value for backward compatibility and avoid generating new time series.
|
|
addressMustWithPort := addMissingPort(address, scheme == "https")
|
|
|
|
if !strings.HasPrefix(metricsPath, "/") {
|
|
metricsPath = "/" + metricsPath
|
|
}
|
|
params := getParamsFromLabels(labels, extraParams)
|
|
optionalQuestion := ""
|
|
if len(params) > 0 {
|
|
optionalQuestion = "?"
|
|
if strings.Contains(metricsPath, "?") {
|
|
optionalQuestion = "&"
|
|
}
|
|
}
|
|
paramsStr := url.Values(params).Encode()
|
|
scrapeURL := buildScrapeURL(scheme, address, metricsPath, optionalQuestion, paramsStr)
|
|
return scrapeURL, addressMustWithPort
|
|
}
|
|
|
|
func getParamsFromLabels(labels *promutils.Labels, extraParams map[string][]string) map[string][]string {
|
|
// See https://www.robustperception.io/life-of-a-label
|
|
var m map[string][]string
|
|
for _, label := range labels.GetLabels() {
|
|
if !strings.HasPrefix(label.Name, "__param_") {
|
|
continue
|
|
}
|
|
name := label.Name[len("__param_"):]
|
|
values := []string{label.Value}
|
|
if p := extraParams[name]; len(p) > 1 {
|
|
values = append(values, p[1:]...)
|
|
}
|
|
if m == nil {
|
|
m = make(map[string][]string)
|
|
}
|
|
m[name] = values
|
|
}
|
|
return m
|
|
}
|
|
|
|
func buildScrapeURL(scheme, address, metricsPath, optionalQuestion, paramsStr string) string {
|
|
bb := bbPool.Get()
|
|
b := bb.B[:0]
|
|
b = append(b, scheme...)
|
|
b = append(b, "://"...)
|
|
b = append(b, address...)
|
|
b = append(b, metricsPath...)
|
|
b = append(b, optionalQuestion...)
|
|
b = append(b, paramsStr...)
|
|
s := bytesutil.InternBytes(b)
|
|
bb.B = b
|
|
bbPool.Put(bb)
|
|
return s
|
|
}
|
|
|
|
func addMissingPort(addr string, isTLS bool) string {
|
|
if strings.Contains(addr, ":") {
|
|
return addr
|
|
}
|
|
if isTLS {
|
|
return concatTwoStrings(addr, ":443")
|
|
}
|
|
return concatTwoStrings(addr, ":80")
|
|
}
|
|
|
|
func concatTwoStrings(x, y string) string {
|
|
bb := bbPool.Get()
|
|
b := bb.B[:0]
|
|
b = append(b, x...)
|
|
b = append(b, y...)
|
|
s := bytesutil.InternBytes(b)
|
|
bb.B = b
|
|
bbPool.Put(bb)
|
|
return s
|
|
}
|
|
|
|
var bbPool bytesutil.ByteBufferPool
|