mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-23 12:31:07 +01:00
e614367cbf
### Describe Your Changes
Related issue: #7199
This is the initial version of the integration tests for cluster. See
`README.md` for details.
Currently cluster only, but it can also be used for vm-single if needed.
The code has been added to the apptest package that resides in the root
directory of the VM codebase. This is done to exclude the integration
tests from regular testing build targets because:
- Most of the test variants do not apply to integration testing (such as
pure or race).
- The integtation tests may also be slow because each test must wait for
2 seconds so vmstorage flushes pending content). It may be okay when
there are a few tests but when there is a 100 of them running tests will
require much more time which will affect the developer wait time and CI
workflows.
- Finally, the integration tests may be flaky especially short term.
An alternative approach would be placing apptest under app package and
exclude apptest from packages under test, but that is not trivial.
The integration tests rely on retrieving some application runtime info
from the application logs, namely the application's host:port. Therefore
some changes to lib/httpserver/httpserver.go were necessary, such as
reporting the effective host:port instead the one from the flag.
### Checklist
The following checks are **mandatory**:
- [x] My change adheres [VictoriaMetrics contributing
guidelines](https://docs.victoriametrics.com/contributing/).
---------
Signed-off-by: Artem Fetishev <rtm@victoriametrics.com>
(cherry picked from commit d7b3589dbd
)
131 lines
3.9 KiB
Go
131 lines
3.9 KiB
Go
package apptest
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Client is used for interacting with the apps over the network.
|
|
//
|
|
// At the moment it only supports HTTP protocol but may be exptended to support
|
|
// RPCs, etc.
|
|
type Client struct {
|
|
httpCli *http.Client
|
|
}
|
|
|
|
// NewClient creates a new client.
|
|
func NewClient() *Client {
|
|
return &Client{
|
|
httpCli: &http.Client{
|
|
Transport: &http.Transport{},
|
|
},
|
|
}
|
|
}
|
|
|
|
// CloseConnections closes client connections.
|
|
func (c *Client) CloseConnections() {
|
|
c.httpCli.CloseIdleConnections()
|
|
}
|
|
|
|
// Get sends a HTTP GET request. Once the function receives a response, it
|
|
// checks whether the response status code matches the expected one and returns
|
|
// the response body to the caller.
|
|
func (c *Client) Get(t *testing.T, url string, wantStatusCode int) string {
|
|
t.Helper()
|
|
return c.do(t, http.MethodGet, url, "", "", wantStatusCode)
|
|
}
|
|
|
|
// Post sends a HTTP POST request. Once the function receives a response, it
|
|
// checks whether the response status code matches the expected one and returns
|
|
// the response body to the caller.
|
|
func (c *Client) Post(t *testing.T, url, contentType, data string, wantStatusCode int) string {
|
|
t.Helper()
|
|
return c.do(t, http.MethodPost, url, contentType, data, wantStatusCode)
|
|
}
|
|
|
|
// PostForm sends a HTTP POST request containing the POST-form data. Once the
|
|
// function receives a response, it checks whether the response status code
|
|
// matches the expected one and returns the response body to the caller.
|
|
func (c *Client) PostForm(t *testing.T, url string, data url.Values, wantStatusCode int) string {
|
|
t.Helper()
|
|
return c.Post(t, url, "application/x-www-form-urlencoded", data.Encode(), wantStatusCode)
|
|
}
|
|
|
|
// do prepares a HTTP request, sends it to the server, receives the response
|
|
// from the server, ensures then response code matches the expected one, reads
|
|
// the rentire response body and returns it to the caller.
|
|
func (c *Client) do(t *testing.T, method, url, contentType, data string, wantStatusCode int) string {
|
|
t.Helper()
|
|
|
|
req, err := http.NewRequest(method, url, strings.NewReader(data))
|
|
if err != nil {
|
|
t.Fatalf("could not create a HTTP request: %v", err)
|
|
}
|
|
|
|
if len(contentType) > 0 {
|
|
req.Header.Add("Content-Type", contentType)
|
|
}
|
|
res, err := c.httpCli.Do(req)
|
|
if err != nil {
|
|
t.Fatalf("could not send HTTP request: %v", err)
|
|
}
|
|
|
|
body := readAllAndClose(t, res.Body)
|
|
|
|
if got, want := res.StatusCode, wantStatusCode; got != want {
|
|
t.Fatalf("unexpected response code: got %d, want %d (body: %s)", got, want, body)
|
|
}
|
|
|
|
return body
|
|
}
|
|
|
|
// readAllAndClose reads everything from the response body and then closes it.
|
|
func readAllAndClose(t *testing.T, responseBody io.ReadCloser) string {
|
|
t.Helper()
|
|
|
|
defer responseBody.Close()
|
|
b, err := io.ReadAll(responseBody)
|
|
if err != nil {
|
|
t.Fatalf("could not read response body: %d", err)
|
|
}
|
|
return string(b)
|
|
}
|
|
|
|
// ServesMetrics is used to retrive the app's metrics.
|
|
//
|
|
// This type is expected to be embdded by the apps that serve metrics.
|
|
type ServesMetrics struct {
|
|
metricsURL string
|
|
cli *Client
|
|
}
|
|
|
|
// GetIntMetric retrieves the value of a metric served by an app at /metrics URL.
|
|
// The value is then converted to int.
|
|
func (app *ServesMetrics) GetIntMetric(t *testing.T, metricName string) int {
|
|
return int(app.GetMetric(t, metricName))
|
|
}
|
|
|
|
// GetMetric retrieves the value of a metric served by an app at /metrics URL.
|
|
func (app *ServesMetrics) GetMetric(t *testing.T, metricName string) float64 {
|
|
t.Helper()
|
|
|
|
metrics := app.cli.Get(t, app.metricsURL, http.StatusOK)
|
|
for _, metric := range strings.Split(metrics, "\n") {
|
|
value, found := strings.CutPrefix(metric, metricName)
|
|
if found {
|
|
value = strings.Trim(value, " ")
|
|
res, err := strconv.ParseFloat(value, 64)
|
|
if err != nil {
|
|
t.Fatalf("could not parse metric value %s: %v", metric, err)
|
|
}
|
|
return res
|
|
}
|
|
}
|
|
t.Fatalf("metic not found: %s", metricName)
|
|
return 0
|
|
}
|