VictoriaMetrics/app
Aliaksandr Valialkin 1b70238dca
lib/promscrape/discovery/kuma: follow-up for 317fef95f9
- Do not generate __meta_server label, since it is unavailable in Prometheus.
- Add a link to https://docs.victoriametrics.com/sd_configs.html#kuma_sd_configs to docs/CHANGELOG.md,
  so users could click it and read the docs without the need to search the corresponding docs.
- Remove kumaTarget struct, since it is easier generating labels for discovered targets
  directly from the response returned by Kuma. This simplifies the code.
- Store the generated labels for discovered targets inside atomic.Value. This allows reading them
  from concurrent goroutines without the need to use mutex.
- Use synchronouse requests to Kuma instead of long polling, since there is a little sense
  in the long polling when the Kuma server may return 304 Not Modified response every -promscrape.kumaSDCheckInterval.
- Remove -promscrape.kuma.waitTime command-line flag, since it is no longer needed when long polling isn't used.
- Set default value for -promscrape.kumaSDCheckInterval to 30s in order to be consistent with Prometheus.
- Remove unnecessary indirections for string literals, which are used only once, in order to improve code readability.
- Remove unused fields from discoveryRequest and discoveryResponse.
- Update tests.
- Document why fetch_timeout and refresh_interval options are missing in kuma_sd_config.
- Add docs to discoveryutils.RequestCallback and discoveryutils.ResponseCallback,
  since these are public types.

Side notes: it is weird that Prometheus implementation for kuma_sd_configs sets `instance` label,
since usually this label is set by the Prometheus itself to __address__ after the relabeling phase.
See https://www.robustperception.io/life-of-a-label/

Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3389

See https://github.com/prometheus/prometheus/issues/7919
and https://github.com/prometheus/prometheus/pull/8844
as a reference implementation in Prometheus
2023-02-22 17:50:54 -08:00
..
vmagent lib/promscrape/discovery/kuma: follow-up for 317fef95f9 2023-02-22 17:50:54 -08:00
vmalert docs: mention rules replay blogpost in vmalert docs (#3851) 2023-02-21 17:44:32 -08:00
vmauth app,lib: fix typos in comments (#3804) 2023-02-13 09:32:35 -08:00
vmbackup all: run apk update && apk upgrade in base Alpine Docker image in order to get all the recent security fixes 2023-02-09 14:03:02 -08:00
vmbackupmanager doc: add vmbackupmanager monitoring section (#3605) 2023-01-05 16:49:59 -08:00
vmctl app/vmctl: add retry backoff policy (#3844) 2023-02-22 12:17:21 -08:00
vmgateway vmgateway: add support of JWKS endpoint usage for JWT keys verification (#521) 2023-02-20 19:23:00 -08:00
vminsert docs: fix typo OpentTSDB -> OpenTSDB (#3854) 2023-02-22 12:11:48 -08:00
vmrestore all: run apk update && apk upgrade in base Alpine Docker image in order to get all the recent security fixes 2023-02-09 14:03:02 -08:00
vmselect app/vmselect: allow zero value for -search.latencyOffset command-line flag 2023-02-21 18:07:27 -08:00
vmstorage lib/protoparser/clusternative: extract stream parsing code into a separate stream package 2023-02-13 10:38:02 -08:00
vmui app/vmui: tooltip formatting enhancements according to https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3706#issuecomment-1429980038 2023-02-14 23:38:05 -08:00