mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-18 14:40:26 +01:00
32aa0751a1
- Use bytesutil.InternString() instead of strings.Clone() for inputKey and outputKey in aggregatorpushSamples(). This should reduce string allocation rate, since strings can be re-used between aggrState flushes. - Reduce memory allocations at dedupAggrShard by storing dedupAggrSample by value in the active series map. - Remove duplicate call to bytesutil.InternBytes() at Deduplicator, since it is already called inside dedupAggr.pushSamples(). - Add missing string interning at rateAggrState.pushSamples(). Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6402
98 lines
2.3 KiB
Go
98 lines
2.3 KiB
Go
package streamaggr
|
|
|
|
import (
|
|
"strconv"
|
|
"sync"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/fasttime"
|
|
"github.com/valyala/histogram"
|
|
)
|
|
|
|
// quantilesAggrState calculates output=quantiles, e.g. the the given quantiles over the input samples.
|
|
type quantilesAggrState struct {
|
|
m sync.Map
|
|
|
|
phis []float64
|
|
}
|
|
|
|
type quantilesStateValue struct {
|
|
mu sync.Mutex
|
|
h *histogram.Fast
|
|
deleted bool
|
|
}
|
|
|
|
func newQuantilesAggrState(phis []float64) *quantilesAggrState {
|
|
return &quantilesAggrState{
|
|
phis: phis,
|
|
}
|
|
}
|
|
|
|
func (as *quantilesAggrState) pushSamples(samples []pushSample) {
|
|
for i := range samples {
|
|
s := &samples[i]
|
|
outputKey := getOutputKey(s.key)
|
|
|
|
again:
|
|
v, ok := as.m.Load(outputKey)
|
|
if !ok {
|
|
// The entry is missing in the map. Try creating it.
|
|
h := histogram.GetFast()
|
|
v = &quantilesStateValue{
|
|
h: h,
|
|
}
|
|
outputKey = bytesutil.InternString(outputKey)
|
|
vNew, loaded := as.m.LoadOrStore(outputKey, v)
|
|
if loaded {
|
|
// Use the entry created by a concurrent goroutine.
|
|
histogram.PutFast(h)
|
|
v = vNew
|
|
}
|
|
}
|
|
sv := v.(*quantilesStateValue)
|
|
sv.mu.Lock()
|
|
deleted := sv.deleted
|
|
if !deleted {
|
|
sv.h.Update(s.value)
|
|
}
|
|
sv.mu.Unlock()
|
|
if deleted {
|
|
// The entry has been deleted by the concurrent call to flushState
|
|
// Try obtaining and updating the entry again.
|
|
goto again
|
|
}
|
|
}
|
|
}
|
|
|
|
func (as *quantilesAggrState) flushState(ctx *flushCtx, resetState bool) {
|
|
currentTimeMsec := int64(fasttime.UnixTimestamp()) * 1000
|
|
m := &as.m
|
|
phis := as.phis
|
|
var quantiles []float64
|
|
var b []byte
|
|
m.Range(func(k, v interface{}) bool {
|
|
if resetState {
|
|
// Atomically delete the entry from the map, so new entry is created for the next flush.
|
|
m.Delete(k)
|
|
}
|
|
|
|
sv := v.(*quantilesStateValue)
|
|
sv.mu.Lock()
|
|
quantiles = sv.h.Quantiles(quantiles[:0], phis)
|
|
histogram.PutFast(sv.h)
|
|
if resetState {
|
|
// Mark the entry as deleted, so it won't be updated anymore by concurrent pushSample() calls.
|
|
sv.deleted = true
|
|
}
|
|
sv.mu.Unlock()
|
|
|
|
key := k.(string)
|
|
for i, quantile := range quantiles {
|
|
b = strconv.AppendFloat(b[:0], phis[i], 'g', -1, 64)
|
|
phiStr := bytesutil.InternBytes(b)
|
|
ctx.appendSeriesWithExtraLabel(key, "quantiles", currentTimeMsec, quantile, "quantile", phiStr)
|
|
}
|
|
return true
|
|
})
|
|
}
|