mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-29 23:30:04 +01:00
318a87c36f
This reverts commit 193a9c3328
.
Reason for revert: the commit doesn't fix the real issue with promutils.NewLabelsFromString()
function, which must return error when improperly formatted Prometheus metric with labels is passed to it.
See https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#text-format-example
E.g. the promutils.NewLabelsFromString() must return error when the following strings are passed to it:
- `{foo:"bar"}`, since `:` is disallowed in Prometheus text exposition format. The corect value is `{foo="bar"}`
- `{"foo":"bar"}`, since label name shouldn't be quoted. The correct value is `{foo="bar"}`.
The reverted commit introduces another set of bugs, which happily accept the following invalid input:
- `{foo=~"bar"}`
- `{foo!="bar"}`
- `{foo!~"bar"}`
Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4284
See also https://github.com/VictoriaMetrics/VictoriaMetrics/pull/4304
125 lines
3.7 KiB
Go
125 lines
3.7 KiB
Go
package promrelabel
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/promutils"
|
|
)
|
|
|
|
// WriteMetricRelabelDebug writes /metric-relabel-debug page to w with the corresponding args.
|
|
func WriteMetricRelabelDebug(w io.Writer, targetID, metric, relabelConfigs, format string, err error) {
|
|
writeRelabelDebug(w, false, targetID, metric, relabelConfigs, format, err)
|
|
}
|
|
|
|
// WriteTargetRelabelDebug writes /target-relabel-debug page to w with the corresponding args.
|
|
func WriteTargetRelabelDebug(w io.Writer, targetID, metric, relabelConfigs, format string, err error) {
|
|
writeRelabelDebug(w, true, targetID, metric, relabelConfigs, format, err)
|
|
}
|
|
|
|
func writeRelabelDebug(w io.Writer, isTargetRelabel bool, targetID, metric, relabelConfigs, format string, err error) {
|
|
if metric == "" {
|
|
metric = "{}"
|
|
}
|
|
targetURL := ""
|
|
if err != nil {
|
|
WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
|
|
return
|
|
}
|
|
labels, err := promutils.NewLabelsFromString(metric)
|
|
if err != nil {
|
|
err = fmt.Errorf("cannot parse metric: %s", err)
|
|
WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
|
|
return
|
|
}
|
|
pcs, err := ParseRelabelConfigsData([]byte(relabelConfigs))
|
|
if err != nil {
|
|
err = fmt.Errorf("cannot parse relabel configs: %s", err)
|
|
WriteRelabelDebugSteps(w, targetURL, targetID, format, nil, metric, relabelConfigs, err)
|
|
return
|
|
}
|
|
|
|
dss, targetURL := newDebugRelabelSteps(pcs, labels, isTargetRelabel)
|
|
WriteRelabelDebugSteps(w, targetURL, targetID, format, dss, metric, relabelConfigs, nil)
|
|
}
|
|
|
|
func newDebugRelabelSteps(pcs *ParsedConfigs, labels *promutils.Labels, isTargetRelabel bool) ([]DebugStep, string) {
|
|
// The target relabeling below must be in sync with the code at scrapeWorkConfig.getScrapeWork if isTargetRelabel=true
|
|
// and with the code at scrapeWork.addRowToTimeseries when isTargetRelabeling=false
|
|
targetURL := ""
|
|
|
|
// Prevent from modifying the original labels
|
|
labels = labels.Clone()
|
|
|
|
// Apply relabeling
|
|
labelsResult, dss := pcs.ApplyDebug(labels.GetLabels())
|
|
labels.Labels = labelsResult
|
|
outStr := LabelsToString(labels.GetLabels())
|
|
|
|
if isTargetRelabel {
|
|
// Add missing instance label
|
|
if labels.Get("instance") == "" {
|
|
address := labels.Get("__address__")
|
|
if address != "" {
|
|
inStr := outStr
|
|
labels.Add("instance", address)
|
|
outStr = LabelsToString(labels.GetLabels())
|
|
dss = append(dss, DebugStep{
|
|
Rule: "add missing instance label from __address__ label",
|
|
In: inStr,
|
|
Out: outStr,
|
|
})
|
|
}
|
|
}
|
|
|
|
// Generate targetURL
|
|
targetURL, _ = GetScrapeURL(labels, nil)
|
|
|
|
// Remove labels with __ prefix
|
|
inStr := outStr
|
|
labels.RemoveLabelsWithDoubleUnderscorePrefix()
|
|
outStr = LabelsToString(labels.GetLabels())
|
|
if inStr != outStr {
|
|
dss = append(dss, DebugStep{
|
|
Rule: "remove labels with __ prefix",
|
|
In: inStr,
|
|
Out: outStr,
|
|
})
|
|
}
|
|
} else {
|
|
// Remove labels with __ prefix except of __name__
|
|
inStr := outStr
|
|
labels.Labels = FinalizeLabels(labels.Labels[:0], labels.Labels)
|
|
outStr = LabelsToString(labels.GetLabels())
|
|
if inStr != outStr {
|
|
dss = append(dss, DebugStep{
|
|
Rule: "remove labels with __ prefix except of __name__",
|
|
In: inStr,
|
|
Out: outStr,
|
|
})
|
|
}
|
|
}
|
|
|
|
// There is no need in labels' sorting, since LabelsToString() automatically sorts labels.
|
|
return dss, targetURL
|
|
}
|
|
|
|
func getChangedLabelNames(in, out *promutils.Labels) map[string]struct{} {
|
|
inMap := in.ToMap()
|
|
outMap := out.ToMap()
|
|
changed := make(map[string]struct{})
|
|
for k, v := range outMap {
|
|
inV, ok := inMap[k]
|
|
if !ok || inV != v {
|
|
changed[k] = struct{}{}
|
|
}
|
|
}
|
|
for k, v := range inMap {
|
|
outV, ok := outMap[k]
|
|
if !ok || outV != v {
|
|
changed[k] = struct{}{}
|
|
}
|
|
}
|
|
return changed
|
|
}
|