mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-13 13:11:37 +01:00
23e1de06ee
* vmagent: add error log for skipped data block when rejected by receiving side Previously, rejected data blocks were silently dropped - only metrics were update. From operational perspective, having an additional logging for such cases is preferable. https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1911 Signed-off-by: hagen1778 <roman@victoriametrics.com> * vmagent: throttle log messages about skipped blocks The new type of logger was added to logger pacakge. This new type supposed to control number of logged messages by time. Signed-off-by: hagen1778 <roman@victoriametrics.com> * lib/logger: make LogThrottler public, so its methods can be inspected by external packages Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
73 lines
1.5 KiB
Go
73 lines
1.5 KiB
Go
package logger
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
var (
|
|
logThrottlerRegistryMu = sync.Mutex{}
|
|
logThrottlerRegistry = make(map[string]*LogThrottler)
|
|
)
|
|
|
|
// WithThrottler returns a logger throttled by time - only one message in throttle duration will be logged.
|
|
//
|
|
// New logger is created only once for each unique name passed.
|
|
// The function is thread-safe.
|
|
func WithThrottler(name string, throttle time.Duration) *LogThrottler {
|
|
logThrottlerRegistryMu.Lock()
|
|
defer logThrottlerRegistryMu.Unlock()
|
|
|
|
lt, ok := logThrottlerRegistry[name]
|
|
if ok {
|
|
return lt
|
|
}
|
|
|
|
lt = newLogThrottler(throttle)
|
|
lt.warnF = Warnf
|
|
lt.errorF = Errorf
|
|
logThrottlerRegistry[name] = lt
|
|
return lt
|
|
}
|
|
|
|
// LogThrottler is a logger, which throttles log messages passed to Warnf and Errorf.
|
|
//
|
|
// LogThrottler must be created via WithThrottler() call.
|
|
type LogThrottler struct {
|
|
ch chan struct{}
|
|
|
|
warnF func(format string, args ...interface{})
|
|
errorF func(format string, args ...interface{})
|
|
}
|
|
|
|
func newLogThrottler(throttle time.Duration) *LogThrottler {
|
|
lt := &LogThrottler{
|
|
ch: make(chan struct{}, 1),
|
|
}
|
|
go func() {
|
|
for {
|
|
<-lt.ch
|
|
time.Sleep(throttle)
|
|
}
|
|
}()
|
|
return lt
|
|
}
|
|
|
|
// Errorf logs error message.
|
|
func (lt *LogThrottler) Errorf(format string, args ...interface{}) {
|
|
select {
|
|
case lt.ch <- struct{}{}:
|
|
lt.errorF(format, args...)
|
|
default:
|
|
}
|
|
}
|
|
|
|
// Warnf logs warn message.
|
|
func (lt *LogThrottler) Warnf(format string, args ...interface{}) {
|
|
select {
|
|
case lt.ch <- struct{}{}:
|
|
lt.warnF(format, args...)
|
|
default:
|
|
}
|
|
}
|