mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-22 00:16:23 +01:00
b485e40823
Currently the docker-compose examples for loading `victoriametrics-datasource` uses 2 environment variables:
- `GF_ALLOW_LOADING_UNSIGNED_PLUGINS`
- `GF_DEFAULT_APP_MODE`
I believe both of the env vars are trying to achieve the same thing. `GF_DEFAULT_APP_MODE` disables code signing for all plugins and `GF_ALLOW_LOADING_UNSIGNED_PLUGINS` intends to disable code signing for just `victoriametrics-datasource`.
Keeping the scope narrowed to just `victoriametrics-datasource` would be preferable in this case.
Unfortunately `GF_ALLOW_LOADING_UNSIGNED_PLUGINS` is misspelled. According to [grafana docs](https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#override-configuration-with-environment-variables), the format is supposed to be `GF_<SectionName>_<KeyName>`. In other words the current env var is missing the section name.
This PR proposes to:
1. fix the typo
2. remove the global disablement of code signing
Alternatively, if you prefer to keep codesigning disabled globally, please remove `GF_ALLOW_LOADING_UNSIGNED_PLUGINS` env var as it confuses things
(cherry picked from commit cc5a274e4d)
26 lines
1002 B
YAML
26 lines
1002 B
YAML
version: "3.5"
|
|
services:
|
|
grafana:
|
|
container_name: grafana
|
|
image: grafana/grafana:10.3.1
|
|
depends_on:
|
|
- "victoriametrics"
|
|
ports:
|
|
- 3000:3000
|
|
entrypoint: [ "/bin/bash", "-c" ]
|
|
command: [ "chmod +x /download.sh && /download.sh && /run.sh" ]
|
|
volumes:
|
|
- grafanadata:/var/lib/grafana
|
|
- ./provisioning/datasources/victoriametrics-datasource:/etc/grafana/provisioning/datasources
|
|
- ./provisioning/dashboards:/etc/grafana/provisioning/dashboards
|
|
- ./provisioning/plugins/:/var/lib/grafana/plugins
|
|
- ./../../dashboards/vm/victoriametrics.json:/var/lib/grafana/dashboards/vm.json
|
|
- ./../../dashboards/vm/vmagent.json:/var/lib/grafana/dashboards/vmagent.json
|
|
- ./../../dashboards/vm/vmalert.json:/var/lib/grafana/dashboards/vmalert.json
|
|
- ./vm-datasource/download.sh:/download.sh
|
|
environment:
|
|
- "GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS=victoriametrics-datasource"
|
|
networks:
|
|
- vm_net
|
|
restart: always
|