mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-22 08:26:19 +01:00
9edeecabc8
This makes easier to read and debug these tests. This also reduces test lines count by 15% from 3K to 2.5K . See https://itnext.io/f-tests-as-a-replacement-for-table-driven-tests-in-go-8814a8b19e9e . While at it, consistently use t.Fatal* instead of t.Error*, since t.Error* usually leads to more complicated and fragile tests, while it doesn't bring any practical benefits over t.Fatal*.
105 lines
2.5 KiB
Go
105 lines
2.5 KiB
Go
package openstack
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/promauth"
|
|
)
|
|
|
|
func TestBuildAuthRequestBody_Failure(t *testing.T) {
|
|
f := func(sdc *SDConfig) {
|
|
t.Helper()
|
|
|
|
_, err := buildAuthRequestBody(sdc)
|
|
if err == nil {
|
|
t.Fatalf("expecting non-nil error")
|
|
}
|
|
}
|
|
|
|
// empty config
|
|
f(&SDConfig{})
|
|
}
|
|
|
|
func TestBuildAuthRequestBody_Success(t *testing.T) {
|
|
f := func(sdc *SDConfig, resultExpected string) {
|
|
t.Helper()
|
|
|
|
result, err := buildAuthRequestBody(sdc)
|
|
if err != nil {
|
|
t.Fatalf("buildAuthRequestBody() error: %s", err)
|
|
}
|
|
if string(result) != resultExpected {
|
|
t.Fatalf("unexpected result\ngot\n%s\nwant\n%s", result, resultExpected)
|
|
}
|
|
}
|
|
|
|
// username password auth with domain
|
|
f(&SDConfig{
|
|
Username: "some-user",
|
|
Password: promauth.NewSecret("some-password"),
|
|
DomainName: "some-domain",
|
|
}, `{"auth":{"identity":{"methods":["password"],"password":{"user":{"name":"some-user","password":"some-password","domain":{"name":"some-domain"}}}},"scope":{"domain":{"name":"some-domain"}}}}`)
|
|
|
|
// application credentials auth
|
|
f(&SDConfig{
|
|
ApplicationCredentialID: "some-id",
|
|
ApplicationCredentialSecret: promauth.NewSecret("some-secret"),
|
|
}, `{"auth":{"identity":{"methods":["application_credential"],"application_credential":{"id":"some-id","secret":"some-secret"}}}}`)
|
|
}
|
|
|
|
func TestGetComputeEndpointURL_Failure(t *testing.T) {
|
|
f := func(catalog []catalogItem) {
|
|
t.Helper()
|
|
|
|
_, err := getComputeEndpointURL(catalog, "", "")
|
|
if err == nil {
|
|
t.Fatalf("expecting non-nil error")
|
|
}
|
|
}
|
|
|
|
// bad catalog data
|
|
catalog := []catalogItem{
|
|
{
|
|
Type: "keystone",
|
|
Endpoints: []endpoint{},
|
|
},
|
|
}
|
|
f(catalog)
|
|
}
|
|
|
|
func TestGetComputeEndpointURL_Success(t *testing.T) {
|
|
f := func(catalog []catalogItem, availability, region, resultExpected string) {
|
|
t.Helper()
|
|
|
|
resultURL, err := getComputeEndpointURL(catalog, availability, region)
|
|
if err != nil {
|
|
t.Fatalf("getComputeEndpointURL() error: %s", err)
|
|
}
|
|
|
|
if resultURL.String() != resultExpected {
|
|
t.Fatalf("unexpected result\ngot\n%s\nwant\n%s", resultURL, resultExpected)
|
|
}
|
|
}
|
|
|
|
// good private url
|
|
catalog := []catalogItem{
|
|
{
|
|
Type: "compute",
|
|
Endpoints: []endpoint{
|
|
{
|
|
Interface: "private",
|
|
Type: "compute",
|
|
URL: "https://compute.test.local:8083/v2.1",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Type: "keystone",
|
|
Endpoints: []endpoint{},
|
|
},
|
|
}
|
|
availability := "private"
|
|
resultExpected := "https://compute.test.local:8083/v2.1"
|
|
f(catalog, availability, "", resultExpected)
|
|
}
|