mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-23 20:37:12 +01:00
5f46f8a11d
The change adds a fastpath for `equalValue` comparisons against `__name__` label by avoiding calls to `toCanonicalLabelName` func. This speedups matches by metric name like `'foo'`. See bench stats below: ``` benchcmp old.txt new.txt benchmark old ns/op new ns/op delta BenchmarkIfExpression/equal_label:_last-10 35.6 35.1 -1.18% BenchmarkIfExpression/equal_label:_middle-10 18.3 17.3 -5.41% BenchmarkIfExpression/equal_label:_first-10 1.20 1.24 +2.74% BenchmarkIfExpression/equal___name__:_last-10 10.1 4.96 -50.75% BenchmarkIfExpression/equal___name__:_middle-10 5.79 3.16 -45.41% BenchmarkIfExpression/equal___name__:_first-10 1.17 1.05 -9.76% ``` Signed-off-by: hagen1778 <roman@victoriametrics.com>
79 lines
1.8 KiB
Go
79 lines
1.8 KiB
Go
package promrelabel
|
|
|
|
import (
|
|
"fmt"
|
|
"gopkg.in/yaml.v2"
|
|
"testing"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/prompbmarshal"
|
|
)
|
|
|
|
func BenchmarkIfExpression(b *testing.B) {
|
|
const maxLabels = 100
|
|
labels := make([]prompbmarshal.Label, maxLabels)
|
|
for i := 0; i < maxLabels; i++ {
|
|
label := prompbmarshal.Label{
|
|
Name: fmt.Sprintf("foo%d", i),
|
|
Value: fmt.Sprintf("bar%d", i),
|
|
}
|
|
labels[i] = label
|
|
}
|
|
|
|
b.Run("equal label: last", func(b *testing.B) {
|
|
n := maxLabels - 1
|
|
ifExpr := fmt.Sprintf(`'{foo%d="bar%d"}'`, n, n)
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
b.Run("equal label: middle", func(b *testing.B) {
|
|
n := maxLabels / 2
|
|
ifExpr := fmt.Sprintf(`'{foo%d="bar%d"}'`, n, n)
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
b.Run("equal label: first", func(b *testing.B) {
|
|
ifExpr := fmt.Sprintf(`'{foo%d="bar%d"}'`, 0, 0)
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
|
|
labels[maxLabels-1] = prompbmarshal.Label{
|
|
Name: "__name__",
|
|
Value: "foo",
|
|
}
|
|
b.Run("equal __name__: last", func(b *testing.B) {
|
|
ifExpr := `foo`
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
|
|
labels[maxLabels/2] = prompbmarshal.Label{
|
|
Name: "__name__",
|
|
Value: "foo",
|
|
}
|
|
b.Run("equal __name__: middle", func(b *testing.B) {
|
|
ifExpr := `foo`
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
|
|
labels[0] = prompbmarshal.Label{
|
|
Name: "__name__",
|
|
Value: "foo",
|
|
}
|
|
b.Run("equal __name__: first", func(b *testing.B) {
|
|
ifExpr := `foo`
|
|
benchIfExpr(b, ifExpr, labels)
|
|
})
|
|
}
|
|
|
|
func benchIfExpr(b *testing.B, expr string, labels []prompbmarshal.Label) {
|
|
b.Helper()
|
|
var ie IfExpression
|
|
if err := yaml.UnmarshalStrict([]byte(expr), &ie); err != nil {
|
|
b.Fatalf("unexpected error during unmarshal: %s", err)
|
|
}
|
|
b.RunParallel(func(pb *testing.PB) {
|
|
for pb.Next() {
|
|
if !ie.Match(labels) {
|
|
panic(fmt.Sprintf("expected to have a match for %q", expr))
|
|
}
|
|
}
|
|
})
|
|
}
|