mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-15 08:23:34 +01:00
28dcff5791
* lib/{httpserver,netutil}: allow to define min and max TLS version of the http server * lib/httpserver: added descriptions about tls supported versions * lib/netutil: check minimal tls version, added supported tls versions to error * wip Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
121 lines
3.0 KiB
Go
121 lines
3.0 KiB
Go
package netutil
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestCipherSuitesFromNames(t *testing.T) {
|
|
type args struct {
|
|
definedCipherSuites []string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want []uint16
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "empty cipher suites",
|
|
args: args{definedCipherSuites: []string{}},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "got wrong string",
|
|
args: args{definedCipherSuites: []string{"word"}},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "got wrong number",
|
|
args: args{definedCipherSuites: []string{"123"}},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "got correct string cipher suite",
|
|
args: args{definedCipherSuites: []string{"TLS_RSA_WITH_AES_128_CBC_SHA", "TLS_RSA_WITH_AES_256_CBC_SHA"}},
|
|
want: []uint16{0x2f, 0x35},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "got correct string with different cases (upper and lower) cipher suite",
|
|
args: args{definedCipherSuites: []string{"tls_rsa_with_aes_128_cbc_sha", "TLS_RSA_WITH_AES_256_CBC_SHA"}},
|
|
want: []uint16{0x2f, 0x35},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "got correct number cipher suite",
|
|
args: args{definedCipherSuites: []string{"0x2f", "0x35"}},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "got insecure number cipher suite",
|
|
args: args{definedCipherSuites: []string{"0x0005", "0x000a"}},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "got insecure string cipher suite",
|
|
args: args{definedCipherSuites: []string{"TLS_ECDHE_ECDSA_WITH_RC4_128_SHA", "TLS_ECDHE_RSA_WITH_RC4_128_SHA"}},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := cipherSuitesFromNames(tt.args.definedCipherSuites)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("cipherSuitesFromNames() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
if !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("validateCipherSuites() got = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseTLSVersionSuccess(t *testing.T) {
|
|
f := func(s string, want uint16) {
|
|
t.Helper()
|
|
got, err := ParseTLSVersion(s)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error for ParseTLSVersion(%q): %s", s, err)
|
|
}
|
|
if got != want {
|
|
t.Fatalf("unexpected value got from ParseTLSVersion(%q); got %d; want %d", s, got, want)
|
|
}
|
|
}
|
|
// lowercase tlsName
|
|
f("tls10", tls.VersionTLS10)
|
|
f("tls11", tls.VersionTLS11)
|
|
f("tls12", tls.VersionTLS12)
|
|
f("tls13", tls.VersionTLS13)
|
|
// uppercase tlsName
|
|
f("TLS10", tls.VersionTLS10)
|
|
f("TLS11", tls.VersionTLS11)
|
|
f("TLS12", tls.VersionTLS12)
|
|
f("TLS13", tls.VersionTLS13)
|
|
// empty tlsName
|
|
f("", 0)
|
|
}
|
|
|
|
func TestParseTLSVersionFailure(t *testing.T) {
|
|
f := func(s string) {
|
|
t.Helper()
|
|
_, err := ParseTLSVersion(s)
|
|
if err == nil {
|
|
t.Fatalf("expecting non-nil error for ParseTLSVersion(%q)", s)
|
|
}
|
|
}
|
|
// incorrect tlsName
|
|
f("123")
|
|
// incorrect tlsName with correct prefix
|
|
f("TLS1")
|
|
// incorrect tls version in tlsName
|
|
f("TLS14")
|
|
}
|