mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-18 14:40:26 +01:00
e4e14697fa
Do not read timestamps for blocks, which cannot contain surrounding logs. This should improve peformance for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6730 . Also optimize min(_time) and max(_time) calculations a bit by avoiding conversion of timestamp to string when it isn't needed. This should improve performance for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7070 .
176 lines
3.9 KiB
Go
176 lines
3.9 KiB
Go
package logstorage
|
|
|
|
import (
|
|
"math"
|
|
"strings"
|
|
"unsafe"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
|
|
)
|
|
|
|
type statsMax struct {
|
|
fields []string
|
|
}
|
|
|
|
func (sm *statsMax) String() string {
|
|
return "max(" + statsFuncFieldsToString(sm.fields) + ")"
|
|
}
|
|
|
|
func (sm *statsMax) updateNeededFields(neededFields fieldsSet) {
|
|
updateNeededFieldsForStatsFunc(neededFields, sm.fields)
|
|
}
|
|
|
|
func (sm *statsMax) newStatsProcessor() (statsProcessor, int) {
|
|
smp := &statsMaxProcessor{
|
|
sm: sm,
|
|
}
|
|
return smp, int(unsafe.Sizeof(*smp))
|
|
}
|
|
|
|
type statsMaxProcessor struct {
|
|
sm *statsMax
|
|
|
|
max string
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) updateStatsForAllRows(br *blockResult) int {
|
|
maxLen := len(smp.max)
|
|
|
|
if len(smp.sm.fields) == 0 {
|
|
// Find the minimum value across all the columns
|
|
for _, c := range br.getColumns() {
|
|
smp.updateStateForColumn(br, c)
|
|
}
|
|
} else {
|
|
// Find the minimum value across the requested columns
|
|
for _, field := range smp.sm.fields {
|
|
c := br.getColumnByName(field)
|
|
smp.updateStateForColumn(br, c)
|
|
}
|
|
}
|
|
|
|
return len(smp.max) - maxLen
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) updateStatsForRow(br *blockResult, rowIdx int) int {
|
|
maxLen := len(smp.max)
|
|
|
|
if len(smp.sm.fields) == 0 {
|
|
// Find the minimum value across all the fields for the given row
|
|
for _, c := range br.getColumns() {
|
|
v := c.getValueAtRow(br, rowIdx)
|
|
smp.updateStateString(v)
|
|
}
|
|
} else {
|
|
// Find the minimum value across the requested fields for the given row
|
|
for _, field := range smp.sm.fields {
|
|
c := br.getColumnByName(field)
|
|
v := c.getValueAtRow(br, rowIdx)
|
|
smp.updateStateString(v)
|
|
}
|
|
}
|
|
|
|
return maxLen - len(smp.max)
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) mergeState(sfp statsProcessor) {
|
|
src := sfp.(*statsMaxProcessor)
|
|
smp.updateStateString(src.max)
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) updateStateForColumn(br *blockResult, c *blockResultColumn) {
|
|
if br.rowsLen == 0 {
|
|
return
|
|
}
|
|
|
|
if c.isTime {
|
|
timestamp, ok := TryParseTimestampRFC3339Nano(smp.max)
|
|
if !ok {
|
|
timestamp = -1 << 63
|
|
}
|
|
maxTimestamp := br.getMaxTimestamp(timestamp)
|
|
if maxTimestamp <= timestamp {
|
|
return
|
|
}
|
|
|
|
bb := bbPool.Get()
|
|
bb.B = marshalTimestampRFC3339NanoString(bb.B[:0], maxTimestamp)
|
|
smp.updateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
|
|
return
|
|
}
|
|
if c.isConst {
|
|
// Special case for const column
|
|
v := c.valuesEncoded[0]
|
|
smp.updateStateString(v)
|
|
return
|
|
}
|
|
|
|
switch c.valueType {
|
|
case valueTypeString:
|
|
for _, v := range c.getValuesEncoded(br) {
|
|
smp.updateStateString(v)
|
|
}
|
|
case valueTypeDict:
|
|
for _, v := range c.dictValues {
|
|
smp.updateStateString(v)
|
|
}
|
|
case valueTypeUint8, valueTypeUint16, valueTypeUint32, valueTypeUint64:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalUint64String(bb.B[:0], c.maxValue)
|
|
smp.updateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeFloat64:
|
|
f := math.Float64frombits(c.maxValue)
|
|
bb := bbPool.Get()
|
|
bb.B = marshalFloat64String(bb.B[:0], f)
|
|
smp.updateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeIPv4:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalIPv4String(bb.B[:0], uint32(c.maxValue))
|
|
smp.updateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeTimestampISO8601:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalTimestampISO8601String(bb.B[:0], int64(c.maxValue))
|
|
smp.updateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
default:
|
|
logger.Panicf("BUG: unknown valueType=%d", c.valueType)
|
|
}
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) updateStateBytes(b []byte) {
|
|
v := bytesutil.ToUnsafeString(b)
|
|
smp.updateStateString(v)
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) updateStateString(v string) {
|
|
if v == "" {
|
|
// Skip empty strings
|
|
return
|
|
}
|
|
if smp.max != "" && !lessString(smp.max, v) {
|
|
return
|
|
}
|
|
smp.max = strings.Clone(v)
|
|
}
|
|
|
|
func (smp *statsMaxProcessor) finalizeStats() string {
|
|
return smp.max
|
|
}
|
|
|
|
func parseStatsMax(lex *lexer) (*statsMax, error) {
|
|
fields, err := parseStatsFuncFields(lex, "max")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
sm := &statsMax{
|
|
fields: fields,
|
|
}
|
|
return sm, nil
|
|
}
|