VictoriaMetrics/app/vmauth
Zakhar Bessarab 3f618c0485
app/vmauth: do not increment backend_errors when hitting concurrency limit (#6078)
* app/vmauth: do not increment backend_errors when hitting concurrency limit

Previously, both "vmauth_concurrent_requests_limit_reached_total" and "vmauth_user_request_backend_errors_total" were incremented.
This was based on the assumption that if concurrency limit is hit the backend must be failing to handle the request thus meaning an error.

This assumption does not work in case the endpoint can be overloaded by the misbehaving client sending too many requests within the timeframe.

Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>

* Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5565

Signed-off-by: hagen1778 <roman@victoriametrics.com>

---------

Signed-off-by: Zakhar Bessarab <z.bessarab@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
Co-authored-by: hagen1778 <roman@victoriametrics.com>
2024-04-17 12:34:33 +02:00
..
deployment app/vmauth: add initial version of vmauth. See https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/app/vmauth/README.md for details 2020-05-05 10:56:20 +03:00
multiarch all: run apk update && apk upgrade in base Alpine Docker image in order to get all the recent security fixes 2023-02-09 14:03:02 -08:00
auth_config_test.go app/vmauth: add ability to authorize via any opaque HTTP request header value 2024-04-03 02:52:39 +03:00
auth_config.go app/vmauth: add ability to authorize via any opaque HTTP request header value 2024-04-03 02:52:39 +03:00
example_config_ent.yml vmauth: add browser authorization request for http requests without… (#5234) 2023-11-01 21:00:52 +01:00
example_config.yml app/vmauth: adds metric_labels and backend_errors counter (#5585) 2024-01-22 01:09:51 +02:00
main_test.go app/vmauth: retry requests at other backends on 5xx response status codes 2023-09-08 00:47:57 +02:00
main.go app/vmauth: do not increment backend_errors when hitting concurrency limit (#6078) 2024-04-17 12:34:33 +02:00
Makefile all: add makefile rules for GOARCH=s390x for all the VictoriaMetrics components 2023-02-26 12:38:48 -08:00
README.md docs: convert png images to webp in all the docs except of docs/operator/* 2023-11-22 19:29:47 +02:00
target_url_test.go app/vmauth: allow discovering backend ips behind shared hostname and spreading load among the discovered ips 2024-03-07 01:02:38 +02:00
target_url.go app/vmauth: add src_headers option at url_map, which allows routing incoming requests to different backends depending on request headers 2024-03-06 21:56:42 +02:00

See vmauth docs here.

vmauth docs can be edited at docs/vmauth.md.