mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-29 23:30:04 +01:00
285841bcce
Return error if the provided latency_offset query arg cannot be parsed. This should simplify debugging in production. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/3481
232 lines
5.5 KiB
Go
232 lines
5.5 KiB
Go
package prometheus
|
|
|
|
import (
|
|
"math"
|
|
"net/http"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/app/vmselect/netstorage"
|
|
)
|
|
|
|
func TestRemoveEmptyValuesAndTimeseries(t *testing.T) {
|
|
f := func(tss []netstorage.Result, tssExpected []netstorage.Result) {
|
|
t.Helper()
|
|
tss = removeEmptyValuesAndTimeseries(tss)
|
|
if !reflect.DeepEqual(tss, tssExpected) {
|
|
t.Fatalf("unexpected result; got %v; want %v", tss, tssExpected)
|
|
}
|
|
}
|
|
|
|
f(nil, nil)
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, 3},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400},
|
|
Values: []float64{nan, nan, 3, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{1, 2},
|
|
Values: []float64{nan, nan},
|
|
},
|
|
{
|
|
Timestamps: nil,
|
|
Values: nil,
|
|
},
|
|
}, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, 3},
|
|
},
|
|
{
|
|
Timestamps: []int64{300},
|
|
Values: []float64{3},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestAdjustLastPoints(t *testing.T) {
|
|
f := func(tss []netstorage.Result, start, end int64, tssExpected []netstorage.Result) {
|
|
t.Helper()
|
|
tss = adjustLastPoints(tss, start, end)
|
|
for i, ts := range tss {
|
|
for j, value := range ts.Values {
|
|
expectedValue := tssExpected[i].Values[j]
|
|
if math.IsNaN(expectedValue) {
|
|
if !math.IsNaN(value) {
|
|
t.Fatalf("unexpected value for time series #%d at position %d; got %v; want nan", i, j, value)
|
|
}
|
|
} else if expectedValue != value {
|
|
t.Fatalf("unexpected value for time series #%d at position %d; got %v; want %v", i, j, value, expectedValue)
|
|
}
|
|
}
|
|
if !reflect.DeepEqual(ts.Timestamps, tssExpected[i].Timestamps) {
|
|
t.Fatalf("unexpected timestamps for time series #%d; got %v; want %v", i, tss, tssExpected)
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
nan := math.NaN()
|
|
|
|
f(nil, 300, 500, nil)
|
|
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 4, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
}, 400, 500, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 4, 4},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
})
|
|
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, nan, nan, nan},
|
|
},
|
|
}, 300, 500, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 3, 3},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, nan, nan, nan},
|
|
},
|
|
})
|
|
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, nan, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, nan, nan, nan, nan},
|
|
},
|
|
}, 500, 300, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, nan, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, nan, nan, nan, nan},
|
|
},
|
|
})
|
|
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 4, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400},
|
|
Values: []float64{1, 2, 3, 4},
|
|
},
|
|
}, 400, 500, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 4, 4},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400},
|
|
Values: []float64{1, 2, 3, 4},
|
|
},
|
|
})
|
|
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, nan},
|
|
},
|
|
}, 300, 600, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, 3, 3},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, nan},
|
|
},
|
|
})
|
|
|
|
// Check for timestamps outside the configured time range.
|
|
// See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/625
|
|
f([]netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, 45},
|
|
},
|
|
}, 250, 400, []netstorage.Result{
|
|
{
|
|
Timestamps: []int64{100, 200, 300, 400, 500},
|
|
Values: []float64{1, 2, 3, nan, nan},
|
|
},
|
|
{
|
|
Timestamps: []int64{100, 200, 300},
|
|
Values: []float64{1, 2, 2},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestGetLatencyOffsetMillisecondsSuccess(t *testing.T) {
|
|
f := func(url string, expectedOffset int64) {
|
|
t.Helper()
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error in NewRequest(%q): %s", url, err)
|
|
}
|
|
offset, err := getLatencyOffsetMilliseconds(r)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
if offset != expectedOffset {
|
|
t.Fatalf("unexpected offset got %d; want %d", offset, expectedOffset)
|
|
}
|
|
}
|
|
f("http://localhost", latencyOffset.Milliseconds())
|
|
f("http://localhost?latency_offset=1.234s", 1234)
|
|
}
|
|
|
|
func TestGetLatencyOffsetMillisecondsFailure(t *testing.T) {
|
|
f := func(url string) {
|
|
t.Helper()
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error in NewRequest(%q): %s", url, err)
|
|
}
|
|
if _, err := getLatencyOffsetMilliseconds(r); err == nil {
|
|
t.Fatalf("expecting non-nil error")
|
|
}
|
|
}
|
|
f("http://localhost?latency_offset=foobar")
|
|
}
|