mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-18 14:40:26 +01:00
04a304fd39
This simplifies debugging tests and makes the test code more clear and concise.
See https://itnext.io/f-tests-as-a-replacement-for-table-driven-tests-in-go-8814a8b19e9e
While at is, consistently use t.Fatal* instead of t.Error* across tests, since t.Error*
requires more boilerplate code, which can result in additional bugs inside tests.
While t.Error* allows writing logging errors for the same, this doesn't simplify fixing
broken tests most of the time.
This is a follow-up for a9525da8a4
82 lines
1.9 KiB
Go
82 lines
1.9 KiB
Go
package influx
|
|
|
|
import (
|
|
"encoding/json"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestSeriesUnmarshal(t *testing.T) {
|
|
f := func(s string, resultExpected *Series) {
|
|
t.Helper()
|
|
|
|
result := &Series{}
|
|
if err := result.unmarshal(s); err != nil {
|
|
t.Fatalf("cannot unmarshal series from %q: %s", s, err)
|
|
}
|
|
if !reflect.DeepEqual(result, resultExpected) {
|
|
t.Fatalf("unexpected result\ngot\n%v\nwant\n%v", result, resultExpected)
|
|
}
|
|
}
|
|
|
|
tag := func(name, value string) LabelPair {
|
|
return LabelPair{
|
|
Name: name,
|
|
Value: value,
|
|
}
|
|
}
|
|
series := func(measurement string, lp ...LabelPair) *Series {
|
|
return &Series{
|
|
Measurement: measurement,
|
|
LabelPairs: lp,
|
|
}
|
|
}
|
|
|
|
f("cpu", series("cpu"))
|
|
|
|
f("cpu,host=localhost", series("cpu", tag("host", "localhost")))
|
|
|
|
f("cpu,host=localhost,instance=instance", series("cpu", tag("host", "localhost"), tag("instance", "instance")))
|
|
|
|
f(`fo\,bar\=baz,x\=\b=\\a\,\=\q\ `, series("fo,bar=baz", tag(`x=\b`, `\a,=\q `)))
|
|
|
|
f("cpu,host=192.168.0.1,instance=fe80::fdc8:5e36:c2c6:baac%utun1", series("cpu", tag("host", "192.168.0.1"), tag("instance", "fe80::fdc8:5e36:c2c6:baac%utun1")))
|
|
|
|
f(`cpu,db=db1,host=localhost,server=host\=localhost\ user\=user\ `, series("cpu", tag("db", "db1"), tag("host", "localhost"), tag("server", "host=localhost user=user ")))
|
|
}
|
|
|
|
func TestToFloat64_Failure(t *testing.T) {
|
|
f := func(in any) {
|
|
t.Helper()
|
|
|
|
_, err := toFloat64(in)
|
|
if err == nil {
|
|
t.Fatalf("expecting non-nil error")
|
|
}
|
|
}
|
|
|
|
f("text")
|
|
}
|
|
|
|
func TestToFloat64_Success(t *testing.T) {
|
|
f := func(in any, resultExpected float64) {
|
|
t.Helper()
|
|
|
|
result, err := toFloat64(in)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
if result != resultExpected {
|
|
t.Fatalf("unexpected result: got %v; want %v", result, resultExpected)
|
|
}
|
|
}
|
|
|
|
f("123.4", 123.4)
|
|
f(float64(123.4), 123.4)
|
|
f(float32(12), 12)
|
|
f(123, 123)
|
|
f(true, 1)
|
|
f(false, 0)
|
|
f(json.Number("123456.789"), 123456.789)
|
|
}
|