mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-11-23 12:31:07 +01:00
a19a4f34ff
Previously, map for storing tenant metrics was re-created to each newly ingested tenant. It has significant performance impact for systems with large number of tenants.
This commit addresses this issue by changing algorithm of creating tenant metric records at map. Instead of map re-creation, it uses `sync.Map` primitive.
Benchmark results:
```
goos: linux
goarch: amd64
pkg: github.com/VictoriaMetrics/VictoriaMetrics/lib/tenantmetrics
cpu: AMD Ryzen 9 5900X 12-Core Processor
│ lib/tenantmetrics/orig.bench │ lib/tenantmetrics/new.bench │
│ sec/op │ sec/op vs base │
CounterMapGrowth/n=100,nProcs=GOMAXPROCS-24 1943.2µ ± 5% 248.0µ ± 11% -87.24% (p=0.001 n=7)
CounterMapGrowth/n=100-24 434.63µ ± 5% 98.82µ ± 16% -77.26% (p=0.001 n=7)
CounterMapGrowth/n=1000-24 32.719m ± 20% 1.425m ± 5% -95.65% (p=0.001 n=7)
CounterMapGrowth/n=10000-24 3653.60m ± 5% 18.00m ± 2% -99.51% (p=0.001 n=7)
geomean 17.83m 890.4µ -95.00%
```
Related issue:
https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7482
---
Co-authored-by: Artem Fetishev <rtm@victoriametrics.com>
|
||
|---|---|---|
| .. | ||
| counter_map_test.go | ||
| counter_map_timing_test.go | ||
| counter_map.go | ||