mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-20 23:46:23 +01:00
2bbf62b6f6
Previously byte slices up to 2^20 bytes (e.g. 1Mb) were cached because of a typo in the commit c14dafce43 .
This could result in increased memory usage when vmagent scrapes many regular targets, which expose
relatively small number of metrics (e.g. up to a few thousand per target) and a few large targets such as kube-state-metrics,
which expose more than 10 thousand metrics. This is common case for Kubernetes monitoring.
While at it, remove pools for very small byte slices, since they are rarely used during scraping.
61 lines
1.3 KiB
Go
61 lines
1.3 KiB
Go
package leveledbytebufferpool
|
|
|
|
import (
|
|
"math/bits"
|
|
"sync"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
)
|
|
|
|
// pools contains pools for byte slices of various capacities.
|
|
//
|
|
// pools[0] is for capacities from 0 to 64
|
|
// pools[1] is for capacities from 65 to 128
|
|
// pools[2] is for capacities from 129 to 256
|
|
// ...
|
|
// pools[n] is for capacities from 2^(n+5)+1 to 2^(n+6)
|
|
//
|
|
// Limit the maximum capacity to 2^18, since there are no performance benefits
|
|
// in caching byte slices with bigger capacities.
|
|
var pools [12]sync.Pool
|
|
|
|
// Get returns byte buffer with the given capacity.
|
|
func Get(capacity int) *bytesutil.ByteBuffer {
|
|
id, capacityNeeded := getPoolIDAndCapacity(capacity)
|
|
for i := 0; i < 2; i++ {
|
|
if id < 0 || id >= len(pools) {
|
|
break
|
|
}
|
|
if v := pools[id].Get(); v != nil {
|
|
return v.(*bytesutil.ByteBuffer)
|
|
}
|
|
id++
|
|
}
|
|
return &bytesutil.ByteBuffer{
|
|
B: make([]byte, 0, capacityNeeded),
|
|
}
|
|
}
|
|
|
|
// Put returns bb to the pool.
|
|
func Put(bb *bytesutil.ByteBuffer) {
|
|
capacity := cap(bb.B)
|
|
id, poolCapacity := getPoolIDAndCapacity(capacity)
|
|
if capacity <= poolCapacity {
|
|
bb.Reset()
|
|
pools[id].Put(bb)
|
|
}
|
|
}
|
|
|
|
func getPoolIDAndCapacity(size int) (int, int) {
|
|
size--
|
|
if size < 0 {
|
|
size = 0
|
|
}
|
|
size >>= 6
|
|
id := bits.Len(uint(size))
|
|
if id >= len(pools) {
|
|
id = len(pools) - 1
|
|
}
|
|
return id, (1 << (id + 6))
|
|
}
|