mirror of
https://github.com/VictoriaMetrics/VictoriaMetrics.git
synced 2024-12-23 00:46:23 +01:00
e4e14697fa
Do not read timestamps for blocks, which cannot contain surrounding logs. This should improve peformance for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/6730 . Also optimize min(_time) and max(_time) calculations a bit by avoiding conversion of timestamp to string when it isn't needed. This should improve performance for https://github.com/VictoriaMetrics/VictoriaMetrics/issues/7070 .
252 lines
5.8 KiB
Go
252 lines
5.8 KiB
Go
package logstorage
|
|
|
|
import (
|
|
"fmt"
|
|
"math"
|
|
"slices"
|
|
"strings"
|
|
"unsafe"
|
|
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/bytesutil"
|
|
"github.com/VictoriaMetrics/VictoriaMetrics/lib/logger"
|
|
)
|
|
|
|
type statsRowMax struct {
|
|
srcField string
|
|
|
|
fetchFields []string
|
|
}
|
|
|
|
func (sm *statsRowMax) String() string {
|
|
s := "row_max(" + quoteTokenIfNeeded(sm.srcField)
|
|
if len(sm.fetchFields) > 0 {
|
|
s += ", " + fieldNamesString(sm.fetchFields)
|
|
}
|
|
s += ")"
|
|
return s
|
|
}
|
|
|
|
func (sm *statsRowMax) updateNeededFields(neededFields fieldsSet) {
|
|
if len(sm.fetchFields) == 0 {
|
|
neededFields.add("*")
|
|
} else {
|
|
neededFields.addFields(sm.fetchFields)
|
|
}
|
|
neededFields.add(sm.srcField)
|
|
}
|
|
|
|
func (sm *statsRowMax) newStatsProcessor() (statsProcessor, int) {
|
|
smp := &statsRowMaxProcessor{
|
|
sm: sm,
|
|
}
|
|
return smp, int(unsafe.Sizeof(*smp))
|
|
}
|
|
|
|
type statsRowMaxProcessor struct {
|
|
sm *statsRowMax
|
|
|
|
max string
|
|
|
|
fields []Field
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) updateStatsForAllRows(br *blockResult) int {
|
|
stateSizeIncrease := 0
|
|
|
|
c := br.getColumnByName(smp.sm.srcField)
|
|
if c.isConst {
|
|
v := c.valuesEncoded[0]
|
|
stateSizeIncrease += smp.updateState(v, br, 0)
|
|
return stateSizeIncrease
|
|
}
|
|
if c.isTime {
|
|
timestamp, ok := TryParseTimestampRFC3339Nano(smp.max)
|
|
if !ok {
|
|
timestamp = -1 << 63
|
|
}
|
|
maxTimestamp := br.getMaxTimestamp(timestamp)
|
|
if maxTimestamp <= timestamp {
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
bb := bbPool.Get()
|
|
bb.B = marshalTimestampRFC3339NanoString(bb.B[:0], maxTimestamp)
|
|
v := bytesutil.ToUnsafeString(bb.B)
|
|
stateSizeIncrease += smp.updateState(v, br, 0)
|
|
bbPool.Put(bb)
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
needUpdateState := false
|
|
switch c.valueType {
|
|
case valueTypeString:
|
|
needUpdateState = true
|
|
case valueTypeDict:
|
|
for _, v := range c.dictValues {
|
|
if smp.needUpdateStateString(v) {
|
|
needUpdateState = true
|
|
break
|
|
}
|
|
}
|
|
case valueTypeUint8, valueTypeUint16, valueTypeUint32, valueTypeUint64:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalUint64String(bb.B[:0], c.maxValue)
|
|
needUpdateState = smp.needUpdateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeFloat64:
|
|
f := math.Float64frombits(c.maxValue)
|
|
bb := bbPool.Get()
|
|
bb.B = marshalFloat64String(bb.B[:0], f)
|
|
needUpdateState = smp.needUpdateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeIPv4:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalIPv4String(bb.B[:0], uint32(c.maxValue))
|
|
needUpdateState = smp.needUpdateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
case valueTypeTimestampISO8601:
|
|
bb := bbPool.Get()
|
|
bb.B = marshalTimestampISO8601String(bb.B[:0], int64(c.maxValue))
|
|
needUpdateState = smp.needUpdateStateBytes(bb.B)
|
|
bbPool.Put(bb)
|
|
default:
|
|
logger.Panicf("BUG: unknown valueType=%d", c.valueType)
|
|
}
|
|
|
|
if needUpdateState {
|
|
values := c.getValues(br)
|
|
for i, v := range values {
|
|
stateSizeIncrease += smp.updateState(v, br, i)
|
|
}
|
|
}
|
|
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) updateStatsForRow(br *blockResult, rowIdx int) int {
|
|
stateSizeIncrease := 0
|
|
|
|
c := br.getColumnByName(smp.sm.srcField)
|
|
if c.isConst {
|
|
v := c.valuesEncoded[0]
|
|
stateSizeIncrease += smp.updateState(v, br, rowIdx)
|
|
return stateSizeIncrease
|
|
}
|
|
if c.isTime {
|
|
timestamps := br.getTimestamps()
|
|
bb := bbPool.Get()
|
|
bb.B = marshalTimestampRFC3339NanoString(bb.B[:0], timestamps[rowIdx])
|
|
v := bytesutil.ToUnsafeString(bb.B)
|
|
stateSizeIncrease += smp.updateState(v, br, rowIdx)
|
|
bbPool.Put(bb)
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
v := c.getValueAtRow(br, rowIdx)
|
|
stateSizeIncrease += smp.updateState(v, br, rowIdx)
|
|
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) mergeState(sfp statsProcessor) {
|
|
src := sfp.(*statsRowMaxProcessor)
|
|
if smp.needUpdateStateString(src.max) {
|
|
smp.max = src.max
|
|
smp.fields = src.fields
|
|
}
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) needUpdateStateBytes(b []byte) bool {
|
|
v := bytesutil.ToUnsafeString(b)
|
|
return smp.needUpdateStateString(v)
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) needUpdateStateString(v string) bool {
|
|
if v == "" {
|
|
return false
|
|
}
|
|
return smp.max == "" || lessString(smp.max, v)
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) updateState(v string, br *blockResult, rowIdx int) int {
|
|
stateSizeIncrease := 0
|
|
|
|
if !smp.needUpdateStateString(v) {
|
|
// There is no need in updating state
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
stateSizeIncrease -= len(smp.max)
|
|
stateSizeIncrease += len(v)
|
|
smp.max = strings.Clone(v)
|
|
|
|
fields := smp.fields
|
|
for _, f := range fields {
|
|
stateSizeIncrease -= len(f.Name) + len(f.Value)
|
|
}
|
|
|
|
clear(fields)
|
|
fields = fields[:0]
|
|
fetchFields := smp.sm.fetchFields
|
|
if len(fetchFields) == 0 {
|
|
cs := br.getColumns()
|
|
for _, c := range cs {
|
|
v := c.getValueAtRow(br, rowIdx)
|
|
fields = append(fields, Field{
|
|
Name: strings.Clone(c.name),
|
|
Value: strings.Clone(v),
|
|
})
|
|
stateSizeIncrease += len(c.name) + len(v)
|
|
}
|
|
} else {
|
|
for _, field := range fetchFields {
|
|
c := br.getColumnByName(field)
|
|
v := c.getValueAtRow(br, rowIdx)
|
|
fields = append(fields, Field{
|
|
Name: strings.Clone(c.name),
|
|
Value: strings.Clone(v),
|
|
})
|
|
stateSizeIncrease += len(c.name) + len(v)
|
|
}
|
|
}
|
|
smp.fields = fields
|
|
|
|
return stateSizeIncrease
|
|
}
|
|
|
|
func (smp *statsRowMaxProcessor) finalizeStats() string {
|
|
bb := bbPool.Get()
|
|
bb.B = MarshalFieldsToJSON(bb.B, smp.fields)
|
|
result := string(bb.B)
|
|
bbPool.Put(bb)
|
|
|
|
return result
|
|
}
|
|
|
|
func parseStatsRowMax(lex *lexer) (*statsRowMax, error) {
|
|
if !lex.isKeyword("row_max") {
|
|
return nil, fmt.Errorf("unexpected func; got %q; want 'row_max'", lex.token)
|
|
}
|
|
lex.nextToken()
|
|
fields, err := parseFieldNamesInParens(lex)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("cannot parse 'row_max' args: %w", err)
|
|
}
|
|
|
|
if len(fields) == 0 {
|
|
return nil, fmt.Errorf("missing first arg for 'row_max' func - source field")
|
|
}
|
|
|
|
srcField := fields[0]
|
|
fetchFields := fields[1:]
|
|
if slices.Contains(fetchFields, "*") {
|
|
fetchFields = nil
|
|
}
|
|
|
|
sm := &statsRowMax{
|
|
srcField: srcField,
|
|
fetchFields: fetchFields,
|
|
}
|
|
return sm, nil
|
|
}
|