Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-359709: Add RBAC check to BugToolWizard.cs

Browse Source 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
This commit is contained in:
Danilo Del Busso 2021-10-28 12:36:10 +01:00 committed by Danilo Del Busso
parent c5f1544fd9
commit 02d4434572
2 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
XenAdmin/Wizards/BugToolWizardFiles/BugToolWizard.cs
View File

@ -30,6 +30,7 @@
*/
using System;
using System.Collections.Generic;
using System.Linq;
using System.Windows.Forms;
@ -39,6 +40,8 @@ using XenAPI;
using XenAdmin.Wizards.BugToolWizardFiles;
using XenAdmin.Dialogs;
using XenAdmin.Actions;
using XenAdmin.Network;
using XenAdmin.Wizards.GenericPages;
namespace XenAdmin.Wizards
{
@ -48,6 +51,7 @@ namespace XenAdmin.Wizards
private readonly GenericSelectHostsPage bugToolPageSelectHosts1;
private readonly BugToolPageSelectCapabilities bugToolPageSelectCapabilities1;
private readonly RBACWarningPage rbacWarningPage;
private readonly BugToolPageRetrieveData bugToolPageRetrieveData;
private readonly BugToolPageDestination bugToolPageDestination1;
@ -63,6 +67,7 @@ namespace XenAdmin.Wizards
bugToolPageSelectHosts1 = new GenericSelectHostsPage();
bugToolPageSelectCapabilities1 = new BugToolPageSelectCapabilities();
rbacWarningPage = new RBACWarningPage();
bugToolPageRetrieveData = new BugToolPageRetrieveData();
bugToolPageDestination1 = new BugToolPageDestination();
@ -133,14 +138,51 @@ namespace XenAdmin.Wizards
protected override void UpdateWizardContent(XenTabPage senderPage)
{
var prevPageType = senderPage.GetType();
if (prevPageType == typeof(GenericSelectHostsPage))
{
bugToolPageRetrieveData.SelectedHosts = bugToolPageSelectHosts1.SelectedHosts;
var selectedHostsConnections = bugToolPageSelectHosts1.SelectedHosts.Select(host => host.Connection).ToList();
if (selectedHostsConnections.Any(ConnectionRequiresRBAC))
{
ConfigureRbacPage(selectedHostsConnections, SingleHostStatusAction.StaticRBACDependencies, Messages.RBAC_CROSS_POOL_MIGRATE_VM_BLOCKED);
AddAfterPage(bugToolPageSelectHosts1, rbacWarningPage);
}
}
else if (prevPageType == typeof(BugToolPageSelectCapabilities))
{
bugToolPageRetrieveData.CapabilityList = bugToolPageSelectCapabilities1.Capabilities;
}
}
private static bool ConnectionRequiresRBAC(IXenConnection connection)
{
if (connection == null)
throw new NullReferenceException("RBAC check was given a null connection");
if (connection.Session.IsLocalSuperuser)
return false;
return Helpers.GetCoordinator(connection).external_auth_type != Auth.AUTH_TYPE_NONE;
}
private void ConfigureRbacPage(IEnumerable<IXenConnection> connectionsToCheck, RbacMethodList apiMethodsToCheck, string pageMessage)
{
rbacWarningPage.ClearPermissionChecks();
var permissionCheck = new RBACWarningPage.WizardPermissionCheck(pageMessage) { Blocking = true };
permissionCheck.AddApiCheckRange(apiMethodsToCheck);
var connectionsAdded = new List<IXenConnection>();
foreach (var connection in connectionsToCheck)
{
if (!connectionsAdded.Contains(connection))
{
rbacWarningPage.AddPermissionChecks(connection, permissionCheck);
connectionsAdded.Add(connection);
}
}
}

10
XenModel/Actions/Host/SingleHostStatusAction.cs
View File

@ -58,6 +58,16 @@ namespace XenAdmin.Actions
public long DataTransferred;
public static RbacMethodList StaticRBACDependencies
{
get
{
var list = new RbacMethodList("HTTP/get_system_status");
list.AddRange(Role.CommonSessionApiList);
list.AddRange(Role.CommonTaskApiList);
return list;
}
}
protected override void Run()
{
Description = string.Format(Messages.ACTION_SYSTEM_STATUS_COMPILING, Helpers.GetName(host));